Jump to content

  •  

Bug Tracker Migration

June 3rd
Good news everyone! The staff has decided that it is time to slowly kill off this Bug Tracker. We will begin the process of slowly migrating from this Bug Tracker over to our Github Issues which can be found here: https://github.com/HerculesWS/Hercules/issues

Over the next couple of days, I will be closing off any opportunity to create new reports. However, I still will keep the opportunity to reply to existing Bug Reports. Doing this will allow us to slowly fix any bug reports we have listed here so that we can easily migrate over to our Issue Tracker.

Update - June 7th 2015: Creating new bug posts has been disabled. Please use our https://github.com/HerculesWS/Hercules/issues tracker to post bugs. Users are still able to reply to existing bug posts.

- Administration

Issue Information

  • #007307

  • 0 - None Assigned

  • Fixed

Issue Confirmations

  • Yes (1)No (0)
Photo

Status Weapon Switch

Posted by kyeme on 31 May 2013 - 01:05 PM

Example:
When you cast Asura Strike while wearing Bloody Weapon ( Hydra ) and switched quickly to ( Stormy Knight ) Weapon. The damage inflicted by the Bloody Weapon still take effect and at the same time the Status effect of the ( stormy knight card) takes effect as well ( Frost ) so what happens is, you get the damage from the Bloody and still get frozen after.

Here's my Video: Using Quad Bloody damage around 5k and @ 0:57Using Bloody and switch to Stormy Card damage 5k and get frozen.




http://rathena.org/b...7107#entry17107

The only problem now is "official bahavior of switching weapons are broken. Just like Clowns that cant switch faster from guitar to dagger."

can you elaborate/clarify? I don't understand what you are referring to

Ind 
changed status to: Needs More Info

maybe his referring with the delay?
You can't put this item on.

just like doing a normal attack. on a Barricade without any weapon. while having a continues attack.
try to equip a weapon or just like a knife. then continues attacking. the remove the knife.
then do it again. and you will get this message. You can't put this item on.

i just try it on iRO there is no You can't put this item on. while switching the weapon.

yes confirmed, i even tried to report it again. haha. all my players are complaining about it. because they cannot switch their weapon as fast as they could they always getting the "you cannot put this item" warning.

You can also do this:

Use sniper, normal attack other player then try to switch weapon while the character is attacking, you will get the warning which is not normal.

up, i hope this will be fix as soon as possible because it's an important thing in a PVP Server. ehehehe. thnx

up, i hope this will be fix as soon as possible because it's an important thing in a PVP Server. ehehehe. thnx

do you realize that by not having this fix players are able to do what the video in the first post shows? (attack with damage weapon; switch quickly to a status weapon and have them both work in a single strike), if you understand and agree to that I could give you a diff to remove it (its a very small portion of code anyway)



up, i hope this will be fix as soon as possible because it's an important thing in a PVP Server. ehehehe. thnx

do you realize that by not having this fix players are able to do what the video in the first post shows? (attack with damage weapon; switch quickly to a status weapon and have them both work in a single strike), if you understand and agree to that I could give you a diff to remove it (its a very small portion of code anyway)


oh sure, can you send it to me or post it here sir? just to stop my players from bugging me. thnx

This can only be done on low rate / 99/70 server anyway, so it wont affect us in a no cast server.

Edited by ramzelle100, 22 July 2013 - 09:00 AM.




The only problem now is "official bahavior of switching weapons are broken. Just like Clowns that cant switch faster from guitar to dagger."

can you elaborate/clarify? I don't understand what you are referring to


What I am trying to point out is what bgamez23 is saying.

And i just want to know if in the future is there any way that we can fix this? Thank you :)





The only problem now is "official bahavior of switching weapons are broken. Just like Clowns that cant switch faster from guitar to dagger."

can you elaborate/clarify? I don't understand what you are referring to

What I am trying to point out is what bgamez23 is saying.

And i just want to know if in the future is there any way that we can fix this? Thank you :)


you can fix it on your own.
in your clif.c

look for this
if(!sd->status.inventory[index].identify || sd->delayed_damage != 0) { 
remove the
 || sd->delayed_damage != 0
then recompile.

What I am trying to point out is what bgamez23 is saying.

And i just want to know if in the future is there any way that we can fix this? Thank you :)

What officials do when you try to swap a weapon during calculation? it lets the exploit take place?



What I am trying to point out is what bgamez23 is saying.

And i just want to know if in the future is there any way that we can fix this? Thank you :)

What officials do when you try to swap a weapon during calculation? it lets the exploit take place?


The weapon you are using upon casting the skill is the only effect that should apply. And even you switch your weapon to the end of the cast the effect of the switched weapon will not take effect.

Ind 
changed status to: Started

Ind 
changed status to: Fixed

Thank you kyeme
https://github.com/H...3ff74343cd3ae76

Working perfect! Thank you SIR! /no1










The only problem now is "official bahavior of switching weapons are broken. Just like Clowns that cant switch faster from guitar to dagger."

can you elaborate/clarify? I don't understand what you are referring to




What I am trying to point out is what bgamez23 is saying.

And i just want to know if in the future is there any way that we can fix this? Thank you :)



you can fix it on your own.
in your clif.c

look for this
if(!sd->status.inventory[index].identify || sd->delayed_damage != 0) { 
remove the
 || sd->delayed_damage != 0
then recompile.


any fix update on this? fast switching behavior?

i wanna enable it. like on rathena.

Edited by Shatotech, 02 March 2015 - 03:56 PM.













The only problem now is "official bahavior of switching weapons are broken. Just like Clowns that cant switch faster from guitar to dagger."

can you elaborate/clarify? I don't understand what you are referring to





What I am trying to point out is what bgamez23 is saying.

And i just want to know if in the future is there any way that we can fix this? Thank you :)




you can fix it on your own.
in your clif.c

look for this
if(!sd->status.inventory[index].identify || sd->delayed_damage != 0) { 
remove the
 || sd->delayed_damage != 0
then recompile.

any fix update on this? fast switching behavior?

i wanna enable it. like on rathena.


..............

any fix update on this? fast switching behavior?

i wanna enable it. like on rathena.

you misunderstand it. being able to switch it fast is the bug in question, if you want it to work like that see what my commit linked earlier did, and undo it.


I got a problem in recompiling my server. A bit new in fixing server.


I had a back up of my trunk before i start editing files in my src folder. And I also have the original copy of the files i edited.


I was trying to enable frost switch so i undo everything from this topic. As I recompile, I got those errors and i tried to bring back the original files and yet same errors occurred.
make[1]: Entering directory `/home/trincli0900/trunk/src/map'
        MKDIR   obj
        CC      achievement.c
        CC      atcommand.c
atcommand.c:52:21: error: faction.h: No such file or directory
atcommand.c: In function 'atcommand_mobevent':
atcommand.c:8602: warning: unused variable 'y'
atcommand.c:8602: warning: unused variable 'x'
atcommand.c: In function 'atcommand_faction':
atcommand.c:10791: warning: implicit declaration of function 'faction_search'
atcommand.c:10791: warning: assignment makes pointer from integer without a cast
atcommand.c:10798: error: dereferencing pointer to incomplete type
atcommand.c:10801: error: dereferencing pointer to incomplete type
atcommand.c: In function 'atcommand_language':
atcommand.c:10813: warning: initialization makes pointer from integer without a cast
atcommand.c:10814: error: dereferencing pointer to incomplete type
atcommand.c:10821: error: dereferencing pointer to incomplete type
atcommand.c:10821: warning: implicit declaration of function 'lang_search'
atcommand.c:10821: error: dereferencing pointer to incomplete type
atcommand.c:10823: error: dereferencing pointer to incomplete type
atcommand.c:10824: error: dereferencing pointer to incomplete type
atcommand.c:10836: warning: assignment makes pointer from integer without a cast
atcommand.c:10836: error: dereferencing pointer to incomplete type
atcommand.c:10842: error: 'lang_pow' undeclared (first use in this function)
atcommand.c:10842: error: (Each undeclared identifier is reported only once
atcommand.c:10842: error: for each function it appears in.)
atcommand.c:10844: error: dereferencing pointer to incomplete type
atcommand.c:10850: error: dereferencing pointer to incomplete type
atcommand.c: In function 'atcommand_learnlang':
atcommand.c:10860: warning: assignment makes pointer from integer without a cast
atcommand.c:10866: error: 'lang_pow' undeclared (first use in this function)
atcommand.c:10868: error: dereferencing pointer to incomplete type
atcommand.c:10875: error: dereferencing pointer to incomplete type
atcommand.c: In function 'atcommand_unlearnlang':
atcommand.c:10885: warning: assignment makes pointer from integer without a cast
atcommand.c:10891: error: 'lang_pow' undeclared (first use in this function)
atcommand.c:10894: error: dereferencing pointer to incomplete type
atcommand.c:10899: error: dereferencing pointer to incomplete type
atcommand.c: In function 'atcommand_say':
atcommand.c:10913: warning: implicit declaration of function 'lang_convert'
make[1]: *** [obj/atcommand.o] Error 1
make[1]: Leaving directory `/home/trincli0900/trunk/src/map'
make: *** [map] Error 2


Unfortunately this line does not exist anymore:
if(!sd->status.inventory[index].identify || sd->delayed_damage != 0) {
I tried to disable this feature by removing:
pc->update_idle_time(sd, BCIDLE_USEITEM);
from clif_parse_EquipItem and clif_parse_UnequipItem, but that didn't work. Can someone provide me the code i have to change to disable it?

Thanks in advance!
-simh

What part in src folder to edit to enable the player to switch weapon to frost and take effect?