Jump to content

  •  

Bug Tracker Migration

June 3rd
Good news everyone! The staff has decided that it is time to slowly kill off this Bug Tracker. We will begin the process of slowly migrating from this Bug Tracker over to our Github Issues which can be found here: https://github.com/HerculesWS/Hercules/issues

Over the next couple of days, I will be closing off any opportunity to create new reports. However, I still will keep the opportunity to reply to existing Bug Reports. Doing this will allow us to slowly fix any bug reports we have listed here so that we can easily migrate over to our Issue Tracker.

Update - June 7th 2015: Creating new bug posts has been disabled. Please use our https://github.com/HerculesWS/Hercules/issues tracker to post bugs. Users are still able to reply to existing bug posts.

- Administration

Issue Information

  • #007338

  • 1 - Low

  • Fixed

Issue Confirmations

  • Yes (3)No (0)
Photo

Deleting Character

Posted by kyeme on 10 June 2013 - 01:30 AM

Official:
You cant delete your char while you are in a guild or party
msgstringtable.txt line 1819 and 1820
Please leave your guild first in order to remove your character.#
Please leave your party first in order to remove your character.#

Source pRO Sakray:

When was this feature implemented?

Sorry, I dont have any information..  :(

Edited by kyeme, 10 June 2013 - 09:12 AM.


I thought once you delete the character, the server removes them from the SQL tables? o_O

i can confirm this. should leave guild or party before deleting character.

@Mysterious
Yes, it does, but well it is a feature (useless IMO).

#define USE_OFFICIAL_DELETE_CHARACTER //This feature is useles

Use a define maybe a good idea to implement this if is necessary.

Ind 
changed status to: Confirmed

// packet: 0x828
// len: 14
struct PACKET_HC_DELETE_CHAR3_RESERVED {
  /* this+0x0 */ short PacketType
  /* this+0x2 */ unsigned long GID
  /* this+0x6 */ int Result
  /*
    RESULT_FAIL_UNKNOWN =  0x0,
    RESULT_SUCCESS =  0x1,
    RESULT_FAIL_CONFIGURATION =  0x2,
    RESULT_FAIL_DATABASE =  0x3,
    RESULT_FAIL_GUILD =  0x4,
    RESULT_FAIL_PARTY =  0x5
  */
  /* this+0xa */ long DeleteReservedDate
}
I guess its this

^(special thanks to kLabMouse/Yommy)

Ind 
changed severity to: 1 - Low

I think they do this because upon deletiong they dont clear their data properly, we do however so its a pretty cosmetic/pointless requirement -- adds overhead to the user. I'm flagging it as low priority.

#define USE_OFFICIAL_DELETE_CHARACTER //This feature is useles

Use a define maybe a good idea to implement this if is necessary.

I personally think a char-server.conf setting would be best here

Added feature in https://github.com/H...098fef6377dddc0
I added a char-server.conf setting to activate this behavior:
+// Block deletion if character is inside a guild or a party? (BOOL)
 +// default: 0	official: 1
 +// !!This check is imposed by Aegis to avoid dead entries in databases and _is_not_needed_ as we clear data properly!!
 +char_aegis_delete: 0
Just change it to 1 and it will work just like Aegis does.

pan 
changed status to: Fixed