Jump to content

  •  
  • Wiki
  • GIT
  • IRC
  • + Others

Bug Tracker Migration

June 3rd
Good news everyone! The staff has decided that it is time to slowly kill off this Bug Tracker. We will begin the process of slowly migrating from this Bug Tracker over to our Github Issues which can be found here: https://github.com/HerculesWS/Hercules/issues

Over the next couple of days, I will be closing off any opportunity to create new reports. However, I still will keep the opportunity to reply to existing Bug Reports. Doing this will allow us to slowly fix any bug reports we have listed here so that we can easily migrate over to our Issue Tracker.

Update - June 7th 2015: Creating new bug posts has been disabled. Please use our https://github.com/HerculesWS/Hercules/issues tracker to post bugs. Users are still able to reply to existing bug posts.

- Administration

Issue Information

  • #007340

  • 0 - None Assigned

  • Needs More Info

Issue Confirmations

  • Yes (0)No (0)
Photo

booking system doesn't work anymore on 2012-04-10aRagexe and 2012-04-17aRagexe

Posted by bgamez23 on 11 June 2013 - 05:00 PM

before this features is working correctly. but after this update.
4a51fc7e5eec9a464c754d3d1e0ee44da1ca6f72

i'm not sure what revision is that since we don't use revision on git.

i revert back on what changes on that revision.. and it works again.

Posted Image


Zopokx
PipPipPip
Jun 11 2013 07:23 PM
Using 04-18 and it works, but sometimes it crashes. I think It was when searching for a 'lvl 0' party :P


mkbu95

Jun 11 2013 09:03 PM
Dammit. Well, what the hell happened with that new interface bgamez showed.


ossi0110

Jun 11 2013 09:59 PM
my Interface looks different to lol

im using 2012-04-10 RagexeRE

Posted Image

Edited by ossi0110, 11 June 2013 - 10:04 PM.



bgamez23

Jun 12 2013 02:36 AM

Dammit. Well, what the hell happened with that new interface bgamez showed.

they used diff UI. if you are using Ragexe. this interface will appear. but if you use RagexeRE the UI interface is with the old interface.


bgamez23

Jun 12 2013 02:39 AM

my Interface looks different to lol

im using 2012-04-10 RagexeRE

Posted Image


its because your using RagexeRE. but on Ragexe the UI is totally different.

Edited by bgamez23, 12 June 2013 - 02:39 AM.



mkbu95

Jun 12 2013 10:37 AM
Depending on the differ you have different Party Booking UIs. Well, guess I am going to set a config for this then since there is no way of knowing which version you have.


bgamez23

Jun 12 2013 01:07 PM

Depending on the differ you have different Party Booking UIs. Well, guess I am going to set a config for this then since there is no way of knowing which version you have.

i think it should be define #ifndef PACKETVER_RE. since your previous update was for RagexeRe only. and by the default the booking system was already working on Ragexe by updating the packet.


mkbu95

Jun 13 2013 12:55 AM
ossi0110 is using 2012-04-10aRagexeRE and has this "new" interface.
Your hexed that I used for testing was 2012-04-10aRagexe (not RE) and it has the "new" interface.

What is this diff that changes the UI?
I might put up a config for it instead of auto-detecting.


bgamez23

Jun 13 2013 04:33 AM
for 2012-04-10aRagexe and above they used new interface. for 2012-04-10aRagexeRE they used the old interface which has a blocklist.

Ind 
changed status to: New


Ind
Jun 13 2013 04:35 AM

ossi0110 is using 2012-04-10aRagexeRE and has this "new" interface.
Your hexed that I used for testing was 2012-04-10aRagexe (not RE) and it has the "new" interface.

What is this diff that changes the UI?
I might put up a config for it instead of auto-detecting.

Wouldnt the mmo.h
// Comment the following line if your client is NOT ragexeRE (required because of conflicting packets in ragexe vs ragexeRE).
#define PACKETVER_RE
fix this? (if used in the const.h party_recruit thing)? -- I'm not sure, asking


bgamez23

Jun 13 2013 04:38 AM



ossi0110 is using 2012-04-10aRagexeRE and has this "new" interface.
Your hexed that I used for testing was 2012-04-10aRagexe (not RE) and it has the "new" interface.

What is this diff that changes the UI?
I might put up a config for it instead of auto-detecting.

Wouldnt the mmo.h
// Comment the following line if your client is NOT ragexeRE (required because of conflicting packets in ragexe vs ragexeRE).
#define PACKETVER_RE
fix this? (if used in the const.h party_recruit thing)? -- I'm not sure, asking


still not working even i comment to disable the PACKETVER_RE.

since the previous update doesn't check if the settings is using PACKETVER_RE or not. that's why we having an issue regarding on the booking system. because it only works now on RagexeRE but on Ragexe its not totally working now :(


Ind
Jun 13 2013 04:44 AM




ossi0110 is using 2012-04-10aRagexeRE and has this "new" interface.
Your hexed that I used for testing was 2012-04-10aRagexe (not RE) and it has the "new" interface.

What is this diff that changes the UI?
I might put up a config for it instead of auto-detecting.

Wouldnt the mmo.h
// Comment the following line if your client is NOT ragexeRE (required because of conflicting packets in ragexe vs ragexeRE).
#define PACKETVER_RE
fix this? (if used in the const.h party_recruit thing)? -- I'm not sure, asking

still not working even i comment to disable the PACKETVER_RE.

since the previous update doesn't check if the settings is using PACKETVER_RE or not. that's why we having an issue regarding on the booking system. because it only works now on RagexeRE but on Ragexe its not totally working now :(

I didnt say it was working (I was asking if using that var in the check -- because its not currently used -- would fix it)


bgamez23

Jun 13 2013 04:50 AM
oh i see.it was disable since i'm using Ragexe.


mkbu95

Jun 13 2013 03:43 PM
bgamez, can you try this?

go to src/config/const.h then find this:
#if (PACKETVER == 20120410) || (PACKETVER == 20120418)
	#define	PARTY_RECRUIT
#endif
change it to:
#ifdef PACKETVER_RE
#if (PACKETVER == 20120410) || (PACKETVER == 20120418)
	#define	PARTY_RECRUIT
#endif
#endif
and then recompile

i can't test right now


bgamez23

Jun 13 2013 05:01 PM

bgamez, can you try this?

go to src/config/const.h then find this:

#if (PACKETVER == 20120410) || (PACKETVER == 20120418) #define PARTY_RECRUIT#endif
change it to:
#ifdef PACKETVER_RE#if (PACKETVER == 20120410) || (PACKETVER == 20120418) #define PARTY_RECRUIT#endif#endif
and then recompile

i can't test right now


thanks it works now. but you should define PACKETVER_RE on your packets.h to make it usable again.
//2012-04-10aRagexeRE and 2012-04-10aRagexe
#if PACKETVER >= 20120410
	packet(0x094B,19,clif->pWantToConnection,2,6,10,14,18);
	packet(0x0437,5,clif->pWalkToXY,2);
	packet(0x0886,6,clif->pTickSend,2);
	packet(0x0871,5,clif->pChangeDir,2,4);
	packet(0x0938,6,clif->pTakeItem,2);
	packet(0x0891,6,clif->pDropItem,2,4);
	packet(0x086C,8,clif->pMoveToKafra,2,4);
	packet(0x08A6,8,clif->pMoveFromKafra,2,4);
	packet(0x0438,10,clif->pUseSkillToPos,2,4,6,8);
	packet(0x091D,18,clif->pPartyBookingRegisterReq,2,4,6);
	packet(0x0366,90,clif->pUseSkillToPosMoreInfo,2,4,6,8,10);
	packet(0x0889,6,clif->pGetCharNameRequest,2);
	packet(0x0884,6,clif->pSolveCharName,2);
	packet(0x089C,26,clif->pFriendsListAdd,2);
	packet(0x0885,5,clif->pHomMenu,2,4);
	packet(0x0961,36,clif->pStoragePassword,0);
	packet(0x091C,26,clif->pPartyInvite2,2);
	packet(0x0369,7,clif->pActionRequest,2,6);
	packet(0x083C,10,clif->pUseSkillToId,2,4,6);
	packet(0x0945,-1,clif->pItemListWindowSelected,2,4,8);
	packet(0x08E5,41,clif->pPartyBookingRegisterReq,2,4);
	packet(0x0815,-1,clif->pReqOpenBuyingStore,2,4,8,9,89);
	packet(0x0817,2,clif->pReqCloseBuyingStore,0);
	packet(0x0360,6,clif->pReqClickBuyingStore,2);
	packet(0x0811,-1,clif->pReqTradeBuyingStore,2,4,8,12);
	packet(0x0819,-1,clif->pSearchStoreInfo,2,4,5,9,13,14,15);
	packet(0x0835,2,clif->pSearchStoreInfoNextPage,0);
	packet(0x0838,12,clif->pSearchStoreInfoListItemClick,2,6,10);
	packet(0x0439,8,clif->pUseItem,2,4);
	#ifdef PACKETVER_RE
	packet(0x01FD,15,clif->pRepairItem,2);
	packet(0x089C,26,clif->pFriendsListAdd,2);
	packet(0x0885,5,clif->pHomMenu,2,4);
	packet(0x0961,36,clif->pStoragePassword,0);
	packet(0x0288,-1,clif->pcashshop_buy,4,8);
	packet(0x091C,26,clif->pPartyInvite2,2);
	packet(0x094B,19,clif->pWantToConnection,2,6,10,14,18);
	packet(0x0369,7,clif->pActionRequest,2,6);
	packet(0x083C,10,clif->pUseSkillToId,2,4,6);
	packet(0x0439,8,clif->pUseItem,2,4);
	packet(0x0945,-1,clif->pItemListWindowSelected,2,4,8);
	packet(0x0815,-1,clif->pReqOpenBuyingStore,2,4,8,9,89);
	packet(0x0817,2,clif->pReqCloseBuyingStore,0);
	packet(0x0360,6,clif->pReqClickBuyingStore,2);
	packet(0x0811,-1,clif->pReqTradeBuyingStore,2,4,8,12);
	packet(0x0819,-1,clif->pSearchStoreInfo,2,4,5,9,13,14,15);
	packet(0x0835,2,clif->pSearchStoreInfoNextPage,0);
	packet(0x0838,12,clif->pSearchStoreInfoListItemClick,2,6,10);
	packet(0x0437,5,clif->pWalkToXY,2);
	packet(0x0886,6,clif->pTickSend,2);
	packet(0x0871,5,clif->pChangeDir,2,4);
	packet(0x0938,6,clif->pTakeItem,2);
	packet(0x0891,6,clif->pDropItem,2,4);
	packet(0x086C,8,clif->pMoveToKafra,2,4);
	packet(0x08A6,8,clif->pMoveFromKafra,2,4);
	packet(0x0438,10,clif->pUseSkillToPos,2,4,6,8);
	packet(0x0366,90,clif->pUseSkillToPosMoreInfo,2,4,6,8,10);
	packet(0x0889,6,clif->pGetCharNameRequest,2);
	packet(0x0884,6,clif->pSolveCharName,2);
	packet(0x08E5,41,clif->pPartyBookingRegisterReq,2,4);
	packet(0x08E6,4);
	packet(0x08E7,10,clif->pPartyBookingSearchReq,2);
	packet(0x08E8,-1);
	packet(0x08E9,2,clif->pPartyBookingDeleteReq,2);
	packet(0x08EA,4);
	packet(0x08EB,39,clif->pPartyBookingUpdateReq,2);
	packet(0x08EC,73);
	packet(0x08ED,43);
	packet(0x08EE,6);
#ifdef PARTY_RECRUIT
	packet(0x08EF,6,clif->pDull,2); //bookingignorereq
	packet(0x08F0,6,clif->pDull,2);
	packet(0x08F1,6,clif->pDull,2); //bookingjoinpartyreq
#endif
	packet(0x08F2,36);
	packet(0x08F3,-1);
	packet(0x08F4,6);
	packet(0x08F5,-1,clif->pDull,2,4); //bookingsummonmember
	packet(0x08F6,22);
	packet(0x08F7,3);
	packet(0x08F8,7);
	packet(0x08F9,6);
#ifdef PARTY_RECRUIT
	packet(0x08F9,6,clif->pDull,2);
#endif
	packet(0x08FA,6);
	packet(0x08FB,6,clif->pDull,2); //bookingcanceljoinparty
	packet(0x0907,5,clif->pMoveItem,2,4);
	packet(0x0908,5);
	packet(0x08CF,10);//Amulet spirits
	packet(0x0977,14);//Monster HP Bar
	#endif

Edited by bgamez23, 13 June 2013 - 05:09 PM.



bgamez23

Jun 13 2013 05:20 PM
2012-04-10aRagexeRE UIPosted Image

2012-04-10aRagexePosted Image

@mkbu95 can you correct a minor typo on packet.h?

the #ifndef PACKETVER_RE to #ifdef PACKETVER_RE

line 1897 thanks

Edited by bgamez23, 13 June 2013 - 05:22 PM.



Ind
Jun 13 2013 05:27 PM

@mkbu95 can you correct a minor typo on packet.h?

the #ifndef PACKETVER_RE to #ifdef PACKETVER_RE

line 1897 thanks

that is not a typo, the packets in that #ifndef packet is for ragexe (not ragexeRE).


bgamez23

Jun 13 2013 06:56 PM



@mkbu95 can you correct a minor typo on packet.h?

the #ifndef PACKETVER_RE to #ifdef PACKETVER_RE

line 1897 thanks

that is not a typo, the packets in that #ifndef packet is for ragexe (not ragexeRE).


i tried to use it. if i use #ifndef it will not work. just an example on this.

Spoiler


feel free to test it.

Edited by bgamez23, 13 June 2013 - 06:56 PM.



mkbu95

Jun 14 2013 04:01 AM
Well, I committed something. Does it work now?


bgamez23

Jun 14 2013 04:13 AM

Well, I committed something. Does it work now?

yup it works now. but make sure to fix the typo on packet.h and use the #ifdef PACKETVER_RE for your packets to make it sure that he check which packetver he will use. and i also have a screenshots. proof that it is already working.


Back to Core


  1. Bug Tracker
  2. → Core
  3. → Status: Needs More Info
  4. Privacy Policy
  5. Hercules Forum Rules ·