Issue Information
-
#007471
-
4 - High
-
Fixed
Issue Confirmations
-
Yes (4)No (0)
1
hi there!
i'm facing 2 issues here upon updating (note that my last pull was last tuesday)
1. The message that used to show you require to use 50 for the 1st job is missing.
2. It seems that upon reset, you're able to immediately add your skills to 3rd job page without going through 1st and second.
Please confirm thanks!
i'm facing 2 issues here upon updating (note that my last pull was last tuesday)
1. The message that used to show you require to use 50 for the 1st job is missing.
2. It seems that upon reset, you're able to immediately add your skills to 3rd job page without going through 1st and second.
Please confirm thanks!
Still have an issue, specifically with the Rune Knight skills.
A Job level 27 Rune Knight, who changed at job 50 to Lord Knight, and job 70 to Rune Knight, should have 26 skill points once arriving to the third class skill tree. Implementing the fix above by malufett prevents players from putting points directly into third job after only putting 1-2 points into second job, however, it now states that three more skill points than should be required, must go into the trans skill tree for Rune Knight. Haven't run into this issue again on other third jobs yet, but I've not done extensive testing.
A Job level 27 Rune Knight, who changed at job 50 to Lord Knight, and job 70 to Rune Knight, should have 26 skill points once arriving to the third class skill tree. Implementing the fix above by malufett prevents players from putting points directly into third job after only putting 1-2 points into second job, however, it now states that three more skill points than should be required, must go into the trans skill tree for Rune Knight. Haven't run into this issue again on other third jobs yet, but I've not done extensive testing.
SS please for its base, trans and 3rd..or what is its total skill point after reset..cause I can't reproduce your situation..Still have an issue, specifically with the Rune Knight skills.
A Job level 27 Rune Knight, who changed at job 50 to Lord Knight, and job 70 to Rune Knight, should have 26 skill points once arriving to the third class skill tree. Implementing the fix above by malufett prevents players from putting points directly into third job after only putting 1-2 points into second job, however, it now states that three more skill points than should be required, must go into the trans skill tree for Rune Knight. Haven't run into this issue again on other third jobs yet, but I've not done extensive testing.
Has the fix been committed yet?
After applying your code @ malufett, here are just a few of the support tickets I've received since:
Hello,after this reset,my Mechanic get an bug with skill tree.My problem until now is with skill Cart Boost.I use it and appear message about thor seed, i think some error with skill tree of Genetic. I use npc reset and reput the skills,and use Cart Boost,but same thing.
hi. with the recent maintenance, my skills were forced reset. i know it was part of the maintenance for the skill allocation bug. but now there\'s a new problem. i put skills on my RK and now my RK got maxed out 3rd job skills. i think you can jump to then next skill tree w/o using all of the previous skill points. im not sure.
I noticed that all players were given a free skill reset, after the 3rd job skill allocation bug was apparently fixed. But it doesn\'t seem to be fixed completely.
My RK has 3 points in Increase HP Recovery even after the reset, and my Warlock has 3 points in Increase SP Recovery. And I can\'t add further points to those skills, it gives the \"Please allocate \'x\' skill points in the 1st tab\" error.
I noticed I was wearing Swordsman and Mage Essence Halloween clips on those characters when they were reset, and thought that\'s what was causing it. So I took all my equips off on both characters, and they still show 3 points invested in those skills. Even after a clean reset, with all my equips off, it shows 3 points invested in the aforementioned skills.
In conclusion, it\'s possible that the Halloween clips may be clashing with skills and causing this bug.
Another thing is, on reset, technically we should get 49+69+49 = 167 points, but we\'re only getting 166.
Thanks for the efforts you\'re putting into resolving this. I hope the information I have provided is of some use.
An addition to this is, many players are experiencing different errors with skills. A ranger had trouble with Attention Concentrate, but it was fixed for him by taking off the equips, then adding skills. It did not work for me. Another Warlock could start adding skills in 3rd job tree directly, without having to go through 1st and 2nd jobs.
After the forced skill reset today, as I was pointing the skill points back on my AB (Enlighten) I noticed that the skill points are a bit more permissice now than should be. I was working off a skill simulator and didn\'t notice I forgot to put points into some 1st job skills; yet the skill window allowed me to put points into 2nd job skills already. I didn\' put 3rd skills yet at that point, so not sure if you could abuse this to devote more points towards third job skills.
For reference, after I figured this out I made sure to put the missed points into 1st jobs as should be and did not abuse it to put more points into 2nd job skills. But the potential for intentional or unintentional abuse is there, so I thought I would notify you about this.
As seen on the character \"Distraught\" on this account, I was able to put 2nd class skill points after a mere 30 into 1st job.
Hello,after this reset,my Mechanic get an bug with skill tree.My problem until now is with skill Cart Boost.I use it and appear message about thor seed, i think some error with skill tree of Genetic. I use npc reset and reput the skills,and use Cart Boost,but same thing.
hi. with the recent maintenance, my skills were forced reset. i know it was part of the maintenance for the skill allocation bug. but now there\'s a new problem. i put skills on my RK and now my RK got maxed out 3rd job skills. i think you can jump to then next skill tree w/o using all of the previous skill points. im not sure.
I noticed that all players were given a free skill reset, after the 3rd job skill allocation bug was apparently fixed. But it doesn\'t seem to be fixed completely.
My RK has 3 points in Increase HP Recovery even after the reset, and my Warlock has 3 points in Increase SP Recovery. And I can\'t add further points to those skills, it gives the \"Please allocate \'x\' skill points in the 1st tab\" error.
I noticed I was wearing Swordsman and Mage Essence Halloween clips on those characters when they were reset, and thought that\'s what was causing it. So I took all my equips off on both characters, and they still show 3 points invested in those skills. Even after a clean reset, with all my equips off, it shows 3 points invested in the aforementioned skills.
In conclusion, it\'s possible that the Halloween clips may be clashing with skills and causing this bug.
Another thing is, on reset, technically we should get 49+69+49 = 167 points, but we\'re only getting 166.
Thanks for the efforts you\'re putting into resolving this. I hope the information I have provided is of some use.
An addition to this is, many players are experiencing different errors with skills. A ranger had trouble with Attention Concentrate, but it was fixed for him by taking off the equips, then adding skills. It did not work for me. Another Warlock could start adding skills in 3rd job tree directly, without having to go through 1st and 2nd jobs.
After the forced skill reset today, as I was pointing the skill points back on my AB (Enlighten) I noticed that the skill points are a bit more permissice now than should be. I was working off a skill simulator and didn\'t notice I forgot to put points into some 1st job skills; yet the skill window allowed me to put points into 2nd job skills already. I didn\' put 3rd skills yet at that point, so not sure if you could abuse this to devote more points towards third job skills.
For reference, after I figured this out I made sure to put the missed points into 1st jobs as should be and did not abuse it to put more points into 2nd job skills. But the potential for intentional or unintentional abuse is there, so I thought I would notify you about this.
As seen on the character \"Distraught\" on this account, I was able to put 2nd class skill points after a mere 30 into 1st job.
its just a problem in your msgstringtable..My problem until now is with skill Cart Boost.I use it and appear message about thor seed
may I know the script on the clips?...
and can you do this..only test this in your test server so that you can execute this easier..
@pc.c
int pc_calc_skilltree(struct map_session_data *sd)
{
int i,id=0,flag;
int c=0;
nullpo_ret(sd);
i = pc->calc_skilltree_normalize_job(sd);
c = pc->mapid2jobid(i, sd->status.sex);
+ShowWarning("Only skill tree of %d is now ok for skill upgrade.\n", c);
and after compiling now do this step:1. Create character or pick one character that has a problem
2. Reset skill
3. Monitor the emu screen and check the result if match
eg. I'm 3rd RK and after skill reset you should see
[Warning]: Only skill tree of 4002 is now ok for skill upgrade.and if you accomplished the first job it should show
[Warning]: Only skill tree of 4008 is now ok for skill upgrade.
if doesn't match tell me so we can run another set of test...
I found the problem, working on it, lies on pc_calc_skillpoint (good news the problem can self-fix since this is recalculated everytime, once the algorithm is adjusted), its counting guild skills towards, e.g.its just a problem in your msgstringtable..
My problem until now is with skill Cart Boost.I use it and appear message about thor seed
may I know the script on the clips?...
and can you do this..only test this in your test server so that you can execute this easier..
@pc.cint pc_calc_skilltree(struct map_session_data *sd) { int i,id=0,flag; int c=0; nullpo_ret(sd); i = pc->calc_skilltree_normalize_job(sd); c = pc->mapid2jobid(i, sd->status.sex); +ShowWarning("Only skill tree of %d is now ok for skill upgrade.\n", c);and after compiling now do this step:
1. Create character or pick one character that has a problem
2. Reset skill
3. Monitor the emu screen and check the result if match
eg. I'm 3rd RK and after skill reset you should see[Warning]: Only skill tree of 4002 is now ok for skill upgrade.and if you accomplished the first job it should show[Warning]: Only skill tree of 4008 is now ok for skill upgrade.if doesn't match tell me so we can run another set of test...
[Debug]: pc_calc_skillpoint: Started [Debug]: pc_calc_skillpoint: 9 for NV_BASIC [Debug]: pc_calc_skillpoint: 1 for HT_SKIDTRAP [Debug]: pc_calc_skillpoint: 1 for HT_LANDMINE [Debug]: pc_calc_skillpoint: 1 for HT_ANKLESNARE [Debug]: pc_calc_skillpoint: 1 for HT_SHOCKWAVE [Debug]: pc_calc_skillpoint: 1 for HT_SANDMAN [Debug]: pc_calc_skillpoint: 1 for HT_FLASHER [Debug]: pc_calc_skillpoint: 1 for HT_FREEZINGTRAP [Debug]: pc_calc_skillpoint: 1 for HT_BLASTMINE [Debug]: pc_calc_skillpoint: 1 for HT_CLAYMORETRAP [Debug]: pc_calc_skillpoint: 1 for HT_REMOVETRAP [Debug]: pc_calc_skillpoint: 1 for GD_APPROVAL [Debug]: pc_calc_skillpoint: 1 for GD_KAFRACONTRACT [Debug]: pc_calc_skillpoint: 1 for GD_GUARDRESEARCH [Debug]: pc_calc_skillpoint: 3 for GD_GUARDUP [Debug]: pc_calc_skillpoint: 10 for GD_EXTENSION [Debug]: pc_calc_skillpoint: 5 for GD_LEADERSHIP [Debug]: pc_calc_skillpoint: 5 for GD_GLORYWOUNDS [Debug]: pc_calc_skillpoint: 5 for GD_SOULCOLD [Debug]: pc_calc_skillpoint: 5 for GD_HAWKEYES [Debug]: pc_calc_skillpoint: 1 for GD_BATTLEORDER [Debug]: pc_calc_skillpoint: 3 for GD_REGENERATION [Debug]: pc_calc_skillpoint: 1 for GD_RESTORE [Debug]: pc_calc_skillpoint: 1 for GD_EMERGENCYCALL [Debug]: pc_calc_skillpoint: 1 for GD_DEVELOPMENT [Debug]: pc_calc_skillpoint: 1 for RA_RESEARCHTRAP [Debug]: pc_calc_skillpoint: 1 for RA_VERDURETRAP [Debug]: pc_calc_skillpoint: returning 64
Fixed in https://github.com/H...c9cc9af08f36724
Thank you all for all your help and information. If there are any new issures regarding this please create a new bug report, this one is 3 pages long and a mess.
Thank you again
Thank you all for all your help and information. If there are any new issures regarding this please create a new bug report, this one is 3 pages long and a mess.
Thank you again
Hello This issue resolve?
Hello This issue resolve?
It's been fixed quite sometime already.
this issue fix?
