Jump to content

  •  

Bug Tracker Migration

June 3rd
Good news everyone! The staff has decided that it is time to slowly kill off this Bug Tracker. We will begin the process of slowly migrating from this Bug Tracker over to our Github Issues which can be found here: https://github.com/HerculesWS/Hercules/issues

Over the next couple of days, I will be closing off any opportunity to create new reports. However, I still will keep the opportunity to reply to existing Bug Reports. Doing this will allow us to slowly fix any bug reports we have listed here so that we can easily migrate over to our Issue Tracker.

Update - June 7th 2015: Creating new bug posts has been disabled. Please use our https://github.com/HerculesWS/Hercules/issues tracker to post bugs. Users are still able to reply to existing bug posts.

- Administration

Issue Information

  • #007484

  • 0 - None Assigned

  • Fixed

Issue Confirmations

  • Yes (3)No (2)
Photo

Cart Problem

Posted by mofo on 06 July 2013 - 05:00 AM

Can't put items in cart, items previously in the cart disappear, can't remove cart, when using the skill "Change Cart" it says... any work in progress (NPC dialog, manufacturing...) quit and try again. There were no problems 2 days ago. I updated my working copy this morning to the latest version. I don't have source edits as well.

unable to produce the bug.
Posted ImagePosted ImagePosted ImagePosted Image

also for cart changing.
Posted ImagePosted Image

weird, it only started when i updated this morning. it was fine before that. maybe git ignored a file because it had minor edits? i guess i'll just try with a clean copy and see what happens.

Can't put items in cart, items previously in the cart disappear, can't remove cart

I can confirm this
bgamez what is your rev?

Oh, so kyeme you have the same problem? I can't figure out which commit gave me this issue, but I'm on the latest revision.

Confirming This on PRE -RE Mode

my Testserver running Latest Rev and got this bug

my Live Server runs on a commit from 06-28-2013 (Git Hash 7c479ad6027ccbce605ebb49c5e8900037772dd5 ) and dont got this bug

Fixed @ cf56f7c9142ae164d4e093807f1e7def3471afbd
:meow:

changed status to: Fixed

yeah, not fixed im still cannot change my cart using whitesmith character.

yeah, not fixed im still cannot change my cart using whitesmith character.

Try this http://herc.ws/board...rt-client-2013/

changed status to: New

ah I thought this is the problem

Can't put items in cart, items previously in the cart disappear, can't remove cart, when using the skill "Change Cart" it says... any work in progress (NPC dialog, manufacturing...) quit and try again.


anyway let me check further..

ah..due to this https://github.com/H...4cad38d66464ac4
:meow:

why i can't produce this bug?
Spoiler


also working on whitesmith class and blacksmith. maybe it depends on client version that we use?
Spoiler


@brynner
This is the prob @latest rev:

Can't put items in cart, items previously in the cart disappear, can't remove cart



@brynner
This is the prob @latest rev:



Can't put items in cart, items previously in the cart disappear, can't remove cart


i'm using the latest revision on my test server.
Git Hash: 'cf56f7c9142ae164d4e093807f1e7def3471afbd'
see screenshots #6.

It could also be a client-packet issue, but I don't see any recent commits that changes any files related to them. And the carts were working fine before my last update so the issue lies within the recent commits. I just updated this morning and Change Cart no longer gives me the odd message " any work in progress (NPC dialog, manufacturing...) quit and try again". But I still can't put items in the cart or change the way it looks. I think malufett is double checking it though, so I'll just wait for that.

edit: using 20120716 ragexe

Edited by mofo, 07 July 2013 - 11:36 PM.


It could also be a client-packet issue, but I don't see any recent commits that changes any files related to them. And the carts were working fine before my last update so the issue lies within the recent commits. I just updated this morning and Change Cart no longer gives me the odd message " any work in progress (NPC dialog, manufacturing...) quit and try again". But I still can't put items in the cart or change the way it looks. I think malufett is double checking it though, so I'll just wait for that.

edit: using 20120716 ragexe

Try this (from rathena fix)
trunk/src/common/socket.c

#include "../common/showmsg.h"
#include "../common/strlib.h"
+ #include "../config/core.h"

trunk/src/common/socket.h

#include "../common/cbasetypes.h"
- #include "../config/core.h"