Issue Information
-
#007605
-
0 - None Assigned
-
Fixed
Issue Confirmations
-
Yes (0)No (0)
1
I found an issue where client versions from around 20091013 and earlier have errors compiling on windows.
The errors appear in clif.c, I'm not sure what causes them
Error 1 error C2039: 'objecttype' : is not a member of 'packet_idle_unit' d:\ragnarok\subversions\hercules\hercules\src\map\clif.c 928 1 map-server
Error 2 error C2039: 'objecttype' : is not a member of 'packet_spawn_unit' d:\ragnarok\subversions\hercules\hercules\src\map\clif.c 1168 1 map-server
Error 3 error C2039: 'objecttype' : is not a member of 'packet_unit_walking' d:\ragnarok\subversions\hercules\hercules\src\map\clif.c 1245 1 map-server
This probably isnt a very common issue, but someone I know wants to use a really old client and I'm giving them a hand with it.
The errors appear in clif.c, I'm not sure what causes them
Error 1 error C2039: 'objecttype' : is not a member of 'packet_idle_unit' d:\ragnarok\subversions\hercules\hercules\src\map\clif.c 928 1 map-server
Error 2 error C2039: 'objecttype' : is not a member of 'packet_spawn_unit' d:\ragnarok\subversions\hercules\hercules\src\map\clif.c 1168 1 map-server
Error 3 error C2039: 'objecttype' : is not a member of 'packet_unit_walking' d:\ragnarok\subversions\hercules\hercules\src\map\clif.c 1245 1 map-server
This probably isnt a very common issue, but someone I know wants to use a really old client and I'm giving them a hand with it.
Confirmed, the issue will happen with any PACKETVER between 20071106 and 20091103 because an inconsistency between clif.c and packets_struct.h (but I'm not sure which is the correct one)
Thanks for being so quick! Not sure it is fixed. NPCs don't seem to be showing up. It may not be related though. I'm also getting some weird elastic banding.
More info, there are no packet errors showing up on the map server window, Warp portals work but don't show up, so I think it's just an issue with the packet that shows npcs.
I think the elastic banding is worse where there are supposed to be NPCs on screen. The specific client date I'm using is 20091013.
I've done some more searching, mobs seem to cause client errors.
Also, I have found one npc sprite that's actually poping up near the centre of Prontera.
More info, there are no packet errors showing up on the map server window, Warp portals work but don't show up, so I think it's just an issue with the packet that shows npcs.
I think the elastic banding is worse where there are supposed to be NPCs on screen. The specific client date I'm using is 20091013.
I've done some more searching, mobs seem to cause client errors.
Also, I have found one npc sprite that's actually poping up near the centre of Prontera.
Edited by Lassander, 01 August 2013 - 05:14 AM.
can you send me your exe so I can further debug with it? (I don't have a working client that old)
Sure thing I was going to ask, I'll also send you the xray files since yes it's that old. It's around the time xray shut down so I think that's why they wanted to use this client.
http://www.mediafire...nt-required.zip
http://www.mediafire...nt-required.zip
I've made and tested a fix for it but I'm unable to commit right now, its here: 
7605-Fix.patch 5.23K
5 downloads hopefully another dev can commit it in my place
7605-Fix.patch 5.23K
5 downloads hopefully another dev can commit it in my place
Thanks! the patch seems to be working for me for now. Walking around a field seems to give me no end of gravity errors though. Not really sure what causes it. I've tested the client on eAthena and everything worked, so I'm assuming it's another packet issue. There is also an issue with gender confusion.
Edited by Lassander, 03 August 2013 - 03:30 AM.
ooh I have an idea on what it could be, I'll run some tests
there is something i'd like to confirm to know whether I'm doing a faithful reproduction, your src/common/mmo.h is #packetver is set as 20091013 ?
That is correct. The multiple characters thing might have been something else. I wasn't the one to run that test my friend was and she's not sure what she did.
