Jump to content

  •  

Bug Tracker Migration

June 3rd
Good news everyone! The staff has decided that it is time to slowly kill off this Bug Tracker. We will begin the process of slowly migrating from this Bug Tracker over to our Github Issues which can be found here: https://github.com/HerculesWS/Hercules/issues

Over the next couple of days, I will be closing off any opportunity to create new reports. However, I still will keep the opportunity to reply to existing Bug Reports. Doing this will allow us to slowly fix any bug reports we have listed here so that we can easily migrate over to our Issue Tracker.

Update - June 7th 2015: Creating new bug posts has been disabled. Please use our https://github.com/HerculesWS/Hercules/issues tracker to post bugs. Users are still able to reply to existing bug posts.

- Administration

Issue Information

  • #007671

  • 1 - Low

  • Fixed

Issue Confirmations

  • Yes (1)No (0)
Photo

Warper NPC bug for Pre-re

Posted by bgamez23 on 25 August 2013 - 08:51 AM

if you select to warp on the map that are not existed on Pre-re. you cannot move right after displaying "This map is not enabled in Pre-Renewal.

how to produce? talk to the npc warper.
select instance. and choose Octopus Cave or any other map that are not existed on Pre-re.
after you receive the "This map is not enabled in Pre-Renewal."
yoi can't move or talk to other npc.

Posted Image
Posted Image

i think the issue there is the close to end. but after changing it to close. it works again normally.

 npc/custom/warper.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/npc/custom/warper.txt b/npc/custom/warper.txt
index e8f640d..68a9cb1 100644
--- a/npc/custom/warper.txt
+++ b/npc/custom/warper.txt
@@ -88,7 +88,7 @@ function Pick {
 	}
 	if (.@warp_block & (1<<.@select)) {
 		message strcharinfo(0),"This map is not enabled in "+((checkre(0))?"":"Pre-")+"Renewal.";
-		end;
+		close;
 	}
 	warp .@map$,@c[.@i*2],@c[.@i*2+1];
 	getmapxy(lastwarp$,lastwarpx,lastwarpy,0);
@@ -103,7 +103,7 @@ function Restrict {
 				set @warp_block, @warp_block | (1<<getarg(.@i));
 		} else {
 			message strcharinfo(0),"This map is not enabled in "+((checkre(0))?"":"Pre-")+"Renewal.";
-			end;
+			close;
 		}
 	}
 	return;



still waiting for official fix. :)

The error was not really close by.

For a end, the script will terminate, but returns nothing, because there's nothing else to be returned, as with a close, the script closes and ends the above function.

I'll soon fix. ;)

locked issue

changed status to: Fixed

opened issue

changed severity to: 1 - Low