Jump to content

  •  

Bug Tracker Migration

June 3rd
Good news everyone! The staff has decided that it is time to slowly kill off this Bug Tracker. We will begin the process of slowly migrating from this Bug Tracker over to our Github Issues which can be found here: https://github.com/HerculesWS/Hercules/issues

Over the next couple of days, I will be closing off any opportunity to create new reports. However, I still will keep the opportunity to reply to existing Bug Reports. Doing this will allow us to slowly fix any bug reports we have listed here so that we can easily migrate over to our Issue Tracker.

Update - June 7th 2015: Creating new bug posts has been disabled. Please use our https://github.com/HerculesWS/Hercules/issues tracker to post bugs. Users are still able to reply to existing bug posts.

- Administration

Issue Information

  • #007677

  • 0 - None Assigned

  • Confirmed

Issue Confirmations

  • Yes (1)No (1)
Photo

Skill tree lost when using item skill

Posted by kyeme on 29 August 2013 - 05:53 AM

Whenever I use hiding skill (from smokie card) on my Knight, or Paladin w/ a Pecopeco, my skill tree will be lost. It doesn't happen if I dont have a pecopeco.
Please confirm thank you :)


Even in official servers also happens this?

@Frost
No :)
@Kyeme
i have no problem with it -.-

Ind 
changed status to: Needs More Info

i can't reproduce it either, whats your client version?

Im using 2012-04-17a ragexe client, pre-renewal

hmm o-o I'll check with other devs, I can't see how this can be done -- the hiding status doesn't force the server to re-send nor re-calculate the skill tree

Question is this reproduceable nowadays? I think I might have fixed it on a commit earlier (I tried to reproduce it just now and I couldn't thus why I'm asking if you still can reproduce)

Yes
Posted Image


Hmm.. i can't reproduce it now.. -_- maybe a client problem?

Edited by Frost, 21 September 2014 - 02:48 AM.


I tried on 3 clients, 2010 client can't reproduce this problem, 2011 can, 2012 can, dont know if 2013 also have this problem.

Kyeme I have a question, if possible, could you test this?
in src/map/status.c you'll find this:
		case SC_HIDING:
			sc->option &= ~OPTION_HIDE;
			opt_flag|= 2|4; //Check for warp trigger + AoE trigger
			break;
Change to
		case SC_HIDING:
			sc->option &= ~OPTION_HIDE;
			opt_flag|= 2;
			break;
and let me know if it still happens (that is, if you can test). Thanks!

Kyeme I have a question, if possible, could you test this?
in src/map/status.c you'll find this:

		case SC_HIDING:
			sc->option &= ~OPTION_HIDE;
			opt_flag|= 2|4; //Check for warp trigger + AoE trigger
			break;
Change to
		case SC_HIDING:
			sc->option &= ~OPTION_HIDE;
			opt_flag|= 2;
			break;
and let me know if it still happens (that is, if you can test). Thanks!


^ Fixed! Thanks sir :D

Ind 
changed status to: Confirmed

Okay I see what the problem is, can't fix straight away because the variable is being shared for another functionality.
	if(opt_flag&4) //Out of hiding, invoke on place.
		skill->unit_move(bl,timer->gettick(),1);

	if(opt_flag&2 && sd && map->getcell(bl->m,bl->x,bl->y,CELL_CHKNPC))
		npc->touch_areanpc(sd,bl->m,bl->x,bl->y); //Trigger on-touch event.