Estin, Estun, Breakfall and kick stance

Bump!

+1 confirmed, especially the Soul linker part

Estin: Full DMG on Medium, 1 DMG on small and large
Estun: Full DMG on Small and Medium, 1 DMG on large. The stun is like never occurring.

(yes stun never occurs)

bump

Hello,

Just curious to know if this report is monitored, thank you.

Any notice?

BUMP

Can a developer tell something about it? please

Bump. Issue confirmed on my local server too. I'll take a look on that.

In the SQL DB :
1001 - Scorpion - Scale : 0
1002 - Poring - Scale : 1

@mi :
Scorpion : Small (so size = 0)
Poring : Medium (so size = 1)

Sources :
enum size {
SZ_MEDIUM = 0, // <--- Wtf ?
SZ_SMALL,
SZ_BIG,
};

We've got this in the source code, for the stun part of SL_STUN (Estun)

src/map/skill.c:954

case SL_STUN:
	if (tstatus->size==SZ_MEDIUM) //Only stuns mid-sized mobs.
		sc_start(src,bl,SC_STUN,(30+10*skill_lv),skill_lv,skill->get_time(skill_id,skill_lv));
	break;

SZ_MEDIUM = 0, in the DB 0 is related to small sized monsters.

I don't think it's harmless to change the size enum, I suppose that this is used everywhere and it needs some investigations. I.E., we need to check if the damage calculation (with axes/swords) is also wrong (because of the wrong enum).

Edit: This commit changed a lot of things related with the size enum : https://github.com/H...3ab1bf37a5bc6b8

Edit 2: We can also see an old comment that proofs that there is a problem with these skills...

src/map/battle.c:1467

case SL_STIN:
	skillratio += (tst->size!=SZ_SMALL?-99:10*skill_lv); //target size must be small (0) for full damage.
	break;
case SL_STUN:
	skillratio += (tst->size!=SZ_BIG?5*skill_lv:-99); //Full damage is dealt on small/medium targets

"//target size must be small (0) for full damage."
0 is now related to medium size monsters.

Edited by Myskelz, 24 August 2014 - 11:25 PM.

If you want to fix it, there is a workaround only for Estun/Estin skills. I tested it yesterday and it works now fine.

src/map/battle.c:1467

case SL_STIN:
	//skillratio += (tst->size!=SZ_SMALL?-99:10*skill_lv); //target size must be small (0) for full damage.
	skillratio += (tst->size!=SZ_MEDIUM?-99:10*skill_lv); //[Lyyn] Workaround because of the wrong enum size
	break;

src/map/skill.c:954

case SL_STUN:
	//if (tstatus->size==SZ_MEDIUM) //Only stuns mid-sized mobs.
	if (tstatus->size==SZ_SMALL) // [Lyyn] Workaround because of the wrong enum size
		sc_start(src,bl,SC_STUN,(30+10*skill_lv),skill_lv,skill->get_time(skill_id,skill_lv));
	break;

Edited by マヤコ Lyyn~, 25 August 2014 - 12:06 PM.

Fixed in: https://github.com/H...02350a94856a583