Issue Information
-
#007981
-
0 - None Assigned
-
Confirmed
Issue Confirmations
-
Yes (0)No (0)
1
The script command 'showevent' is either not reading the QTYPE constants properly or is sending the wrong packets to the client. Tested on a 2010-07-30a RagexeRE client. Please confirm.
How to replicate:
Load the following script into your test server and click each NPC. Each NPC's name corresponds to the QTYPE constant that 'showevent' is using. Additionally, the values returned by QTYPE are expressed in a message string upon activating the 'showevent' command.
Screenshot:
How to replicate:
Load the following script into your test server and click each NPC. Each NPC's name corresponds to the QTYPE constant that 'showevent' is using. Additionally, the values returned by QTYPE are expressed in a message string upon activating the 'showevent' command.
prontera,148,157,3 script QTYPE_NONE::qtype 4_BOARD3,{
message strcharinfo(0), "QTYPE_NONE ("+ QTYPE_NONE +")";
showevent QTYPE_NONE, 0; // 0x270f, no icon, no mark
end;
}
prontera,150,157,3 script QTYPE_QUEST::qtype0 4_BOARD3,{
message strcharinfo(0), "QTYPE_QUEST ("+ QTYPE_QUEST +")";
showevent QTYPE_QUEST, 1; // 0x00, ! quest icon, yellow mark
end;
}
prontera,152,157,3 script QTYPE_QUEST2::qtype1 4_BOARD3,{
message strcharinfo(0), "QTYPE_QUEST2 ("+ QTYPE_QUEST2 +")";
showevent QTYPE_QUEST2, 1; // 0x01, ? quest icon, yellow mark
end;
}
prontera,154,157,3 script QTYPE_JOB::qtype2 4_BOARD3,{
message strcharinfo(0), "QTYPE_JOB ("+ QTYPE_JOB +")";
showevent QTYPE_JOB, 2; // 0x02, ! job icon, green mark
end;
}
prontera,156,157,3 script QTYPE_JOB2::qtype3 4_BOARD3,{
message strcharinfo(0), "QTYPE_JOB2 ("+ QTYPE_JOB2 +")";
showevent QTYPE_JOB2, 2; // 0x03, ? job icon, green mark
end;
}
prontera,158,157,3 script QTYPE_EVENT::qtype4 4_BOARD3,{
message strcharinfo(0), "QTYPE_EVENT ("+ QTYPE_EVENT +")";
showevent QTYPE_EVENT, 3; // 0x04, ! event icon, purple mark
end;
}
prontera,160,157,3 script QTYPE_EVENT2::qtype5 4_BOARD3,{
message strcharinfo(0), "QTYPE_EVENT2 ("+ QTYPE_EVENT2 +")";
showevent QTYPE_EVENT2, 3; // 0x05, ? event icon, purple mark
end;
}
prontera,162,157,3 script QTYPE_WARG::qtype6 4_BOARD3,{
message strcharinfo(0), "QTYPE_WARG ("+ QTYPE_WARG +")";
showevent QTYPE_WARG, 0; // 0x06, warg, no mark
end;
}
prontera,164,157,3 script QTYPE_WARG2::qtype8 4_BOARD3,{
message strcharinfo(0), "QTYPE_WARG2 ("+ QTYPE_WARG2 +")";
showevent QTYPE_WARG2, 0; // 0x08, warg face, no mark
end;
}
Screenshot:
i confirm this on 2010-07-30 ragexe re
/bump
I think at some point the codes were swapped, and we forgot about it and just supported the new ones (blame client devs :X)
I'll try to fix em when I revisit the questinfo command. In all honesty using showevent on an older client is not really a great idea. Gravity didn't start actually using the bubbles until like 2011 I wanna say. questinfo makes use of the bubbles in the proper way. The old style of using showevent with onpcload... is not really practical.
Again though, I'll take a look at it and see what I can come up with so that it'll still work for old clients. Basically the ID was changed like 3 or 4 times between 2010 and 2013 clients.
That's why in src it does this:
Again though, I'll take a look at it and see what I can come up with so that it'll still work for old clients. Basically the ID was changed like 3 or 4 times between 2010 and 2013 clients.
That's why in src it does this:
#if PACKETVER >= 20120410 if(icon < 0 || (icon > 8 && icon != 9999) || icon == 7) icon = 9999; // Default to nothing if icon id is invalid. #else if(icon < 0 || icon > 7) icon = 0; else icon = icon + 1; #endif
Following up on this issue, the problem does not occur on 2013-08-07aRagexe.
Any news on this? is it possible to fix it ?
