Issue Information
-
#007988
-
0 - None Assigned
-
Fixed
Issue Confirmations
-
Yes (2)No (1)
3
Use Last GIT of Hercules
Reproduce:
Reproduce:
- Use your royal guard
- Use your skill Exceed Break
- Map server crashed successfuly.
Using Clean last Git revision, Failed to reproduce, it ddnt. crashed after using Exceed Break 2x..
Maybe there something in your src modification that affects your map server causing it to crashed.
Maybe there something in your src modification that affects your map server causing it to crashed.
that's weird,
last 30 minutes, i did with clean GIT, and got map server crash. -,-
last 30 minutes, i did with clean GIT, and got map server crash. -,-
Couldn't reproduce either
EDIT:
Just checked following Malufett's instructions and could reproduce
EDIT:
Just checked following Malufett's instructions and could reproduce
Edited by pan, 27 January 2014 - 03:38 AM.
it will crashed if you don't have weapons equipped...
Open db/re/skill_require_db.txt and find:
2316,0,0,24:28:32:36:40,0,0,0,99,0,0,none,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0 //LG_EXEEDBREAK#Exceed Break#Replace it with:
2316,0,0,24:28:32:36:40,0,0,0,2:3:4:5,0,0,none,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0 //LG_EXEEDBREAK#Exceed Break#Also, open your src/map/skill.c and find:
case SC_EXEEDBREAK:
val1 *= 150; // 150 * skill_lv
if( sd && sd->inventory_data[sd->equip_index[EQI_HAND_R]] ) { // Chars.
val1 += (sd->inventory_data[sd->equip_index[EQI_HAND_R]]->weight/10 * sd->inventory_data[sd->equip_index[EQI_HAND_R]]->wlv * status->get_lv(bl) / 100);
val1 += 15 * (sd ? sd->status.job_level:50) + 100;
} else // Mobs
val1 += (400 * status->get_lv(bl) / 100) + (15 * (status->get_lv(bl) / 2)); // About 1138% at mob_lvl 99. Is an aproximation to a standard weapon. [pakpil]
break;
Replace it with:
case SC_EXEEDBREAK:
val1 *= 150; // 150 * skill_lv
if( sd )
{
if( sd->equip_index[EQI_HAND_R] >= 0 && sd->inventory_data[sd->equip_index[EQI_HAND_R]] )
{
val1 += (sd->inventory_data[sd->equip_index[EQI_HAND_R]]->weight/10 * sd->inventory_data[sd->equip_index[EQI_HAND_R]]->wlv * status->get_lv(bl) / 100);
val1 += 15 * (sd ? sd->status.job_level:50) + 100;
}
}
else // Mobs
val1 += (400 * status->get_lv(bl) / 100) + (15 * (status->get_lv(bl) / 2)); // About 1138% at mob_lvl 99. Is an aproximation to a standard weapon. [pakpil]
break;
Edited by pan, 27 January 2014 - 04:09 AM.
^ its nice if your going to make a pull request for that.
Well, I have one pull request that's been in that list for a week now, I'll see if I can make one today c:
Also I've documented skill_require_db, figuring out how to edit that thing was a mess:
http://pastebin.com/nvZmBkYh
EDIT:
Already made pull request, but somehow it merged with my last one...
https://github.com/H...rcules/pull/254
Also I've documented skill_require_db, figuring out how to edit that thing was a mess:
http://pastebin.com/nvZmBkYh
EDIT:
Already made pull request, but somehow it merged with my last one...
https://github.com/H...rcules/pull/254
Edited by pan, 27 January 2014 - 04:31 AM.
^ Haha thats nice, lets wait for devs to take a look at it.
Fixed @ 9b5bb9aa894d63d1d9f2cafa91f90bc4922bf414
Thanks pan..
Thanks pan..
Fixed @ 9b5bb9aa894d63d1d9f2cafa91f90bc4922bf414
Thanks pan..
can you link it again where i can see the fix
can you link it again where i can see the fix
Fixed @ 9b5bb9aa894d63d1d9f2cafa91f90bc4922bf414
Thanks pan..
https://github.com/H...1f90bc4922bf414
