Cart Disappearance

confirm , even on a clean rev

tested in pre-re mode

Confirmed in Renewal to.

Confirmed also..

I can confirm this

sc_config.txt can't solve the problem. /sob

Confirmed  

Edited by Hadeszeus, 27 February 2014 - 02:03 AM.

confirm too

no.1
the cart is actually can be done with setoption

prontera,157,183,5	script	kjdhfkjshf	100,{
	setoption 0x100, 1;
}

exact same script
on rathena works
on hercules, it doesn't even gives you a cart

no.2

prontera,154,183,5	script	kjdhfkjshf2	100,{
	if ( checkcart() ) {
		if ( checkoption(0x8) ) .@cart = 1;
		if ( checkoption(0x80) ) .@cart = 2;
		if ( checkoption(0x100) ) .@cart = 3;
		if ( checkoption(0x200) ) .@cart = 4;
		if ( checkoption(0x400) ) .@cart = 5;
		dispbottom "you have cart no."+ .@cart;
	}
	else
		dispbottom "no cart";
	end;
}

on rathena, having a cart, this sample will tell you which cart you are having
on hercules, nope, checkcart() ok, but checkoption all return 0

no.3
cart is saves in `option` column in `char` table
on rathena, having cart no.1 save as 8
on hercules, having a cart, logout, remains 0


I just read pc.h

#ifdef NEW_CARTS
	#define pc_iscarton(sd)       ( (sd)->sc.data[SC_PUSH_CART] )
#else
	#define pc_iscarton(sd)       ( (sd)->sc.option&OPTION_CART )
#endif

hmm ...........


ok ... it actually save in `sc_data` table ...
.... haha ...
that means now we have 9 carts

Edited by AnnieRuru, 27 February 2014 - 05:23 AM.

the bug came in when they tryed to fix the bug with the permanent stats who where written in the database twice on login.

also +1 confirmed

Bump.

I think this bug was causes by the rewrite of the sc code quite soon after the last sc bug was fixed ^^

it happens ones a char logs out. there is a function that checks for invalid status effects. however this functions considers all status effects with a -1 tick as invalid. because of this all permanent status effects are removed once you log of. mounts, sitting, taekwon stances, carts...

here is my debug log (1 is the start of the function and 2 is the end of the function):

[Info]: save_scdata_single()1
[Info]: save_scdata_single()2
[Info]: Character 'test' logged off.
[Info]: chrif_Save()1
[Info]: chrif_save_scdata()1
[Info]: chrif_save_scdata()2
[Info]: chrif_Save()2
[Info]: status_change_end_(...)1
[Info]: chrif_del_scdata_single(2000000, 150000, 517)
[Info]: status_change_end_(...)2
[Info]: chrif_save_ack()1
[Info]: chrif_save_ack()2

The sc values are saved correctly but then status_change_end_ removes this status. Unfortunately I have no idea what exactly status_change_end_ is supposed to do so I couldn't fix it myself.

Bump!

and another bump

I can confirm this

Even i confirm this. Even My players are having the same problem,

Lol, Since febuary this has been happening and not even a reply from the developer or any solution?
This is a big problem which needs to be resolved.

Bumper~

I agree with Shackles. This should be fix. It's really annoying to the players.

bump...

Edited by evehour, 10 March 2014 - 02:03 PM.

bump da bump..

Confirmed; I'll service anyone who posts a fix. xoxo<3

Temp fix inspired by ossi's sexy face:

add to an OnPCLoginEvent: script the following:

if (getskilllv(39) >= 1) {atcommand "@cart 9"; dispbottom "Notice: As a temporary fix, players with Push Cart Level 1 or higher will all have a cart assigned to them upon login since it disappears otherwise.";}

Shout praise.

Fixed in https://github.com/H...df7e269ce89bfc5