Jump to content

  •  

Bug Tracker Migration

June 3rd
Good news everyone! The staff has decided that it is time to slowly kill off this Bug Tracker. We will begin the process of slowly migrating from this Bug Tracker over to our Github Issues which can be found here: https://github.com/HerculesWS/Hercules/issues

Over the next couple of days, I will be closing off any opportunity to create new reports. However, I still will keep the opportunity to reply to existing Bug Reports. Doing this will allow us to slowly fix any bug reports we have listed here so that we can easily migrate over to our Issue Tracker.

Update - June 7th 2015: Creating new bug posts has been disabled. Please use our https://github.com/HerculesWS/Hercules/issues tracker to post bugs. Users are still able to reply to existing bug posts.

- Administration

Issue Information

Issue Confirmations

  • Yes (0)No (0)
Photo

mob_skill_db.txt typo

Posted by Angelmelody on 14 March 2014 - 07:39 PM

mob_skill_db.txt  and  mob_skill_db2.txt


4: added for all mobs.

it should be

3: added for all mobs.

I spoke with Haruna and he told me that it is intended.

[11:31:30] <&Haruna> it uses bit masks

65][11:31:37] <&Haruna> so 4 is correct




changed severity to: 1 - Low
changed status to: Working as Intended
changed severity to: 0 - None Assigned

I spoke with Haruna and he told me that it is intended.


[11:31:30] <&Haruna> it uses bit masks

65][11:31:37] <&Haruna> so 4 is correct


if it was set to 4 will continue the loop
		for (i = 1; i < MAX_MOB_DB; i++)
		{
			if (mob->db_data[i] == NULL)
				continue;
			if (mob->db_data[i]->status.mode&MD_BOSS)
			{
				if (!(mob_id&2)) //Skill not for bosses
					continue;
			} else
				if (!(mob_id&1)) //Skill not for normal enemies.
					continue;

			ARR_FIND( 0, MAX_MOBSKILL, j, mob->db_data[i]->skill[j].skill_id == 0 );
			if(j==MAX_MOBSKILL)
				continue;

			memcpy (&mob->db_data[i]->skill[j], ms, sizeof(struct mob_skill));
			mob->db_data[i]->maxskill=j+1;
		}


if it was set to 4 will continue the loop

yes it should continue loop so that 'added for all mobs' is true and if was set as 3 it will be 'not added for all mobs'

:meow:





if it was set to 4 will continue the loop

yes it should continue loop so that 'added for all mobs' is true and if was set as 3 it will be 'not added for all mobs'

:meow:


Sorry, the word continue  what I mean was continue statement which skip the rest of the code in the current loop.

if set to 4, skill won't be added to any mob

Edited by Angelmelody, 15 March 2014 - 06:40 PM.