Jump to content

  •  

Bug Tracker Migration

June 3rd
Good news everyone! The staff has decided that it is time to slowly kill off this Bug Tracker. We will begin the process of slowly migrating from this Bug Tracker over to our Github Issues which can be found here: https://github.com/HerculesWS/Hercules/issues

Over the next couple of days, I will be closing off any opportunity to create new reports. However, I still will keep the opportunity to reply to existing Bug Reports. Doing this will allow us to slowly fix any bug reports we have listed here so that we can easily migrate over to our Issue Tracker.

Update - June 7th 2015: Creating new bug posts has been disabled. Please use our https://github.com/HerculesWS/Hercules/issues tracker to post bugs. Users are still able to reply to existing bug posts.

- Administration

Issue Information

  • #008118

  • 3 - Medium

  • Fixed

Issue Confirmations

  • Yes (2)No (0)
Photo

Skill Plagiarism copying skills of 3RD Class

Posted by OmegaRed on 23 March 2014 - 08:28 PM

Plagiarism are copying skills of 3RD Class

Tested with skill dark crow (Guillotine Cross)

I believe it's copying only new skills 3RD Class

Posted Image

Diamond Dust and ->>  Illusion Doping
I can confirm

in map/skill.c search for "// Making plagiarize check its own function [Aru]"
// Making plagiarize check its own function [Aru]
int can_copy (struct map_session_data *sd, uint16 skill_id, struct block_list* bl)
{
// Never copy NPC/Wedding Skills
if (skill->get_inf2(skill_id)&(INF2_NPC_SKILL|INF2_WEDDING_SKILL))
return 0;


add
	//Never copy 3RD class new Skills By OmegaRed
	if(skill_id >= GC_DARKCROW && skill_id <= SR_FLASHCOMBO_ATK_STEP4)
		return 0;


modified
// Making plagiarize check its own function [Aru]
int can_copy (struct map_session_data *sd, uint16 skill_id, struct block_list* bl)
{
	// Never copy NPC/Wedding Skills
	if (skill->get_inf2(skill_id)&(INF2_NPC_SKILL|INF2_WEDDING_SKILL))
		return 0;

	//Never copy 3RD class new Skills By OmegaRed
	if(skill_id >= GC_DARKCROW && skill_id <= SR_FLASHCOMBO_ATK_STEP4)
		return 0;
	
	// High-class skills
	if((skill_id >= LK_AURABLADE && skill_id <= ASC_CDP) || (skill_id >= ST_PRESERVE && skill_id <= CR_CULTIVATION))
	{
		if(battle_config.copyskill_restrict == 2)
			return 0;
		else if(battle_config.copyskill_restrict)
			return (sd->status.class_ == JOB_STALKER);
	}

	//Added so plagarize can't copy agi/bless if you're undead since it damages you
	if ((skill_id == AL_INCAGI || skill_id == AL_BLESSING ||
		skill_id == CASH_BLESSING || skill_id == CASH_INCAGI ||
		skill_id == MER_INCAGI || skill_id == MER_BLESSING))
		return 0;

	// Couldn't preserve 3rd Class skills except only when using Reproduce skill. [Jobbie]
	if( !(sd->sc.data[SC__REPRODUCE]) && ((skill_id >= RK_ENCHANTBLADE && skill_id <= SR_RIDEINLIGHTNING) || (skill_id >= KO_YAMIKUMO && skill_id <= OB_AKAITSUKI)))
		return 0;
	// Reproduce will only copy skills according on the list. [Jobbie]
	else if( sd->sc.data[SC__REPRODUCE] && !skill->reproduce_db[skill->get_index(skill_id)] )
		return 0;

	return 1;
}
This solved for me

Edited by OmegaRed, 26 March 2014 - 03:33 AM.


changed severity to: 3 - Medium

changed status to: Fixed