Jump to content

  •  

Bug Tracker Migration

June 3rd
Good news everyone! The staff has decided that it is time to slowly kill off this Bug Tracker. We will begin the process of slowly migrating from this Bug Tracker over to our Github Issues which can be found here: https://github.com/HerculesWS/Hercules/issues

Over the next couple of days, I will be closing off any opportunity to create new reports. However, I still will keep the opportunity to reply to existing Bug Reports. Doing this will allow us to slowly fix any bug reports we have listed here so that we can easily migrate over to our Issue Tracker.

Update - June 7th 2015: Creating new bug posts has been disabled. Please use our https://github.com/HerculesWS/Hercules/issues tracker to post bugs. Users are still able to reply to existing bug posts.

- Administration

Issue Information

  • #008160

  • 4 - High

  • Unable to Fix

Issue Confirmations

  • Yes (0)No (1)
Photo

char-server Crash on @accinfo / @accountinfo

Posted by OmegaRed on 21 April 2014 - 10:41 PM

gdb) bt full
#0  geoip_getcountry (ipnum=3142518760) at inter.c:421
        depth = <value optimized out>
        x = <value optimized out>
        buf = 0x7ffff99f63b2 <Address 0x7ffff99f63b2 out of bounds>
        offset = <value optimized out>
#1  0x0000000000426a4d in mapif_parse_accinfo2 (success=<value optimized out>, map_fd=10, u_fd=146, u_aid=1000XXX, account_id=200XXXX, userid=0x74a092 "mXXXXXX",
    user_pass=0x74a0aa "159XXXXXX[", email=0x74a0cb "[email protected]", last_ip=0x74a0f3 "187.XXX.XXX.XXX", lastlogin=0x74a107 "2014-04-21 18:03:47", pin_code=0x74a127 "XXXX",
    birthdate=0x74a12c "0000-00-00", group_id=2, logincount=5, state=0) at inter.c:560
No locals.
#2  0x000000000041ddcd in parse_fromlogin (fd=9) at char.c:2615
        command = <value optimized out>
        sd = <value optimized out>
#3  0x000000000044343e in do_sockets (next=<value optimized out>) at socket.c:872
        rfd = {__fds_bits = {512, 0 <repeats 15 times>}}
        timeout = {tv_sec = 0, tv_usec = 185754}
        ret = 0
        i = <value optimized out>
#4  0x000000000043f9e1 in main (argc=<value optimized out>, argv=<value optimized out>) at core.c:250
        next = <value optimized out>
Char-server crash when I use @ accinfo "char name" or "partial char name" (%John%).

does it crash on any char name?

I used the command on the production server, after crashed not tested more.

Edited by OmegaRed, 21 April 2014 - 11:20 PM.


Tested on my beta server and same problem, crash on @accinfo with any char name.

changed status to: Confirmed

Can you try to re-download the GeoIP.dat file from the Hercules repository? I suspect you have a corrupted version of the file. You can download a clean copy from https://github.com/H...er/db/GeoIP.dat (click the Raw button), or simply clone the git repository again.

While I can't reproduce the issue on a clean copy, I'm marking this issue as confirmed, since I can get it to crash with a corrupted .dat file, and we're not doing any checks during/after the file is loaded.

Please let us know if a clean copy of the file fixes the issue for you, and if it doesn't, it'd be nice to know what operating system/version your server is running on, so we can test in a similar environment.

yes, GeoIP.dat Corrupted.
Replaced GeoIP.dat and now is working ok

thks

Edited by OmegaRed, 22 April 2014 - 12:40 AM.


pan 
changed status to: Started

Just waiting some more info regarding our geoip.dat before commiting this fix.

pan 
changed severity to: 4 - High

pan 
changed status to: Unable to Fix