Jump to content

  •  

Bug Tracker Migration

June 3rd
Good news everyone! The staff has decided that it is time to slowly kill off this Bug Tracker. We will begin the process of slowly migrating from this Bug Tracker over to our Github Issues which can be found here: https://github.com/HerculesWS/Hercules/issues

Over the next couple of days, I will be closing off any opportunity to create new reports. However, I still will keep the opportunity to reply to existing Bug Reports. Doing this will allow us to slowly fix any bug reports we have listed here so that we can easily migrate over to our Issue Tracker.

Update - June 7th 2015: Creating new bug posts has been disabled. Please use our https://github.com/HerculesWS/Hercules/issues tracker to post bugs. Users are still able to reply to existing bug posts.

- Administration

Issue Information

  • #008171

  • 0 - None Assigned

  • Fixed

Issue Confirmations

  • Yes (0)No (0)
Photo

char-server crash OnInterIfInit/OnInterIfInitOnce

Posted by memoryss on 02 May 2014 - 07:01 AM

char-server crashes when a player login while map-server is executing OnInterIfInit/OnInterIfInitOnce events.

To reproduce the issue, run the following script:
- script test -1,{
OnInterIfInit:
freeloop(1);
for( ; ; ) ;
}
login a character while map-server is executing the event.

fix:
char.c
ARR_FIND( 0, ARRAYLENGTH(server), server_id, server[server_id].fd > 0 && server[server_id].map[0] );
change to
ARR_FIND( 0, ARRAYLENGTH(server), server_id, server[server_id].fd > 0 && server[server_id].map );

why should someone write such a script for his server?

the script is only for reproducing this issue

changed status to: Confirmed

server[serever_id].maps can also be used.

There should be a few more cases where it needs to be fixed, too

Ind 
changed status to: Started

Ind 
changed status to: Fixed