Jump to content

  •  

Bug Tracker Migration

June 3rd
Good news everyone! The staff has decided that it is time to slowly kill off this Bug Tracker. We will begin the process of slowly migrating from this Bug Tracker over to our Github Issues which can be found here: https://github.com/HerculesWS/Hercules/issues

Over the next couple of days, I will be closing off any opportunity to create new reports. However, I still will keep the opportunity to reply to existing Bug Reports. Doing this will allow us to slowly fix any bug reports we have listed here so that we can easily migrate over to our Issue Tracker.

Update - June 7th 2015: Creating new bug posts has been disabled. Please use our https://github.com/HerculesWS/Hercules/issues tracker to post bugs. Users are still able to reply to existing bug posts.

- Administration

Issue Information

  • #008248

  • 0 - None Assigned

  • Fixed

Issue Confirmations

  • Yes (1)No (0)
Photo

job master bug

Posted by Ridley on 04 July 2014 - 10:19 AM

When changing job from Novice to Baby, your skills and skillpoints are not reset. So on jlvl 10 you have 9 Skill points, but Basic Skill on 9 and the npc keep telling you to use your skill points first.

Edit: fixed typo

This doesn't seem like a job master bug.

Also, could you elaborate on the process again? I'm confused on how you got a Novice to have level 9 Base Skills and 9 skpoints.

1. Make a new char
2. Lvl to jlvl 10 and get your Basic skill on lv. 9 to get your first job
3. Talk to the Job Master and become a Baby class. It will reset your jlvl to 0, but your Basic skill is still Lv. 9
When you level to jlvl 10 again you have the New 9 skill points and Basic skill already maxed

Got it, you said supernovice, not a baby in your post.

Anyway, I can confirm that. I suppose the way to work it out is manually interfere with that particular job change - either resetting character completely, or just taking away Basic Skills and all skill points:

Resetting the character (affects base level as well, which is rude):
Spoiler


Meddling with skill points (manually modifies skill point amount, which is also rude):
Spoiler

Edited by Enhance, 05 July 2014 - 12:04 AM.


Got it, you said supernovice, not a baby in your post.


oops, happens when posting drunk.
However, i think the most simple way is to require job/base level 1 to transform into Baby.

However, i think the most simple way is to require job/base level 1 to transform into Baby.

I thought that, but technically, you're not required to be 1/1 to be adopted.

I thought that, but technically, you're not required to be 1/1 to be adopted.


And thats the point, since it's not intended to become baby using a npc. Right now i just can't think of any other way then setting b/j lvl 1 as requirement.

edit: or maybe, preventing the script to reset your job level back to 0 <-- lol i don't know why i haven't thought of this.

Edited by Ridley, 05 July 2014 - 12:47 PM.



I thought that, but technically, you're not required to be 1/1 to be adopted.

And thats the point, since it's not intended to become baby using a npc. Right now i just can't think of any other way then setting b/j lvl 1 as requirement.

I already gave two other solutions, so why can't you?

edit: or maybe, preventing the script to reset your job level back to 0 <-- lol i don't know why i haven't thought of this.

Script doesn't separately reset your job level to 1, jobchange itself does. So you can't do that without changing that very script command.

Edited by Enhance, 05 July 2014 - 04:09 PM.


well, as said, most simple way is to do a manual reset
find:
			if (.@newjob == Job_Novice_High)
				resetlvl(1);

add below
			if (.@newjob == Job_Baby)
				resetskill;
				SkillPoint = 0;

Edited by Ridley, 05 July 2014 - 06:28 PM.


Confirmed, but your pull request needs to be updated before it can be merged.

https://github.com/H...rcules/pull/306

Went ahead and updated this in 3961c4c since it's been pending for 5 days. Thanks for your contribution!

changed status to: Fixed