Issue Information
-
#008513
-
0 - None Assigned
-
Fixed
Issue Confirmations
-
Yes (0)No (0)
0
As reported by one of our players and then confirmed by staff.
The skill's damage appears to increase according to the skill level used. The skill is supposed to do 70% of my matk per hit, my matk being 199+64, so it should be doing around 165 damage to a chonchon (Which has 0 hard and soft mdef and takes 90% from water.) per hit, when in reality it's doing a range of 283 to 303 at level 1 per hit, nearly double that value.
At level 2, the damage per hit moves up to 443, and it continues to increase per level, where at level 10 it does 1506 per hit to a chonchon.
can you show us the complete test setup?
#ifdef RENEWAL case NJ_HYOUSENSOU: skillratio -= 30; if (sd && sd->charm_type == CHARM_TYPE_WATER && sd->charm_count > 0) skillratio += 5 * sd->charm_count; #endif /* Fall through */ case NJ_HYOUSYOURAKU: skillratio += 50 * skill_lv; if (sd && sd->charm_type == CHARM_TYPE_WATER && sd->charm_count > 0) skillratio += 25 * sd->charm_count; break;@malu in battle.c I think there is a break missing NJ_HYOUSENSOU got the bonus of NJ_HYOUSYOURAKU
#ifdef RENEWAL case NJ_HYOUSENSOU: skillratio -= 30; if (sd && sd->charm_type == CHARM_TYPE_WATER && sd->charm_count > 0) skillratio += 5 * sd->charm_count; #endif /* Fall through */ case NJ_HYOUSYOURAKU: skillratio += 50 * skill_lv; if (sd && sd->charm_type == CHARM_TYPE_WATER && sd->charm_count > 0) skillratio += 25 * sd->charm_count; break;@malu in battle.c I think there is a break missing NJ_HYOUSENSOU got the bonus of NJ_HYOUSYOURAKU
Confirmed, made a pull request. Adding break fixes it.
You should probably try to figure out where the "Fall through" comment comes from, because that usually means that the break; was intentionally left away.
