Jump to content

  •  
  • Wiki
  • GIT
  • IRC
  • + Others

Bug Tracker Migration

June 3rd
Good news everyone! The staff has decided that it is time to slowly kill off this Bug Tracker. We will begin the process of slowly migrating from this Bug Tracker over to our Github Issues which can be found here: https://github.com/HerculesWS/Hercules/issues

Over the next couple of days, I will be closing off any opportunity to create new reports. However, I still will keep the opportunity to reply to existing Bug Reports. Doing this will allow us to slowly fix any bug reports we have listed here so that we can easily migrate over to our Issue Tracker.

Update - June 7th 2015: Creating new bug posts has been disabled. Please use our https://github.com/HerculesWS/Hercules/issues tracker to post bugs. Users are still able to reply to existing bug posts.

- Administration

Issue Information

  • #008529

  • 0 - None Assigned

  • Fixed

Issue Confirmations

  • Yes (0)No (0)
Photo

NPC Earthquake damage calculation bugged and possibly wrong

Posted by Valo on 10 February 2015 - 01:35 AM

When refactoring skillratio calculation into battle_calc_skillratio the local variable skillratio was left in battle_calc_magic_attack. This led to not noticing that NPC_EARTHQUAKE special case used that local variable. I recommend updating the scope of skillratio (or removing it altogether).

Also I noticed that according to http://rode.doddlerc...uake/eqcalc.php and iro wiki earthquake should not use matk of the monster at all, but instead should do damage based on ATK_MIN ~ ATK_MAX alone.

malufett 
changed status to: Confirmed

malufett 
changed status to: Fixed


malufett

Feb 13 2015 01:12 PM
Fixed @21b72c42cbcf05377a4e72087db3fd0fb9a1d651
:meow:


Valo
Pip
Feb 13 2015 02:36 PM
Maya Card (etc) should be able to reflect Earth Quake (don't know if pre-re only). I don't think the fix considered this.


malufett

Feb 13 2015 03:16 PM

Maya Card (etc) should be able to reflect Earth Quake (don't know if pre-re only). I don't think the fix considered this.

how? afaik maya card and a like reflects only targeted type magic skills..

:meow:


Valo
Pip
Feb 14 2015 02:53 PM
It was implemented correctly as special case before. I don't know why / how it works but I killed MvPs with Maya Card and BG Equipment on official in pre-re. I think the classification of Earthquake as magic was correct.

Edited by Valo, 14 February 2015 - 02:55 PM.


Back to Other Skill Bugs


  1. Bug Tracker
  2. → Hercules Bug Archives
  3. → Skills
  4. → Other Skill Bugs
  5. → Status: Fixed
  6. Privacy Policy
  7. Hercules Forum Rules ·