Issue Information
-
#008579
-
0 - None Assigned
-
Fixed
Issue Confirmations
-
Yes (0)No (0)
0
Sorcerer - Warmer: Giving 10% MHP Regeneration per 3 Seconds Instead of 5%
Posted by Zia on 17 March 2015 - 07:10 PM
At level 5, Warmer is supposed to regenerate max HP at 5% every 3 seconds. (Source: http://irowiki.org/wiki/Warmer)
However, it's currently healing at 10% every 3 seconds.
Proof:
Tested in our test server. Max HP of 36,973 regenerated 3,698 on one tick at 3 seconds.
Attempted Fix:
Tried removing line with 1st status->heal(b1, hp, 0, 0); because there's 2 statements for it (Source: https://github.com/H.../skill.c#L12431)
Changed
case UNT_WARMER:
{
// It has effect on everything, including monsters, undead property and demon
int hp = 0;
if( ssc && ssc->data[SC_HEATER_OPTION] )
hp = tstatus->max_hp * 3 * sg->skill_lv / 100;
else
hp = tstatus->max_hp * sg->skill_lv / 100;
status->heal(bl, hp, 0, 0);
if( tstatus->hp != tstatus->max_hp )
clif->skill_nodamage(&src->bl, bl, AL_HEAL, hp, 0);
if( tsc && tsc->data[SC_AKAITSUKI] && hp )
hp = ~hp + 1;
status->heal(bl, hp, 0, 0);
sc_start(ss, bl, type, 100, sg->skill_lv, sg->interval + 100);
}
to
case UNT_WARMER:
{
// It has effect on everything, including monsters, undead property and demon
int hp = 0;
if( ssc && ssc->data[SC_HEATER_OPTION] )
hp = tstatus->max_hp * 3 * sg->skill_lv / 100;
else
hp = tstatus->max_hp * sg->skill_lv / 100;
if( tstatus->hp != tstatus->max_hp )
clif->skill_nodamage(&src->bl, bl, AL_HEAL, hp, 0);
if( tsc && tsc->data[SC_AKAITSUKI] && hp )
hp = ~hp + 1;
status->heal(bl, hp, 0, 0);
sc_start(ss, bl, type, 100, sg->skill_lv, sg->interval + 100);
}
And Warmer regenerated HP at 5% per 3 secs
Proof:
However, it's currently healing at 10% every 3 seconds.
Proof:
Tested in our test server. Max HP of 36,973 regenerated 3,698 on one tick at 3 seconds.
Attempted Fix:
Tried removing line with 1st status->heal(b1, hp, 0, 0); because there's 2 statements for it (Source: https://github.com/H.../skill.c#L12431)
Changed
case UNT_WARMER:
{
// It has effect on everything, including monsters, undead property and demon
int hp = 0;
if( ssc && ssc->data[SC_HEATER_OPTION] )
hp = tstatus->max_hp * 3 * sg->skill_lv / 100;
else
hp = tstatus->max_hp * sg->skill_lv / 100;
status->heal(bl, hp, 0, 0);
if( tstatus->hp != tstatus->max_hp )
clif->skill_nodamage(&src->bl, bl, AL_HEAL, hp, 0);
if( tsc && tsc->data[SC_AKAITSUKI] && hp )
hp = ~hp + 1;
status->heal(bl, hp, 0, 0);
sc_start(ss, bl, type, 100, sg->skill_lv, sg->interval + 100);
}
to
case UNT_WARMER:
{
// It has effect on everything, including monsters, undead property and demon
int hp = 0;
if( ssc && ssc->data[SC_HEATER_OPTION] )
hp = tstatus->max_hp * 3 * sg->skill_lv / 100;
else
hp = tstatus->max_hp * sg->skill_lv / 100;
if( tstatus->hp != tstatus->max_hp )
clif->skill_nodamage(&src->bl, bl, AL_HEAL, hp, 0);
if( tsc && tsc->data[SC_AKAITSUKI] && hp )
hp = ~hp + 1;
status->heal(bl, hp, 0, 0);
sc_start(ss, bl, type, 100, sg->skill_lv, sg->interval + 100);
}
And Warmer regenerated HP at 5% per 3 secs
Proof:
the level of detail in the report is outstanding, I appreciate the effort you've put into this. I've asked malufett and michieru to drop by
Thank you so much Ind. My team and I are doing whatever we can to support Hercules so it'll be as less buggy as possible so all my bug reports are detailed like this one.
Senpai noticed me I'm so happy.
Senpai noticed me I'm so happy.
changed status to: Confirmed
Requested a pull
changed status to: Fixed
Fixed @ 370c96e24ac21b47a4da6fb9c14dfcb8e9fbd19a