Javascript Disabled Detected

You currently have javascript disabled. Several functions may not work. Please re-enable javascript to access full functionality.

Bug Tracker Migration

June 3rd
Good news everyone! The staff has decided that it is time to slowly kill off this Bug Tracker. We will begin the process of slowly migrating from this Bug Tracker over to our Github Issues which can be found here: https://github.com/HerculesWS/Hercules/issues

Over the next couple of days, I will be closing off any opportunity to create new reports. However, I still will keep the opportunity to reply to existing Bug Reports. Doing this will allow us to slowly fix any bug reports we have listed here so that we can easily migrate over to our Issue Tracker.

Update - June 7th 2015: Creating new bug posts has been disabled. Please use our https://github.com/HerculesWS/Hercules/issues tracker to post bugs. Users are still able to reply to existing bug posts.

- Administration

Issue Information

Issue ID
#008672
Severity
0 - None Assigned
Status
Fixed

Issue Confirmations

Yes (6)No (0)

map server error?

Posted by N e s s on 11 May 2015 - 11:11 AM

Spoiler

im using latest rev and compiled using vs12

here is the error:

Haru

May 11 2015 12:08 PM

This happens because skill->get_sp() and skill->get_range() are being called with a skill_lv of 0. Up until now, we weren't checking for this kind of errors (so the error message wasn't displayed), but now we are.

If you have custom code in skill.c, you should review that, otherwise we'll need to figure out what skill is causing this.

The issue is currently harmless, but it's something that should be fixed.

N e s s

May 11 2015 01:25 PM

i dont have custom code sir Haru im using a clean herc in latest rev

Haru

changed status to: Confirmed

4144

May 11 2015 09:12 PM

here is fix. Not sure what it cant happend from other places, but atleast initial issues fixed

https://github.com/H...rcules/pull/513

Frost

May 11 2015 11:06 PM

still got the same errors even tho i update my hercules git.

kyeme

May 11 2015 11:15 PM

What OS @Frost

Haru

May 11 2015 11:50 PM

I made some follow-up patches with other related issues I found. Most cases should now be fixed, hopefully. If there's any more, please let us know.

Haru

changed status to: Fixed

N e s s

May 12 2015 02:17 AM

[Error]: --- failed assertion --------------------------------------------
[Error]: d:\program files (x86)\hercules\src\map\skill.c:179: 'skill_lv > 0' in function `unknown'
[Error]: --- end failed assertion ----------------------------------------
[Error]: --- failed assertion --------------------------------------------
[Error]: d:\program files (x86)\hercules\src\map\skill.c:179: 'skill_lv > 0' in function `unknown'
[Error]: --- end failed assertion ----------------------------------------
[Error]: --- failed assertion --------------------------------------------
[Error]: d:\program files (x86)\hercules\src\map\skill.c:179: 'skill_lv > 0' in function `unknown'
[Error]: --- end failed assertion ----------------------------------------
[Error]: --- failed assertion --------------------------------------------
[Error]: d:\program files (x86)\hercules\src\map\skill.c:179: 'skill_lv > 0' in function `unknown'
[Error]: --- end failed assertion ----------------------------------------
[Error]: --- failed assertion --------------------------------------------
[Error]: d:\program files (x86)\hercules\src\map\skill.c:179: 'skill_lv > 0' in function `unknown'
[Error]: --- end failed assertion ----------------------------------------
[Error]: --- failed assertion --------------------------------------------
[Error]: d:\program files (x86)\hercules\src\map\skill.c:179: 'skill_lv > 0' in function `unknown'
[Error]: --- end failed assertion ----------------------------------------
[Error]: --- failed assertion --------------------------------------------
[Error]: d:\program files (x86)\hercules\src\map\skill.c:179: 'skill_lv > 0' in function `unknown'
[Error]: --- end failed assertion ----------------------------------------
[Error]: --- failed assertion --------------------------------------------
[Error]: d:\program files (x86)\hercules\src\map\skill.c:179: 'skill_lv > 0' in function `unknown'
[Error]: --- end failed assertion ----------------------------------------
[Error]: --- failed assertion --------------------------------------------
[Error]: d:\program files (x86)\hercules\src\map\skill.c:179: 'skill_lv > 0' in function `unknown'
[Error]: --- end failed assertion ----------------------------------------
[Error]: --- failed assertion --------------------------------------------
[Error]: d:\program files (x86)\hercules\src\map\skill.c:179: 'skill_lv > 0' in function `unknown'
[Error]: --- end failed assertion ----------------------------------------
[Error]: --- failed assertion --------------------------------------------
[Error]: d:\program files (x86)\hercules\src\map\skill.c:179: 'skill_lv > 0' in function `unknown'
[Error]: --- end failed assertion ----------------------------------------
[Error]: --- failed assertion --------------------------------------------
[Error]: d:\program files (x86)\hercules\src\map\skill.c:179: 'skill_lv > 0' in function `unknown'
[Error]: --- end failed assertion ----------------------------------------

Frost

May 12 2015 02:22 AM

@Kyeme, Windows 7 Ult, 64bit

Dastgir

May 12 2015 02:29 AM

[Error]: --- failed assertion --------------------------------------------
[Error]: d:\program files (x86)\hercules\src\map\skill.c:179: 'skill_lv > 0' in function `unknown'
[Error]: --- end failed assertion ----------------------------------------
[Error]: --- failed assertion --------------------------------------------
[Error]: d:\program files (x86)\hercules\src\map\skill.c:179: 'skill_lv > 0' in function `unknown'
[Error]: --- end failed assertion ----------------------------------------
[Error]: --- failed assertion --------------------------------------------
[Error]: d:\program files (x86)\hercules\src\map\skill.c:179: 'skill_lv > 0' in function `unknown'
[Error]: --- end failed assertion ----------------------------------------
[Error]: --- failed assertion --------------------------------------------
[Error]: d:\program files (x86)\hercules\src\map\skill.c:179: 'skill_lv > 0' in function `unknown'
[Error]: --- end failed assertion ----------------------------------------
[Error]: --- failed assertion --------------------------------------------
[Error]: d:\program files (x86)\hercules\src\map\skill.c:179: 'skill_lv > 0' in function `unknown'
[Error]: --- end failed assertion ----------------------------------------
[Error]: --- failed assertion --------------------------------------------
[Error]: d:\program files (x86)\hercules\src\map\skill.c:179: 'skill_lv > 0' in function `unknown'
[Error]: --- end failed assertion ----------------------------------------
[Error]: --- failed assertion --------------------------------------------
[Error]: d:\program files (x86)\hercules\src\map\skill.c:179: 'skill_lv > 0' in function `unknown'
[Error]: --- end failed assertion ----------------------------------------
[Error]: --- failed assertion --------------------------------------------
[Error]: d:\program files (x86)\hercules\src\map\skill.c:179: 'skill_lv > 0' in function `unknown'
[Error]: --- end failed assertion ----------------------------------------
[Error]: --- failed assertion --------------------------------------------
[Error]: d:\program files (x86)\hercules\src\map\skill.c:179: 'skill_lv > 0' in function `unknown'
[Error]: --- end failed assertion ----------------------------------------
[Error]: --- failed assertion --------------------------------------------
[Error]: d:\program files (x86)\hercules\src\map\skill.c:179: 'skill_lv > 0' in function `unknown'
[Error]: --- end failed assertion ----------------------------------------
[Error]: --- failed assertion --------------------------------------------
[Error]: d:\program files (x86)\hercules\src\map\skill.c:179: 'skill_lv > 0' in function `unknown'
[Error]: --- end failed assertion ----------------------------------------
[Error]: --- failed assertion --------------------------------------------
[Error]: d:\program files (x86)\hercules\src\map\skill.c:179: 'skill_lv > 0' in function `unknown'
[Error]: --- end failed assertion ----------------------------------------

Does it still happen after those 3 fixes?

zackdreaver

May 12 2015 02:31 AM

yep

N e s s

May 12 2015 03:23 AM

yes sir

Hadeszeus

May 13 2015 07:23 AM

Got this also after I update to latest rev. (Using Ubuntu 14.4)

Posted Image

Dastgir

May 13 2015 11:55 AM

Got this also after I update to latest rev. (Using Ubuntu 14.4)

As haru said, provide us the way to reproduce, so we can do a fix

zackdreaver

May 13 2015 12:52 PM

For:
[Error]: d:\program files (x86)\hercules\src\map\skill.c:179: 'skill_lv > 0' in function `unknown'
[Error]: --- end failed assertion ----------------------------------------

i used Cross impact, rolling cutter, sonic blow,
skill with castnodex ?

Frost

May 15 2015 04:40 AM

For:
[Error]: d:\program files (x86)\hercules\src\map\skill.c:179: 'skill_lv > 0' in function `unknown'
[Error]: --- end failed assertion ----------------------------------------

i used Cross impact, rolling cutter, sonic blow,
skill with castnodex ?

Same as mine, Sonic blow.

Frost

May 15 2015 11:32 PM

I add a new skill, and got this error also.

evilpuncker

May 19 2015 07:34 PM

seems like this is still happening: http://herc.ws/board...n-of-character/

kyeme

May 20 2015 12:06 AM

i can confirm too

Quazi

May 22 2015 06:02 AM

still getting this error on the latest revision...
i got this when i created a "Guild" and click on "Guild Skill"..
and i didn't add any source modifications..

--- failed assertion -------
..\src\map\skill.c:156: 'skill_lv > 0' in function 'unknown'
--- end failed assertion --------

--- failed assertion -------
..\src\map\skill.c:153: 'skill_lv > 0' in function 'unknown'
--- end failed assertion --------

Edited by Zratinel, 22 May 2015 - 06:03 AM.

Dastgir

changed status to: Confirmed