Firepillar And Traps
Warning! This is the old Hercules bugtracker archive, and may not reflect the current state of Hercules. The current bugtracker is on GitHub Issues.
Issue information
Issue ID
#144
Status
Fixed
Severity
None
Started
Hercules Elf Bot
Sep 29, 2007 0:52
Last Post
kyeme
Nov 4, 2014 15:48
Confirmation
Hercules Elf Bot - Sep 29, 2007 0:52
Originally posted by [b]Playtester[/b]
http://www.eathena.ws/board/index.php?autocom=bugtracker&showbug=144
Firepillar on eAthena right now is pretty useless and I really want to have it fixed.
Here some info how it should be:
- Firepillar is a trap
- it can be knocked around like other traps (with Sight Blaster for example)
- the number of hits to a mob is equal to the number of mobs hit (same as Land Mine and Claymore Trap)
- you can knock back one Firepillar on another
I know that I can set Firepillar to be a trap in the skill_db, but I want to ask if that automatically adds all the above mentioned features. If not, can someone edit the code accordingly?
What needs to be checked for is basically:
- make Firepillar a trap type skill (I can do that)
- if needed change the code so that Firepillar behaves exactly like other traps
- ensure all traps can be knocked around with Sightblaster / Arrow Shower, etc.
- ensure all traps do as many hits to each mob as total number of different mobs that are hit
- ensure that traps can be knocked back on the same cell and stack like that (even if they can't be placed on the same cell when used)
Also there's an issue with Remove Trap I think. Hunters are only supposed to remove their OWN traps, but I heard that right now they can remove opponent traps, too. This could lead to an exploit if hunters can remove fire pillars and get a trap. Please fit it so Hunters can only remove their own traps before adding the previous mentioned feature.
This post has been edited by Playtester: Dec 20 2007, 05:34 AM
http://www.eathena.ws/board/index.php?autocom=bugtracker&showbug=144
Firepillar on eAthena right now is pretty useless and I really want to have it fixed.
Here some info how it should be:
- Firepillar is a trap
- it can be knocked around like other traps (with Sight Blaster for example)
- the number of hits to a mob is equal to the number of mobs hit (same as Land Mine and Claymore Trap)
- you can knock back one Firepillar on another
I know that I can set Firepillar to be a trap in the skill_db, but I want to ask if that automatically adds all the above mentioned features. If not, can someone edit the code accordingly?
What needs to be checked for is basically:
- make Firepillar a trap type skill (I can do that)
- if needed change the code so that Firepillar behaves exactly like other traps
- ensure all traps can be knocked around with Sightblaster / Arrow Shower, etc.
- ensure all traps do as many hits to each mob as total number of different mobs that are hit
- ensure that traps can be knocked back on the same cell and stack like that (even if they can't be placed on the same cell when used)
Also there's an issue with Remove Trap I think. Hunters are only supposed to remove their OWN traps, but I heard that right now they can remove opponent traps, too. This could lead to an exploit if hunters can remove fire pillars and get a trap. Please fit it so Hunters can only remove their own traps before adding the previous mentioned feature.
This post has been edited by Playtester: Dec 20 2007, 05:34 AM
Hercules Elf Bot - Dec 7, 2012 6:53
Originally posted by [b]kyeme[/b]
I can confirm this official behaviour (for Fire Pillar)
Video:
http://www.youtube.com/watch?v=oevKybaVQjc
http://www.youtube.com/watch?v=rDvDh8gFIpo
I can confirm this official behaviour (for Fire Pillar)
Video:
http://www.youtube.com/watch?v=oevKybaVQjc
http://www.youtube.com/watch?v=rDvDh8gFIpo
This post has been edited by kyeme on Dec 7, 2012 6:56
Hercules Elf Bot - Dec 7, 2012 16:45
Originally posted by [b]MarkZD[/b]
Currently Firepillar is already a trap.
I'm just adding the fix to Sight Blaster which was not knocking-back traps.
[url="http://trac.rathena.org/changeset/17008/rathena"]17008[/url]
Currently Firepillar is already a trap.
I'm just adding the fix to Sight Blaster which was not knocking-back traps.
[url="http://trac.rathena.org/changeset/17008/rathena"]17008[/url]
This post has been edited by MarkZD on Dec 7, 2012 16:51
Hercules Elf Bot - Dec 7, 2012 18:08
Originally posted by [b]kyeme[/b]
Sight Blaster can damage (unlimited damage) the Trap and Icewall? in 17008. Please confirm thanks.
Sight Blaster can damage (unlimited damage) the Trap and Icewall? in 17008. Please confirm thanks.
This post has been edited by kyeme on Dec 7, 2012 18:11
Hercules Elf Bot - Dec 7, 2012 23:59
Originally posted by [b]MarkZD[/b]
[quote name='kyeme' timestamp='1354903686' post='16240']
Sight Blaster can damage (unlimited damage) the Trap and Icewall? in 17008. Please confirm thanks.
[/quote]
On the doddler's video I saw it can hit trap unlimited times without finish.
I just need confirmation about Icewall, etc.
[quote name='kyeme' timestamp='1354903686' post='16240']
Sight Blaster can damage (unlimited damage) the Trap and Icewall? in 17008. Please confirm thanks.
[/quote]
On the doddler's video I saw it can hit trap unlimited times without finish.
I just need confirmation about Icewall, etc.
This post has been edited by MarkZD on Dec 8, 2012 13:38
Hercules Elf Bot - Dec 8, 2012 6:59
Originally posted by [b]malufett[/b]
strange I can't hit fire pillar with sight blaster in iRO..any I'll try in kRO just need to have sight blaster..
[quote]I just need confirmation about Icewall, etc.[/quote]
i only does one hit or it ends immediately when hit..
strange I can't hit fire pillar with sight blaster in iRO..any I'll try in kRO just need to have sight blaster..
[quote]I just need confirmation about Icewall, etc.[/quote]
i only does one hit or it ends immediately when hit..
Hercules Elf Bot - Dec 8, 2012 7:35
Originally posted by [b]kyeme[/b]
[quote name='MarkZD' timestamp='1354924765' post='16241']
[quote name='kyeme' timestamp='1354903686' post='16240']Sight Blaster can damage (unlimited damage) the Trap and Icewall? in 17008. Please confirm thanks.[/quote] On the doodler's video I saw it can hit trap unlimited times without finish.I just need confirmation about Icewall, etc.
[/quote]
Doodler video is from kRO or iRO? sorry idont know hahah.
[quote name='malufett' timestamp='1354949985' post='16248']
strange I can't hit fire pillar with sight blaster in iRO..any I'll try in kRO just need to have sight blaster..[quote]I just need confirmation about Icewall, etc.[/quote]i only does one hit or it ends immediately when hit..
[/quote]
Thanks
[quote name='MarkZD' timestamp='1354924765' post='16241']
[quote name='kyeme' timestamp='1354903686' post='16240']Sight Blaster can damage (unlimited damage) the Trap and Icewall? in 17008. Please confirm thanks.[/quote] On the doodler's video I saw it can hit trap unlimited times without finish.I just need confirmation about Icewall, etc.
[/quote]
Doodler video is from kRO or iRO? sorry idont know hahah.
[quote name='malufett' timestamp='1354949985' post='16248']
strange I can't hit fire pillar with sight blaster in iRO..any I'll try in kRO just need to have sight blaster..
[quote]I just need confirmation about Icewall, etc.[/quote]i only does one hit or it ends immediately when hit.. [/quote]
Thanks
Hercules Elf Bot - Dec 8, 2012 12:29
Originally posted by [b]MarkZD[/b]
[quote name='malufett' timestamp='1354949985' post='16248']
strange I can't hit fire pillar with sight blaster in iRO..any I'll try in kRO just need to have sight blaster..[/quote]
Maybe it was changed, since videos are a little old.
http://www.youtube.com/watch?v=Fsv15eNKEhk
[quote name='kyeme' timestamp='1354952150' post='16249']
Doodler video is from kRO or iRO? sorry idont know hahah.
[/quote]
It could even be from jRO, Doddler had access to kRO sakray, kRO(and maybe jRO) he used to bring the news from there.
[quote name='malufett' timestamp='1354949985' post='16248']
i only does one hit or it ends immediately when hit..
[/quote]
I tried to test it on bRO, I didn't get confirmation as I don't have a wizard.
One just said it would end after the hit.
But looking for more sources, I found that in the time where it was supposed to work, it would not cancel against traps which doesn't have HP, as firepillar.
I'll commit it later.
But seems like it'll not be needed as apparently sightblaster doesn't knock-back traps anymore.
I'll wait for malufett's confirmation or any other good source, the one which comes first.
[quote name='malufett' timestamp='1354949985' post='16248']
strange I can't hit fire pillar with sight blaster in iRO..any I'll try in kRO just need to have sight blaster..
[/quote]Maybe it was changed, since videos are a little old.
http://www.youtube.com/watch?v=Fsv15eNKEhk
[quote name='kyeme' timestamp='1354952150' post='16249']
Doodler video is from kRO or iRO? sorry idont know hahah.
[/quote]
It could even be from jRO, Doddler had access to kRO sakray, kRO(and maybe jRO) he used to bring the news from there.
[quote name='malufett' timestamp='1354949985' post='16248']
i only does one hit or it ends immediately when hit..
[/quote]
I tried to test it on bRO, I didn't get confirmation as I don't have a wizard.
One just said it would end after the hit.
But looking for more sources, I found that in the time where it was supposed to work, it would not cancel against traps which doesn't have HP, as firepillar.
I'll commit it later.
But seems like it'll not be needed as apparently sightblaster doesn't knock-back traps anymore.
I'll wait for malufett's confirmation or any other good source, the one which comes first.
This post has been edited by MarkZD on Dec 8, 2012 13:42
Hercules Elf Bot - Dec 10, 2012 19:56
Originally posted by [b]xaxixi[/b]
In bRO, sight blaster can't hit Fire Pillar and can hit [color=#282828][font=helvetica, arial, sans-serif][size=3]unlimited times the traps[/size][/font][/color].
In bRO, sight blaster can't hit Fire Pillar and can hit [color=#282828][font=helvetica, arial, sans-serif][size=3]unlimited times the traps[/size][/font][/color].
This post has been edited by xaxixi on Dec 10, 2012 19:57
Hercules Elf Bot - Dec 10, 2012 20:22
Originally posted by [b]MarkZD[/b]
[quote name='xaxixi' timestamp='1355169391' post='16295']
In bRO, sight blaster can't hit Fire Pillar and can hit [color=#282828][font=helvetica, arial, sans-serif][size=3]unlimited times the traps[/size][/font][/color].
[/quote]
So it seems the case is not around Sightblaster directly, seems like Fire Pillar is an exception.
Probably it can't be knocked back with other skills too, as Magnum Break.
[quote name='xaxixi' timestamp='1355169391' post='16295']
In bRO, sight blaster can't hit Fire Pillar and can hit [color=#282828][font=helvetica, arial, sans-serif][size=3]unlimited times the traps[/size][/font][/color].
[/quote]
So it seems the case is not around Sightblaster directly, seems like Fire Pillar is an exception.
Probably it can't be knocked back with other skills too, as Magnum Break.
This post has been edited by MarkZD on Dec 10, 2012 20:23
Hercules Elf Bot - Dec 11, 2012 2:23
Originally posted by [b]xaxixi[/b]
Yes, Fire Pillar can't knocked back with Magnum Break or Sightrasher.
Yes, Fire Pillar can't knocked back with Magnum Break or Sightrasher.
Ind - Jan 30, 2013 19:21
when being knocked back the fire pillar animation isnt updated, too.
malufett - Jan 31, 2013 5:25
it seems that this feature is only applied in pre_RE..as I tested in kRO it cannot be knock back...
:meow:
:meow:
kyeme - Jan 31, 2013 6:29
Yes , this is for pre-renewal behavior. :)
kyeme - Mar 8, 2013 7:29
<span style="font-family: times new roman" ,="" times,="" serif'="">[size=4][b]In latest revision [color=rgb(51,51,51)]Sight Blast doesnt hit ice wall and fire pillar.[/color][/b]
[color=rgb(40,40,40)]Here again the info..[/color]
[color=rgb(40,40,40)]Pre-Renewal Official:[/color]
[color=rgb(51,51,51)]Sight blast can hit fire pillar (Unlimited)[/color]
[color=rgb(51,51,51)]Sight blast can hit Icewall [b]but not unlimited[/b] [/color][color=rgb(51,51,51)](Source exp. in pRO pre-renewal, Im a Wizard since 2006 - 2010)[/color]
[color=rgb(51,51,51)]Renewal Official:[/color]
[color=rgb(51,51,51)]Sight blast doesnt hit firepillar anymore[/color][color=rgb(51,51,51)](Source pRO Sakray)[/color]
[color=rgb(51,51,51)]Sight blast can hit Icewall [b]but not unlimited[/b] (Source pRO Sakray)[/color]
[color=rgb(51,51,51)]About trap, sorry i dont have a source for now..[/color][color=rgb(40,40,40)] [/color][/size]
[color=rgb(40,40,40)]Here again the info..[/color]
[color=rgb(40,40,40)]Pre-Renewal Official:[/color]
[color=rgb(51,51,51)]Sight blast can hit fire pillar (Unlimited)[/color]
[color=rgb(51,51,51)]Sight blast can hit Icewall [b]but not unlimited[/b] [/color][color=rgb(51,51,51)](Source exp. in pRO pre-renewal, Im a Wizard since 2006 - 2010)[/color]
[color=rgb(51,51,51)]Renewal Official:[/color]
[color=rgb(51,51,51)]Sight blast doesnt hit firepillar anymore[/color][color=rgb(51,51,51)](Source pRO Sakray)[/color]
[color=rgb(51,51,51)]Sight blast can hit Icewall [b]but not unlimited[/b] (Source pRO Sakray)[/color]
[color=rgb(51,51,51)]About trap, sorry i dont have a source for now..[/color][color=rgb(40,40,40)] [/color][/size]
This post has been edited by kyeme on Aug 14, 2013 18:23
kyeme - Aug 14, 2013 18:26
Bump ~ [size=4][color=rgb(51,51,51)]<span style="font-family: lucida grande" ,="" tahoma,="" verdana,="" arial,="" sans-serif'="">the code was broken in the latest revison[/color][/size]
This post has been edited by kyeme on Nov 19, 2013 15:13
PcNy - Nov 19, 2013 14:21
This is exactly what I'm looking for. In eathna and rathena, Traps and Fire Pillar can be knocked on monsters and do many hits according to monster numbers.
Playtester - Oct 25, 2014 11:55
Most fixed on rAthena in: [url="https://github.com/rathena/rathena/commit/b88e95381d6a7ddeb3a9a510edc2029bece142ca#diff-d96b6365b4bdad78139e676d6e7e3295R7170"]https://github.com/rathena/rathena/commit/b88e95381d6a7ddeb3a9a510edc2029bece142ca#diff-d96b6365b4bdad78139e676d6e7e3295R7170[/url]
Feel free to merge. :-)
Feel free to merge. :-)
Playtester - Oct 28, 2014 13:23
Fire Pillar fixed for renewal on rA too: [url="https://github.com/rathena/rathena/commit/4311630e8f463393817c36ba294295920c06a7fa"]https://github.com/rathena/rathena/commit/4311630e8f463393817c36ba294295920c06a7fa[/url]
kyeme - Nov 4, 2014 15:48
Thank you master Playtester