Issue information

Issue ID
#3275
Status
New
Severity
None
Started
Hercules Elf Bot
Jun 20, 2009 15:51
Last Post
Hercules Elf Bot
Jun 20, 2009 15:51
Confirmation
N/A

Hercules Elf Bot - Jun 20, 2009 15:51

Originally posted by [b]theultramage[/b]
http://www.eathena.ws/board/index.php?autocom=bugtracker&showbug=3275

There are several occurrences of "case CH_TIGERFIST" in the combo/asura code.
I checked irowiki, and the only relationship Glacier Fist has with Asura is that it's a part of a possible chain. However, you cannot fire off asura straight from Glacier fist, so the following code either produces a bug where you can use asura after Glacier fist, or some code hinders these cases, turning them into dead code. I suggest examining the execution paths and seeing what impact these cases have.

skill.c, 8257
CODE
    case MO_EXTREMITYFIST:
        ...
        if( sc && sc->data[SC_COMBO] )
        {
            switch(sc->data[SC_COMBO]->val1) {
                case MO_COMBOFINISH:
                case CH_TIGERFIST:
                case CH_CHAINCRUSH:
                    break;
                default:
                    return 0;
            }

status.c, 5671
CODE
                case MO_COMBOFINISH:
                case CH_TIGERFIST:
                case CH_CHAINCRUSH:
                    if( sd )
                    {
                        sd->state.combo = 1;
                        clif_skillinfoblock(sd);
                    }

unit.c, 1004
CODE
    case MO_EXTREMITYFIST:
        if (sc && sc->data[SC_COMBO] &&
           (sc->data[SC_COMBO]->val1 == MO_COMBOFINISH ||
            sc->data[SC_COMBO]->val1 == CH_TIGERFIST ||
            sc->data[SC_COMBO]->val1 == CH_CHAINCRUSH))
            casttime = 0;