Equip Set Bonus + ImproveConc = Wrong stats

Originally posted by [b]Sotto[/b]
http://www.eathena.ws/board/index.php?autocom=bugtracker&showbug=4666

(note: while I'm using agi as an example below, the handling of bonus stats received from equipment sets concerns all stats, of course)


There's an observable difference of 1 point in the calculated AGI bonus value of a fully equipped sniper with activated Improve Concentration in comparison to the official servers. The reason, it seems, is that the AGI bonus of the Pantie+Undershirt equipment combo is treated like equipment AGI, instead of equipment set AGI.

It seems to be working like this on eAthena:
(floor((BaseAGI + JobBonusAGI + EquipAGI + EquipSetAGI)*ImpConcBonus)) + CardAgi + TrueSightAGI + AgiUpAGI + FoodAGI

While on official servers, the formula in the sniper's case seems to work like this:
(floor((BaseAGI + JobBonusAGI + EquipAGI)*ImpConcBonus)) + EquipSetAGI + CardAgi + TrueSightAGI + AgiUpAGI + FoodAGI

So while Agi from equipment should be influenced by Improve Concentration, Agi from equipment set effects should not. I noticed that when putting on the Undershirt in addition to the pantie, if Improve Concentration was activated, Agi went up 6 points instead of the set's alleged 5, so it seems eAthena is adding equipment set bonus stats before applying the Improve Concentration Bonus instead of adding it as a flat bonus after.