Hercules Elf Bot - Mar 14, 2012 15:52
Originally posted by [b]Wildcard[/b]
I'm talking about the blue star buff icon currently used to indicate if you are under the effect of deludge, volcano or violent gale.
While working on status packet code, I noticed some striking differences in *Athena behaviour when compared to official servers.
*Athena:[list]
[*]any player standing on a tile affected by one of the three land skills receives the buff icon
[*]leaving the tile or removing the land effect on it removes the icon
[*]the buff icon has no time bar
[/list]
official servers:[list]
[*]only the owner of the land skill receives the buff icon upon casting one of the three skills
[*]other players don't receive an icon for standing on an affected tile
[*]the icon does not disappear when leaving the area
[*]in fact, it does not disappear even if you change maps(!)
[*]it also does not disappear if all affected land tiles are removed (other player's land protector, ganbantein)
[*]it is only removed upon death, when the 5 minute timer runs out or the player himself casts land protector
[*]when casting a second land skill, the timer is refreshed, but no status end packet is sent
[*]the duration of the buff icon is fixed to 5 minutes, even though the duration of the skills can be less than that
[/list]
Clearly, the official implementation is rather.. broken. Loathe as I am to remove the current rAthena behaviour and replace it with something subjectively worse, official is official? What do you guys think?
Hercules Elf Bot - Mar 14, 2012 15:58
Originally posted by [b]xazax[/b]
I think we should not implement bugs.
And it is very obvious to me, it is buggy on official servers
[quote].
16:53 Wildcard opinions welcome: http://rathena.org/board/tracker/issue-5446-sage-land-skill-buff-icon-si-landendow/
16:57 xazax|work IMO
16:57 --- xazax|work is back
16:57 xazax|work we should not implement bugs on purpuse
16:58 Wildcard well, my concern is more of the sort "we have a "feature" that official servers don't have at all
16:58 xazax|work well
16:58 Wildcard namely, a clientside indicator that tells you if you are on a land skill or not, even with effects off
16:58 xazax|work I think this is the most logical behaviour
16:59 Wildcard I agree, it's neat, but aegis doesn't seem to have it
16:59 xazax|work the worst thing we should/can make is
16:59 xazax|work to add a configuration for that
17:01 Wildcard it's too minor for that
17:01 xazax|work usually it is good to aviod custom features, because they cause bloat, or make big differences compared to official experience
17:01 xazax|work I think this does not make any bloat nor change the experience greatly
17:01 xazax|work but of course that is only my opinion, probably others will disagree
[/quote]
This post has been edited by
xazax
on Mar 14, 2012 16:04
Hercules Elf Bot - Mar 14, 2012 16:41
Originally posted by [b]Rytech[/b]
You could release a experimental patch. Does rAthena have a patch area in the SVN?
Hercules Elf Bot - Mar 14, 2012 20:11
Originally posted by [b]Gepard[/b]
From the description, I'd say that Aegis meaning of the icon is different from rAthena's. In Aegis it looks like it's supposed to be an indicator for the [b]caster only[/b] on how long is the effect in place. It is not meant to be an indicator of [b]stepping into[/b] the AoE.
So I'd say, make it official by displaying the status icon to the caster only, and removing it when the skill duration runs out. But don't implement a bug (not removing the icon when expected).
Hercules Elf Bot - Mar 16, 2012 22:43
Originally posted by [b]Ind[/b]
I'm with xazax, I do not think we should implement bugs solely to mimic "official behavior".
[quote name='Gepard' timestamp='1331755889' post='7576']
From the description, I'd say that Aegis meaning of the icon is different from rAthena's. In Aegis it looks like it's supposed to be an indicator for the [b]caster only[/b] on how long is the effect in place. It is not meant to be an indicator of [b]stepping into[/b] the AoE.So I'd say, make it official by displaying the status icon to the caster only, and removing it when the skill duration runs out. But don't implement a bug (not removing the icon when expected).
[/quote]
the icon was present way before sc timers were displayed in the client.
Hercules Elf Bot - Mar 17, 2012 15:17
Originally posted by [b]Poseid0n[/b]
I don't understand ... why would you implement un bug, while there is plenty of bug on the other skills which are waiting since a long ?