Issue information

Issue ID
#5587
Status
Fixed
Severity
Fair
Started
Hercules Elf Bot
Apr 20, 2012 6:33
Last Post
Hercules Elf Bot
Jul 24, 2012 13:39
Confirmation
N/A

Hercules Elf Bot - Apr 20, 2012 6:33

Originally posted by [b]Kenpachi[/b]
`name` column in `char` table should be unique because 3rd party tools like control panels could produce errors.

Hercules Elf Bot - Jul 24, 2012 10:31

Originally posted by [b]Kenpachi[/b]
Fixed in [rev=16490].

Hercules Elf Bot - Jul 24, 2012 12:18

Originally posted by [b]Lemongrass[/b]
I thought *Athena isn't going to apply according to 3rd party tools rather they have to apply to *Athena.
Anyways if you're already at fixing the data structures in SQL would you mind adding foreign keys to the tables?

Hercules Elf Bot - Jul 24, 2012 12:24

Originally posted by [b]Kenpachi[/b]
Well, since someone told me that a nooby 3rd party tool doesn't check for duplicate names and creates them I was forced to add this to the DB layout. ^_^

We do have many foreign keys already. For example:
- `char`.`account_id`
- `char`.`party_id`
- `char`.`guild_id`
- many more

Just because they aren't connected hard in the DB layout it doesn't mean they are no foreign keys... but I'll discuss this with the other developers (again ^^).

Hercules Elf Bot - Jul 24, 2012 13:39

Originally posted by [b]Lemongrass[/b]
I know that those are foreign keys. But in truth or as they are they are no real foreign keys, which means there is no consistency check.

Additionally some usage of the "ON DELETE CASCADE" feature would be very nice. It would give administrators a huge benefit during the cleaning of their database(s).