Amplify Magic Power not showing information in the correct moment

Originally posted by [b]emong[/b]
I've also experienced this problem..

attached in this reply is the screenshots of the said bug/glitch..

Originally posted by [b]ngek202[/b]
Made a video., notice this before:
[url="http://www.youtube.com/watch?v=T6jxn2ogloA"]http://www.youtube.com/watch?v=T6jxn2ogloA[/url]

Originally posted by [b]xRaisen[/b]
Its working though its not displaying.

Originally posted by [b]Vali[/b]
[quote name='xRaisen' timestamp='1335711796' post='8746']
Its working though its not displaying.
[/quote]

That is what i tried to say in my first post, yes.

Originally posted by [b]Wildcard[/b]
True, I neglected to test this particular aspect when rewriting the skill. It turns out official servers don't display a matk bonus at all, which is a bit ugly to implement with the current code. Will most likely be done when someone gets around to revisiting mATK.

Originally posted by [b]karazu[/b]
confirmed it in my server

Originally posted by [b]malufett[/b]
I got a question...

since the status window is change therefore we can't see anymore min and max matk only the status atk that is why we can't see the changes..

so now if it change on the status window therefore it boost the status matk???

we need confirmation/more information for this....

Originally posted by [b]RaGERO[/b]
I have this problem on my server too.

High Wiz uses Amplify skill, checks status window and it doesn't display the correct additional matk, High wiz casted storm gust, now the status window displays the correct matk with amplify.

Using client 2010-07-30.

Originally posted by [b]malufett[/b]
[size=4]I check in official [color=#282828][font=helvetica, arial, sans-serif]it doesn't display in the status window since it only modify matk and not status matk..[/font][/color][/size]

Originally posted by [b]MarkZD[/b]
[quote name='malufett' timestamp='1340972816' post='11380']
[size=4]I check in official [color=#282828][font=helvetica, arial, sans-serif]it doesn't display in the status window since it only modify matk and not status matk..[/font][/color][/size]
[/quote]
Wildcard, already said it just some posts above.

I think you didn't get this report, it's saying it's beeing displayed after you cast some magic, after AMP.

I tested in 16355 and it's still displaying after you casta magical attack after AMP.

Originally posted by [b]malufett[/b]
oppps...sorry my mistake..=p

ok I found out where is the problem...because ATM the status matk is share with min matk variable...
but once I'm done to recode the RE matk system this will be fixed soon...

but here is a temporary fix however this is not the right way to do it..


[CODE]
if (sc && sc->count && sc->data[SC_MAGICPOWER])
{
if (sc->data[SC_MAGICPOWER]->val4)
{
status_change_end(bl, SC_MAGICPOWER, INVALID_TIMER);
}
else
{
sc->data[SC_MAGICPOWER]->val4 = 1;
-status_calc_bl(bl, status_sc2scb_flag(SC_MAGICPOWER));
}
+ status_calc_bl(bl, status_sc2scb_flag(SC_MAGICPOWER))
}[/CODE]

Originally posted by [b]Vali[/b]
2 months bump.

Originally posted by [b]cataclysmro[/b]
any news?

Originally posted by [b]Lighta[/b]
if you do that malufet the bonus won't be show anyway as calc_matk expecting val4 to be true to make the change :
if(sc->data[SC_MAGICPOWER] && sc->data[SC_MAGICPOWER]->val4)

So basically you asking to reparse calc_matk without making anychange in it, plus if it was true you'll have the bonus right away (like just after amp), instead right now you have the status after AMP but get the bonus just after caster a valid skill.
In short that workarround wont work and would break that fonction purpose if so :

For the display info well there directly link to status point so there nothing you can do about it or you may want to add some exception in clif_updatestatus but that would be ugly.

Originally posted by [b]CairoLee[/b]
[color=#282828][font=helvetica, arial, sans-serif][size=3]I have this problem on my server too. [/size][/font][/color]

[color=#282828][font=helvetica, arial, sans-serif][size=3]any news?[/size][/font][/color]

Originally posted by [b]Lighta[/b]
ok I'll reexplain that in a easier way.
-right now status windlay display real matk (with status and such)
-AMP matk bonus is only active while val4 is true. (like when casting skill)
-Once skill is ended amp status is ended (so amp bonus disapear)

Now you have 2 choice either you do a small hack to display amp bonus even if it's not active yet. ->clif.c
or you add the bonus right after the status is casted->2

for the choice 2 and it's more or less what malufett was proposing,
(go in status.c and found "if(sc->data[SC_MAGICPOWER] && sc->data[SC_MAGICPOWER]->val4)", and replace with "if(sc->data[SC_MAGICPOWER]" )
now your bonus will be apply once the status is finished, you have the good display but you kinda broke hte purpose of the function..

Originally posted by [b]malufett[/b]
or better to recode the matk system..ATM I already had the RE MATK(including the fix w/ this) 100% working with PVP however matk with mobs is still unknown and I'm still in a test to determine the formula..

Originally posted by [b]CairoLee[/b]
[quote]
[color=#282828][font=helvetica, arial, sans-serif][size=3]go in status.c and found "if(sc->data[SC_MAGICPOWER] && sc->data[SC_MAGICPOWER]->val4)", and replace with "if(sc->data[SC_MAGICPOWER]" [/size][/font][/color]
[/quote]

I try to use this solution,but the when i do the test,the mapserver was carsh. the msg is :

[b][Error]: Server received crash signal! Attempting to save all online characters![/b]

===============================================

Then I try the another solution, by myself (i am a super newbie)

in [color=#282828][font=helvetica, arial, sans-serif][size=3]status.c , the [/size][/font][/color]status_calc_bl_ function:
[list]
[*]found "if(b_status.matk_max != status->matk_max)" and replace whit "if((b_status.matk_max != status->matk_max) && !(status_get_sc(bl)->data[SC_MAGICPOWER]))"
[*]found "if(b_status.matk_min != status->matk_min)" and replace whit "if((b_status.matk_max != status->matk_max) && !(status_get_sc(bl)->data[SC_MAGICPOWER]))"
[/list]
i do the test, it's worked.

but !! when you in the [color=#282828][font=helvetica, arial, sans-serif][size=3]SC_MAGICPOWER ‘s [/size][/font][/color]Duration,try to uses something will change MATK in the status panel,then the status panel will have a error display..

Originally posted by [b]Arcenciel[/b]
Confirmed. Just noticed this today.

Originally posted by [b]malufett[/b]
Fixed @ [rev='16981']

Originally posted by [b]kyeme[/b]
Still not fixed Sir..

Originally posted by [b]malufett[/b]
[quote]Still not fixed Sir..[/quote]
did you properly update files??

because there is no way to happen again since a change the way it holds variable..

[CODE]
#define pc_leftside_matk(sd) (status_base_matk(status_get_status_data(&(sd)->bl), (sd)->status.base_level))
#define pc_rightside_matk(sd) ((sd)->battle_status.rhw.matk+(sd)->bonus.ematk) [/CODE]

Originally posted by [b]kyeme[/b]
Yes, hmm now i know, only in Renewal mode this fix? Because i try in Renewal Mode its working. But in pre-renewal its not working.

Originally posted by [b]malufett[/b]
omg...your right..when I look it again they vary from eathena..ok working on it..

Originally posted by [b]Beret[/b]
is not giving bonus of 50% this is right ?

Originally posted by [b]malufett[/b]
[quote]is not giving bonus of 50% this is right ?[/quote]
it's working fine and it's skill level dependent..


Fixed @ [rev='16988']
-tskk..I hate that auto complete..it ruins my trac log msg..

Originally posted by [b]emong[/b]
During the follow-up fix, the status doesn't update.. even after casting..

Originally posted by [b]malufett[/b]
[quote]During the follow-up fix, the status doesn't update.. even after casting..[/quote]
RE or PRE?

Originally posted by [b]kyeme[/b]
[quote name='malufett' timestamp='1340972816' post='11380']
[size=4]I check in official [color=#282828][font=helvetica, arial, sans-serif]it doesn't display in the status window since it only modify matk and not status matk..[/font][/color][/size]
[/quote]
Sir this behavior s not working in the latest rev. Pre-Renewal

Originally posted by [b]MarkZD[/b]
[quote name='kyeme' timestamp='1354329663' post='16068']
[quote name='malufett' timestamp='1340972816' post='11380'][size=4]I check in official [color=#282828][font=helvetica, arial, sans-serif]it doesn't display in the status window since it only modify matk and not status matk..[/font][/color][/size][/quote]Sir this behavior s not working in the latest rev. Pre-Renewal
[/quote]
This is just in Renewal.


Pre-renewal: matk change show up.
Renewal: matk change doesn't show up.

Originally posted by [b]kyeme[/b]
[quote name='MarkZD' timestamp='1354341224' post='16071']
[quote name='kyeme' timestamp='1354329663' post='16068'][quote name='malufett' timestamp='1340972816' post='11380'][size=4]I check in official [color=#282828][font=helvetica, arial, sans-serif]it doesn't display in the status window since it only modify matk and not status matk..[/font][/color][/size][/quote]Sir this behavior s not working in the latest rev. Pre-Renewal[/quote]This is just in Renewal.Pre-renewal: matk change show up.Renewal: matk change doesn't show up.
[/quote]
But I'm playing official server (pre-renewal 2010..) Magic Power matk is not showing in ALT Q