Issue information

Issue ID
#5808
Status
New
Severity
Fair
Started
Hercules Elf Bot
May 24, 2012 15:58
Last Post
Hercules Elf Bot
Jun 28, 2012 16:58
Confirmation
N/A

Hercules Elf Bot - May 24, 2012 15:58

Originally posted by [b]EvilPuncker[/b]
I'm not able to test it on any official RO, but shouldn't it turn off the speed and atk bonus when you turn out the cart? because actually you can use GN_CARTBOOST then take your cart out but still have the bonuses on

This post has been edited by EvilPuncker on May 24, 2012 15:58

Hercules Elf Bot - Jun 24, 2012 1:34

Originally posted by [b]Ind[/b]
Fixed in [rev=16339]

Hercules Elf Bot - Jun 24, 2012 3:05

Originally posted by [b]exneval[/b]
umm... in 16339
the genetic cartboost still have the bonuses while i take the cart off

This post has been edited by exneval on Jun 24, 2012 3:28

Hercules Elf Bot - Jun 24, 2012 3:30

Originally posted by [b]Ind[/b]
thank you for letting me know i'll check. whats your client version?

Hercules Elf Bot - Jun 24, 2012 4:05

Originally posted by [b]exneval[/b]
thanks,
my client is 2011 11 22a

Hercules Elf Bot - Jun 24, 2012 7:39

Originally posted by [b]EvilPuncker[/b]
it is removing the status icon and the speed bonus.

This post has been edited by EvilPuncker on Jun 25, 2012 18:42

Hercules Elf Bot - Jun 24, 2012 8:05

Originally posted by [b]exneval[/b]
[s][s]oh the status is removed?
maybe i must check it again[/s][/s]

@evil
what client do you use?

[s]i relized that in 20111122, my ALT+Q not show the Off word and edit box, but you still can click it,
is that be the problem?[/s]

changed client into 20111214 not fix the issue, maybe the src?
this is my pc.c

[spoiler][CODE]
/*==========================================
* ƒJ?ƒgÝ’è
*------------------------------------------*/
int pc_setcart(struct map_session_data *sd,int type) {
#ifndef NEW_CARTS
int cart[6] = {0x0000,OPTION_CART1,OPTION_CART2,OPTION_CART3,OPTION_CART4,OPTION_CART5};
int option;
#endif
nullpo_ret(sd);
if( type < 0 || type > MAX_CARTS )
return 1;// Never trust the values sent by the client! [Skotlex]
if( pc_checkskill(sd,MC_PUSHCART) <= 0 )
return 1;// Push cart is required

if( type == 0 && pc_iscarton(sd) )
status_change_end(&sd->bl,SC_GN_CARTBOOST,INVALID_TIMER);
#ifdef NEW_CARTS

switch( type ) {
case 0:
if( !sd->sc.data[SC_PUSH_CART] )
return 0;
status_change_end(&sd->bl,SC_PUSH_CART,INVALID_TIMER);
clif_clearcart(sd->fd);
break;
default:/* everything else is an allowed ID so we can move on */
if( !sd->sc.data[SC_PUSH_CART] ) /* first time, so fill cart data */
clif_cartlist(sd);
clif_updatestatus(sd, SP_CARTINFO);
sc_start(&sd->bl, SC_PUSH_CART, 100, type, 0);
clif_status_load_notick(&sd->bl, SI_ON_PUSH_CART, 2 , type, 0, 0);
break;
}

if(pc_checkskill(sd, MC_PUSHCART) < 10)
status_calc_pc(sd,0); //Recalc speed penalty.
#else
// Update option
option = sd->sc.option;
option &= ~OPTION_CART;// clear cart bits
option |= cart[type]; // set cart
pc_setoption(sd, option);
#endif

return 0;
}
[/CODE][/spoiler]

This post has been edited by exneval on Jun 24, 2012 8:41

Hercules Elf Bot - Jun 24, 2012 8:42

Originally posted by [b]EvilPuncker[/b]
2012-04-10aRagexeRE

Hercules Elf Bot - Jun 28, 2012 10:44

Originally posted by [b]malufett[/b]
in official even if you remove your cart the effect still stays...

Hercules Elf Bot - Jun 28, 2012 11:16

Originally posted by [b]EvilPuncker[/b]
that is weird then... xd

Hercules Elf Bot - Jun 28, 2012 11:19

Originally posted by [b]malufett[/b]
well..thats how Gravity thinks...hehehe

Hercules Elf Bot - Jun 28, 2012 16:58

Originally posted by [b]EvilPuncker[/b]
then set it to working as intended and remove the change that Ind did (btw i'll still use that code in my server xd)