Wrong script
Warning! This is the old Hercules bugtracker archive, and may not reflect the current state of Hercules. The current bugtracker is on GitHub Issues.
Issue information
Issue ID
#6001
Status
Fixed
Severity
None
Started
Hercules Elf Bot
Jun 13, 2012 2:35
Last Post
Hercules Elf Bot
Jun 23, 2012 9:21
Confirmation
Hercules Elf Bot - Jun 13, 2012 2:35
Originally posted by [b]hendra814[/b]
item 18600 item description table
[quote]18600#
a cute beret that feels cat is wearing it because of its ear decoration.
ATK + 5%.
[color=#ff0000]If it refined over 5, will give 1% bonus on physical attack to "Human" type and receive less damage from "Human" type.[/color]
[color=#ff0000](This bonus would work up to +12, 7%)[/color]
Class : ^777777Headgear^000000 Defense : ^7777775^000000
Location : ^777777Upper ^000000Weight : ^77777730^000000
Required Lv. : ^7777771^000000
Applicable Job : ^777777 Every Job^000000
#[/quote]
and the script
[quote]18600,Cat_Ear_Beret,Cat Ear Beret,5,20,,100,,5,,0,0xFFFFFFFF,7,2,256,,0,1,761,{ [color=#ff0000]if(getrefine() > 5 && getrefine() <= 12) { bonus2 bAddRace,RC_DemiHuman,2*(getrefine() - 4); bonus2 bSubRace,RC_DemiHuman,2*(getrefine() - 4); }},{},{}[/color][/quote]
if refine to +5 will not receive bonus point
but if look into the script, item will give 2 point bonus.
and for +12 will give 16 point bonus
I thinks the script suppose to be like this
[quote]18600,Cat_Ear_Beret,Cat Ear Beret,5,20,,100,,5,,0,0xFFFFFFFF,7,2,256,,0,1,761,{ if(getrefine() > 5 && getrefine() <= 12) { bonus2 bAddRace,RC_DemiHuman,1*(getrefine() - 5); bonus2 bSubRace,RC_DemiHuman,1*(getrefine() - 5); }},{},{}[/quote]
item 18600 item description table
[quote]18600#
a cute beret that feels cat is wearing it because of its ear decoration.
ATK + 5%.
[color=#ff0000]If it refined over 5, will give 1% bonus on physical attack to "Human" type and receive less damage from "Human" type.[/color]
[color=#ff0000](This bonus would work up to +12, 7%)[/color]
Class : ^777777Headgear^000000 Defense : ^7777775^000000
Location : ^777777Upper ^000000Weight : ^77777730^000000
Required Lv. : ^7777771^000000
Applicable Job : ^777777 Every Job^000000
#[/quote]
and the script
[quote]18600,Cat_Ear_Beret,Cat Ear Beret,5,20,,100,,5,,0,0xFFFFFFFF,7,2,256,,0,1,761,{ [color=#ff0000]if(getrefine() > 5 && getrefine() <= 12) { bonus2 bAddRace,RC_DemiHuman,2*(getrefine() - 4); bonus2 bSubRace,RC_DemiHuman,2*(getrefine() - 4); }},{},{}[/color][/quote]
if refine to +5 will not receive bonus point
but if look into the script, item will give 2 point bonus.
and for +12 will give 16 point bonus
I thinks the script suppose to be like this
[quote]18600,Cat_Ear_Beret,Cat Ear Beret,5,20,,100,,5,,0,0xFFFFFFFF,7,2,256,,0,1,761,{ if(getrefine() > 5 && getrefine() <= 12) { bonus2 bAddRace,RC_DemiHuman,1*(getrefine() - 5); bonus2 bSubRace,RC_DemiHuman,1*(getrefine() - 5); }},{},{}[/quote]
Hercules Elf Bot - Jun 13, 2012 2:43
Originally posted by [b]hendra814[/b]
for item 18597
[quote]18597#
...
Aspd +3%, Critical +3
[color=#ff0000]If refined to +7 or higher, Aspd +2% and Critical +2.[/color]
[color=#ff0000]If refined to +9 or higher, Aspd +2% and Critical +2.[/color]
Class : ^777777Headgear^000000
Defense : ^77777710^000000
Location : ^777777Upper^000000
Weight : ^77777740^000000
Required Level : ^77777770^000000
Applicable Job :^777777 Every Job^000000
#[/quote]
item script
[quote]18597,Mercury_Riser,Mercury Riser,5,40,,200,,10,,1,0xFFFFFFFF,7,2,256,,0,,759,{ bonus bAspdRate,3; bonus bCritical,3; [color=#ff0000]if(getrefine() == 7 || getrefine() == 8) { bonus bAspdRate,2; bonus bCritical,2; } if(getrefine() >= 9) { bonus bAspdRate,2; bonus bCritical,2; }},{},{}[/color][/quote]
For refine +7 and +8 will recieve 2 point for aspd and critical
and refine +9 or higher recieve 2 point more, is this mean player will recieve 4 point or same with refine +7, just recieve 2 point for upgrade the item.
for item 18597
[quote]18597#
...
Aspd +3%, Critical +3
[color=#ff0000]If refined to +7 or higher, Aspd +2% and Critical +2.[/color]
[color=#ff0000]If refined to +9 or higher, Aspd +2% and Critical +2.[/color]
Class : ^777777Headgear^000000
Defense : ^77777710^000000
Location : ^777777Upper^000000
Weight : ^77777740^000000
Required Level : ^77777770^000000
Applicable Job :^777777 Every Job^000000
#[/quote]
item script
[quote]18597,Mercury_Riser,Mercury Riser,5,40,,200,,10,,1,0xFFFFFFFF,7,2,256,,0,,759,{ bonus bAspdRate,3; bonus bCritical,3; [color=#ff0000]if(getrefine() == 7 || getrefine() == 8) { bonus bAspdRate,2; bonus bCritical,2; } if(getrefine() >= 9) { bonus bAspdRate,2; bonus bCritical,2; }},{},{}[/color][/quote]
For refine +7 and +8 will recieve 2 point for aspd and critical
and refine +9 or higher recieve 2 point more, is this mean player will recieve 4 point or same with refine +7, just recieve 2 point for upgrade the item.
Hercules Elf Bot - Jun 13, 2012 3:22
Originally posted by [b]Flaid[/b]
Fixed in [url="http://sourceforge.net/apps/trac/rathena/changeset/16284/"]r16284[/url] and [url="http://sourceforge.net/apps/trac/rathena/changeset/16285/"]r16285[/url]
Fixed in [url="http://sourceforge.net/apps/trac/rathena/changeset/16284/"]r16284[/url] and [url="http://sourceforge.net/apps/trac/rathena/changeset/16285/"]r16285[/url]
This post has been edited by Flaid on Jun 13, 2012 3:41
Hercules Elf Bot - Jun 13, 2012 3:37
Originally posted by [b]hendra814[/b]
will be simple if the script like this
[quote][color=#282828][font=helvetica, arial, sans-serif][size=3][background=rgb(247, 247, 247)]18597,Mercury_Riser,Mercury Riser,5,40,,200,,10,,1,0xFFFFFFFF,7,2,256,,0,,759,{ bonus bAspdRate,3; bonus bCritical,3; [/background][/size][/font][/color][color=#FF0000][font=helvetica, arial, sans-serif][size=3][background=rgb(247, 247, 247)]if(getrefine() >= 7 ) { bonus bAspdRate,2; bonus bCritical,2; }},{},{}[/background][/size][/font][/color][/quote]
i think this is will be same efect
will be simple if the script like this
[quote][color=#282828][font=helvetica, arial, sans-serif][size=3][background=rgb(247, 247, 247)]18597,Mercury_Riser,Mercury Riser,5,40,,200,,10,,1,0xFFFFFFFF,7,2,256,,0,,759,{ bonus bAspdRate,3; bonus bCritical,3; [/background][/size][/font][/color][color=#FF0000][font=helvetica, arial, sans-serif][size=3][background=rgb(247, 247, 247)]if(getrefine() >= 7 ) { bonus bAspdRate,2; bonus bCritical,2; }},{},{}[/background][/size][/font][/color][/quote]
i think this is will be same efect
Hercules Elf Bot - Jun 13, 2012 3:44
Originally posted by [b]Flaid[/b]
I fixed it already, it works as it should work now.
I fixed it already, it works as it should work now.
Hercules Elf Bot - Jun 13, 2012 4:09
Originally posted by [b]hendra814[/b]
ok thanks. i'm already testing on it
ok thanks. i'm already testing on it
Hercules Elf Bot - Jun 13, 2012 5:53
Originally posted by [b]volk[/b]
not update in sql?
not update in sql?
Hercules Elf Bot - Jun 13, 2012 14:21
Originally posted by [b]ForteXX[/b]
Im thinking the script should continue working past +12, but stop increasing at that point, not stop working altogether (see other scripts with these kind of effects) [beret]
for the other, why wouldnt you use { bonus bAspdRate,3; bonus bCritical,3; if(getrefine() >= 7) { bonus bAspdRate,2; bonus bCritical,2; } if(getrefine() >= 9) { bonus bAspdRate,2; bonus bCritical,2; }}
(more directly in line with what the description says)
Im thinking the script should continue working past +12, but stop increasing at that point, not stop working altogether (see other scripts with these kind of effects) [beret]
for the other, why wouldnt you use { bonus bAspdRate,3; bonus bCritical,3; if(getrefine() >= 7) { bonus bAspdRate,2; bonus bCritical,2; } if(getrefine() >= 9) { bonus bAspdRate,2; bonus bCritical,2; }}
(more directly in line with what the description says)
This post has been edited by ForteXX on Jun 13, 2012 14:25
Hercules Elf Bot - Jun 13, 2012 15:37
Originally posted by [b]malufett[/b]
ForteXX idea is better...
@Flaid
[quote] if(getrefine() == 7 || getrefine() == 8)[/quote]
[s]this would fail if the upgrade is greater than 9..[/s]my bad didn't see "=>9"
[s]so ATM this is not totally fixed.....[/s]
ForteXX idea is better...
@Flaid
[quote] if(getrefine() == 7 || getrefine() == 8)[/quote]
[s]this would fail if the upgrade is greater than 9..[/s]my bad didn't see "=>9"
[s]so ATM this is not totally fixed.....[/s]
This post has been edited by malufett on Jun 13, 2012 15:58
Hercules Elf Bot - Jun 13, 2012 15:49
Originally posted by [b]ForteXX[/b]
Well, it would, due to the next part in the script. Way it is right now, if +7 or +8, it gives 2, if +9 or greater, it gives 4.
I was just saying that the description says +7 or greater gives +2, +9 or greater gives [i]another[/i] 2, not cancelling the +7/8 bonus and giving a straight 4.
Well, it would, due to the next part in the script. Way it is right now, if +7 or +8, it gives 2, if +9 or greater, it gives 4.
I was just saying that the description says +7 or greater gives +2, +9 or greater gives [i]another[/i] 2, not cancelling the +7/8 bonus and giving a straight 4.
This post has been edited by ForteXX on Jun 13, 2012 15:50
Hercules Elf Bot - Jun 15, 2012 4:33
Originally posted by [b]hendra814[/b]
[quote name='ForteXX' timestamp='1339602573' post='10501']
Well, it would, due to the next part in the script. Way it is right now, if +7 or +8, it gives 2, if +9 or greater, it gives 4.I was just saying that the description says +7 or greater gives +2, +9 or greater gives [i]another[/i] 2, not cancelling the +7/8 bonus and giving a straight 4.
[/quote]
you mean this script
[quote][color=#282828][font=helvetica, arial, sans-serif][size=3][background=rgb(247, 247, 247)]{ bonus bAspdRate,3; bonus bCritical,3; [/background][/size][/font][/color][color=#FF0000][font=helvetica, arial, sans-serif][size=3][background=rgb(247, 247, 247)]if(getrefine() >= 7 ) { bonus bAspdRate,2; bonus bCritical,2; }},{},{}[/background][/size][/font][/color][/quote]
will give +2 point at refine +7 or +8
and add +2 more for refine higher than +9
so character totaly receive 4 point if refine higher than +9
[quote name='ForteXX' timestamp='1339602573' post='10501']
Well, it would, due to the next part in the script. Way it is right now, if +7 or +8, it gives 2, if +9 or greater, it gives 4.I was just saying that the description says +7 or greater gives +2, +9 or greater gives [i]another[/i] 2, not cancelling the +7/8 bonus and giving a straight 4.
[/quote]
you mean this script
[quote][color=#282828][font=helvetica, arial, sans-serif][size=3][background=rgb(247, 247, 247)]{ bonus bAspdRate,3; bonus bCritical,3; [/background][/size][/font][/color][color=#FF0000][font=helvetica, arial, sans-serif][size=3][background=rgb(247, 247, 247)]if(getrefine() >= 7 ) { bonus bAspdRate,2; bonus bCritical,2; }},{},{}[/background][/size][/font][/color][/quote]
will give +2 point at refine +7 or +8
and add +2 more for refine higher than +9
so character totaly receive 4 point if refine higher than +9
Hercules Elf Bot - Jun 15, 2012 4:54
Originally posted by [b]ForteXX[/b]
If you use that script, you will only ever be able to get a bonus of 5 (3+2) since it doesnt even have the refined to 9+ bonus
If you use that script, you will only ever be able to get a bonus of 5 (3+2) since it doesnt even have the refined to 9+ bonus
Hercules Elf Bot - Jun 15, 2012 5:02
Originally posted by [b]hendra814[/b]
so let me make the table
+7 player get 5 point for aspd and critical
+8 player get same as refine +7
+9 player get 7 point for aspd and critical
+10 player get same as refine +9
is it right for this script
[quote][color=#282828][font=helvetica, arial, sans-serif][size=3][background=rgb(247, 247, 247)]{ bonus bAspdRate,3; bonus bCritical,3; [/background][/size][/font][/color][color=#FF0000][font=helvetica, arial, sans-serif][size=3][background=rgb(247, 247, 247)]if(getrefine() >= 7 ) { bonus bAspdRate,2; bonus bCritical,2; }},{},{}[/background][/size][/font][/color][/quote]
so let me make the table
+7 player get 5 point for aspd and critical
+8 player get same as refine +7
+9 player get 7 point for aspd and critical
+10 player get same as refine +9
is it right for this script
[quote][color=#282828][font=helvetica, arial, sans-serif][size=3][background=rgb(247, 247, 247)]{ bonus bAspdRate,3; bonus bCritical,3; [/background][/size][/font][/color][color=#FF0000][font=helvetica, arial, sans-serif][size=3][background=rgb(247, 247, 247)]if(getrefine() >= 7 ) { bonus bAspdRate,2; bonus bCritical,2; }},{},{}[/background][/size][/font][/color][/quote]
Hercules Elf Bot - Jun 15, 2012 12:44
Originally posted by [b]ForteXX[/b]
No, that script has nothing happening extra for +9 or greater, only the extra +2 for +7 or greater.
Using
{ bonus bAspdRate,3; bonus bCritical,3; if(getrefine() >= 7) { bonus bAspdRate,2; bonus bCritical,2; } if(getrefine() >= 9) { bonus bAspdRate,2; bonus bCritical,2; }}
you get +3 of both all the time, at +7 or greater you get and additional +2 to each (+5 total), and at +9 or greater you get an additional +2 on top of that (+7 total)
^ which is exactly what
Aspd +3%, Critical +3
[color=#ff0000]If refined to +7 or higher, Aspd +2% and Critical +2.[/color]
[color=#ff0000]If refined to +9 or higher, Aspd +2% and Critical +2.[/color]
would be.
No, that script has nothing happening extra for +9 or greater, only the extra +2 for +7 or greater.
Using
{ bonus bAspdRate,3; bonus bCritical,3; if(getrefine() >= 7) { bonus bAspdRate,2; bonus bCritical,2; } if(getrefine() >= 9) { bonus bAspdRate,2; bonus bCritical,2; }}
you get +3 of both all the time, at +7 or greater you get and additional +2 to each (+5 total), and at +9 or greater you get an additional +2 on top of that (+7 total)
^ which is exactly what
Aspd +3%, Critical +3
[color=#ff0000]If refined to +7 or higher, Aspd +2% and Critical +2.[/color]
[color=#ff0000]If refined to +9 or higher, Aspd +2% and Critical +2.[/color]
would be.
Hercules Elf Bot - Jun 15, 2012 14:09
Originally posted by [b]hendra814[/b]
i'm already testing, i want to know the right script
if curently my critical and aspd is 43, 183 when equip the item become 46 critical point and 186 aspd point
when i'm equip this item at refine +7 my char will have 48 critical point and 188 aspd point
and when refine into +9 my char still got a same point
[quote][color=#282828][font=helvetica, arial, sans-serif][size=3][background=rgb(247, 247, 247)]18597,Mercury_Riser,Mercury Riser,5,40,,200,,10,,1,0xFFFFFFFF,7,2,256,,0,,759,{ bonus bAspdRate,3; bonus bCritical,3; [/background][/size][/font][/color][color=#FF0000][font=helvetica, arial, sans-serif][size=3][background=rgb(247, 247, 247)]if(getrefine() == 7 || getrefine() == 8) { bonus bAspdRate,2; bonus bCritical,2; } if(getrefine() >= 9) { bonus bAspdRate,2; bonus bCritical,2; }},{},{}[/background][/size][/font][/color][/quote]
or will receive 50 critical point and 190 aspd point.
[quote][color=#282828][font=helvetica, arial, sans-serif][size=3][background=rgb(247, 247, 247)]18597,Mercury_Riser,Mercury Riser,5,40,,200,,10,,1,0xFFFFFFFF,7,2,256,,0,,759,{ bonus bAspdRate,3; bonus bCritical,3; [/background][/size][/font][/color][color=#FF0000][font=helvetica, arial, sans-serif][size=3][background=rgb(247, 247, 247)]if(getrefine() == 7 || getrefine() == 8) { bonus bAspdRate,2; bonus bCritical,2; } if(getrefine() >= 9) { bonus bAspdRate,4; bonus bCritical,4; }},{},{}[/background][/size][/font][/color][/quote]
this is the result i'm already tested at my server
i'm already testing, i want to know the right script
if curently my critical and aspd is 43, 183 when equip the item become 46 critical point and 186 aspd point
when i'm equip this item at refine +7 my char will have 48 critical point and 188 aspd point
and when refine into +9 my char still got a same point
[quote][color=#282828][font=helvetica, arial, sans-serif][size=3][background=rgb(247, 247, 247)]18597,Mercury_Riser,Mercury Riser,5,40,,200,,10,,1,0xFFFFFFFF,7,2,256,,0,,759,{ bonus bAspdRate,3; bonus bCritical,3; [/background][/size][/font][/color][color=#FF0000][font=helvetica, arial, sans-serif][size=3][background=rgb(247, 247, 247)]if(getrefine() == 7 || getrefine() == 8) { bonus bAspdRate,2; bonus bCritical,2; } if(getrefine() >= 9) { bonus bAspdRate,2; bonus bCritical,2; }},{},{}[/background][/size][/font][/color][/quote]
or will receive 50 critical point and 190 aspd point.
[quote][color=#282828][font=helvetica, arial, sans-serif][size=3][background=rgb(247, 247, 247)]18597,Mercury_Riser,Mercury Riser,5,40,,200,,10,,1,0xFFFFFFFF,7,2,256,,0,,759,{ bonus bAspdRate,3; bonus bCritical,3; [/background][/size][/font][/color][color=#FF0000][font=helvetica, arial, sans-serif][size=3][background=rgb(247, 247, 247)]if(getrefine() == 7 || getrefine() == 8) { bonus bAspdRate,2; bonus bCritical,2; } if(getrefine() >= 9) { bonus bAspdRate,4; bonus bCritical,4; }},{},{}[/background][/size][/font][/color][/quote]
this is the result i'm already tested at my server
Hercules Elf Bot - Jun 15, 2012 16:18
Originally posted by [b]ForteXX[/b]
Thats because using the first script, you only get +2 at refined to 9+, since the first upgrade bonus is only applied at +7 and +8 ([color=#FF0000][font=helvetica, arial, sans-serif][size=3][background=rgb(247, 247, 247)]getrefine() == 7 || getrefine() == 8[/background][/size][/font][/color][font=helvetica, arial, sans-serif][size=3][background=rgb(247, 247, 247)]), and not at anything higher. The second one gives +2 only at +7 and +8, but then changes to giving +4 at upgrades of 9+.[/background][/size][/font]
The script I posted also works, more fitting to the description, by giving +2 when upgraded to 7+, and then giving another +2 (rather than a straight +4) when upgraded to 9+.
Thats because using the first script, you only get +2 at refined to 9+, since the first upgrade bonus is only applied at +7 and +8 ([color=#FF0000][font=helvetica, arial, sans-serif][size=3][background=rgb(247, 247, 247)]getrefine() == 7 || getrefine() == 8[/background][/size][/font][/color][font=helvetica, arial, sans-serif][size=3][background=rgb(247, 247, 247)]), and not at anything higher. The second one gives +2 only at +7 and +8, but then changes to giving +4 at upgrades of 9+.[/background][/size][/font]
The script I posted also works, more fitting to the description, by giving +2 when upgraded to 7+, and then giving another +2 (rather than a straight +4) when upgraded to 9+.
Hercules Elf Bot - Jun 15, 2012 18:44
Originally posted by [b]MarkZD[/b]
[quote name='ForteXX' timestamp='1339597294' post='10495']
Im thinking the script should continue working past +12, but stop increasing at that point, not stop working altogether (see other scripts with these kind of effects) [beret]
[/quote]
Bump.
[quote name='ForteXX' timestamp='1339597294' post='10495']
Im thinking the script should continue working past +12, but stop increasing at that point, not stop working altogether (see other scripts with these kind of effects) [beret]
[/quote]
Bump.
This post has been edited by MarkZD on Jun 15, 2012 18:45
Hercules Elf Bot - Jun 15, 2012 21:31
Originally posted by [b]Flaid[/b]
Fixed in [url="http://sourceforge.net/apps/trac/rathena/changeset/16307/"]r16307[/url]
Fixed in [url="http://sourceforge.net/apps/trac/rathena/changeset/16307/"]r16307[/url]
Hercules Elf Bot - Jun 16, 2012 0:51
Originally posted by [b]hendra814[/b]
@flaid you did wrong fixed for cat ears beret items at sql files.
[quote][color=#000000][font=monospace][size=2][left][background=rgb(221, 255, 221)](18600,'Cat_Ear_Beret','Cat Ear Beret',5,30,NULL,200,NULL,5,NULL,1,0xFFFFFFFF,7,2,256,NULL,0,1,761,'bonus bAspdRate,3; bonus bCritical,3; if(getrefine() >= 7) { bonus bAspdRate,2; bonus bCritical,2; } if(getrefine() >= 9) { bonus bAspdRate,2; bonus bCritical,2;}',NULL,NULL);[/background][/left][/size][/font][/color][color=#000000][font=monospace][size=2][left][background=rgb(221, 255, 221)] [/background][/left][/size][/font][/color] <[/quote]
i think that's script for mercury riser
@flaid you did wrong fixed for cat ears beret items at sql files.
[quote][color=#000000][font=monospace][size=2][left][background=rgb(221, 255, 221)](18600,'Cat_Ear_Beret','Cat Ear Beret',5,30,NULL,200,NULL,5,NULL,1,0xFFFFFFFF,7,2,256,NULL,0,1,761,'bonus bAspdRate,3; bonus bCritical,3; if(getrefine() >= 7) { bonus bAspdRate,2; bonus bCritical,2; } if(getrefine() >= 9) { bonus bAspdRate,2; bonus bCritical,2;}',NULL,NULL);[/background][/left][/size][/font][/color][color=#000000][font=monospace][size=2][left][background=rgb(221, 255, 221)] [/background][/left][/size][/font][/color] <[/quote]
i think that's script for mercury riser
Hercules Elf Bot - Jun 16, 2012 3:13
Originally posted by [b]Flaid[/b]
I highly apologize, it's kind of late, it has got the correct script now. Fixed/optimized in [url="http://sourceforge.net/apps/trac/rathena/changeset/16310/"]r16310[/url]
I highly apologize, it's kind of late, it has got the correct script now. Fixed/optimized in [url="http://sourceforge.net/apps/trac/rathena/changeset/16310/"]r16310[/url]
This post has been edited by Flaid on Jun 16, 2012 3:13