[Wanderer, Maestro/Minstrel] Chorus skills still not fixed

Issue information

Issue ID

#6052

Status

New

Severity

None

Started

Hercules Elf Bot

Jun 18, 2012 1:41

Last Post

Ind

Jan 19, 2013 20:41

Confirmation

Yes (1)

No (0)

Hercules Elf Bot - Jun 18, 2012 1:41

Originally posted by [b]Majinken[/b]
[url="http://rathena.org/board/tracker/issue-5793-wanderer-maestrominstrel-chorus-skills/"]http://rathena.org/b...-chorus-skills/[/url]

Still not fixed, I can still cast chorus skills with one character not in a party. The only skill I can't use alone is Great Echo.

[url="http://irowiki.org/wiki/Chorus_Skill"]http://irowiki.org/wiki/Chorus_Skill[/url]

[quote]
[b] Notes [/b][list]
[*]Chorus skills require at least two performers ([url="http://irowiki.org/wiki/Maestro"]Maestro[/url] or [url="http://irowiki.org/wiki/Wanderer"]Wanderer[/url], in any combination) in the same party, with an [url="http://irowiki.org/wiki/Instrument"]instrument[/url] and [url="http://irowiki.org/wiki/Whip"]whip[/url] equipped and both players on the caster's screen.
[/list]
[/quote]

Hercules Elf Bot - Jul 9, 2012 23:19

Originally posted by [b]Majinken[/b]
Up, still not fixed even on the latest revision. It's in pre-re mode, if that helps.

Hercules Elf Bot - Oct 26, 2012 10:41

Originally posted by [b]Majinken[/b]
Is this fixed?

Hercules Elf Bot - Nov 28, 2012 21:25

Originally posted by [b]Baalberith[/b]
Still not fixed, however Great Echo works OK and checks for partner.

Hercules Elf Bot - Nov 28, 2012 21:37

Originally posted by [b]Baalberith[/b]
The most straight-forward solution seems to me adding the other chorus skills to the great echo check:
[CODE]
+ case WM_SONG_OF_MANA:
+ case WM_DANCE_WITH_WUG:
+ case WM_SOUND_OF_DESTRUCTION:
+ case WM_SATURDAY_NIGHT_FEVER:
+ case WM_LERADS_DEW:
+ case WM_MELODYOFSINK:
+ case WM_BEYOND_OF_WARCRY:
+ case WM_UNLIMITED_HUMMING_VOICE:
case WM_GREAT_ECHO: {
int count;
count = skill_check_pc_partner(sd, skill, &lv, skill_get_splash(skill,lv), 0);
if( count < 1 ) {
clif_skill_fail(sd,skill,USESKILL_FAIL_NEED_HELPER,0);
return 0;
} else
require.sp -= require.sp * 20 * count / 100; // -20% each W/M in the party.
}
break;
[/CODE]
Also please note that in function skill_check_pc_partner(), there is a line, that some compilers may not parse correctly:
[CODE]
bool is_chorus = (skill_get_inf2(skill_id)&INF2_CHORUS_SKILL);
should be changed to:
bool is_chorus = ( (skill_get_inf2(skill_id)&INF2_CHORUS_SKILL) != 0);
or
int is_chorus = (skill_get_inf2(skill_id)&INF2_CHORUS_SKILL);
[/CODE]

This post has been edited by Baalberith on Nov 28, 2012 22:13