EDP should no longer increase final damage
Warning! This is the old Hercules bugtracker archive, and may not reflect the current state of Hercules. The current bugtracker is on GitHub Issues.
Issue information
Issue ID
#6066
Status
Fixed
Severity
Medium
Started
Hercules Elf Bot
Jun 20, 2012 3:02
Last Post
malufett
Jun 12, 2013 18:58
Confirmation
Hercules Elf Bot - Jun 20, 2012 3:02
Originally posted by [b]MarkZD[/b]
Here's my EDP fix, based upon rA comment source, iRO source and etc.
[CODE]
if( sc->data[SC_EDP] ){
switch(skill_num){
case AS_SPLASHER: case AS_VENOMKNIFE:
case ASC_METEORASSAULT:
break;
#ifdef RENEWAL_EDP
case AS_SONICBLOW:
case ASC_BREAKER:
case GC_COUNTERSLASH:
case GC_CROSSIMPACT:
ATK_RATE(50); // only modifier is halved but still benefit with the atk and weapon bonus
break;
#else
case ASC_BREAKER: break;
default:
ATK_ADDRATE(sc->data[SC_EDP]->val3);//It doesn't exist in RENEWAL
#endif
}
}
[/CODE]
[color=#282828][font=helvetica, arial, sans-serif][size=3]This "atk_addrate" is from PRE because in Renewal, base atk and weapon attack are increased instead of this final addition, and base&weapon attack are coded in status.c[/size][/font][/color]
[color=#282828][font=helvetica, arial, sans-serif][size=3]This will also fix huge damage of normal attack and skills in RE like Rolling Cutter: [/size][/font][/color][url="http://sourceforge.net/apps/trac/rathena/changeset/16322/"]http://sourceforge.n...hangeset/16322/[/url]
[b]Also, in status.c:[/b]
[b][color=#282828][font=helvetica, arial, sans-serif][size=3]wATK should be increased by 5 & bATK by 4, but it's inverted[/size][/font][/color][/b]
[font=helvetica, arial, sans-serif][color=#282828][size=3][b]Also, it should be eATK not bATK, but we need Renewal atk changes to do that perfectlly.[/b][/size][/color][/font]
Here's my EDP fix, based upon rA comment source, iRO source and etc.
[CODE]
if( sc->data[SC_EDP] ){
switch(skill_num){
case AS_SPLASHER: case AS_VENOMKNIFE:
case ASC_METEORASSAULT:
break;
#ifdef RENEWAL_EDP
case AS_SONICBLOW:
case ASC_BREAKER:
case GC_COUNTERSLASH:
case GC_CROSSIMPACT:
ATK_RATE(50); // only modifier is halved but still benefit with the atk and weapon bonus
break;
#else
case ASC_BREAKER: break;
default:
ATK_ADDRATE(sc->data[SC_EDP]->val3);//It doesn't exist in RENEWAL
#endif
}
}
[/CODE]
[color=#282828][font=helvetica, arial, sans-serif][size=3]This "atk_addrate" is from PRE because in Renewal, base atk and weapon attack are increased instead of this final addition, and base&weapon attack are coded in status.c[/size][/font][/color]
[color=#282828][font=helvetica, arial, sans-serif][size=3]This will also fix huge damage of normal attack and skills in RE like Rolling Cutter: [/size][/font][/color][url="http://sourceforge.net/apps/trac/rathena/changeset/16322/"]http://sourceforge.n...hangeset/16322/[/url]
[b]Also, in status.c:[/b]
[b][color=#282828][font=helvetica, arial, sans-serif][size=3]wATK should be increased by 5 & bATK by 4, but it's inverted[/size][/font][/color][/b]
[font=helvetica, arial, sans-serif][color=#282828][size=3][b]Also, it should be eATK not bATK, but we need Renewal atk changes to do that perfectlly.[/b][/size][/color][/font]
This post has been edited by MarkZD on Jul 19, 2012 15:46
Hercules Elf Bot - Jun 20, 2012 6:32
Originally posted by [b]exneval[/b]
[CODE]
11/11/2009 - Maintenance
Sakray Test Server
- While using Enchant Deadly Poison, the following skills have their attack power and SP cost changed.
Cross Impact
Regular
Attack Power 1200% 1250% 1300% 1350% 1400%
SP Cost 25
With Enchant Deadly Poison
Attack Power 600% 625% 650% 675% 700%
SP Cost 50
Counter Slasher
Regular
Attack Power 400% 500% 600% 700% 800%
SP Cost 5 8 11 14 17
With Enchant Deadly Poison
Attack Power 200% 250% 300% 350% 400%
SP Cost 10 16 22 28 34
Soul Destroyer
Regular
Attack Power 350% 400% 450% 500% 550% 600% 650% 700% 750% 800%
SP Cost 20 20 20 20 20 30 30 30 30 30
With Enchant Deadly Poison
Attack Power 170% 200% 225% 250% 275% 300% 325% 350% 375% 400%
SP Cost 20 20 20 20 20 30 30 30 30 30
Sonic Blow
Regular
Attack Power 440% 480% 520% 560% 600% 640% 680% 720% 760% 800%
SP Cost 16 18 20 22 24 26 28 30 32 34
With Enchant Deadly Poison
Attack power 220% 240% 260% 280% 300% 320% 340% 360% 380% 400%
SP Cost 32 36 40 44 48 52 56 60 64 68
[/CODE]
[url="http://forums.irowiki.org/showpost.php?p=587499&postcount=1"]Source[/url]
[CODE]
Changes for EDP:
Enchant Deadly Poison does not quadruple the damage of skills anymore.
Instead it adds +400% damage at the end of the damage calculation.
Examples:
EDP+Sonic blow:
Before renewal : 800%*400% = 3200% damage
Renewal : 800%+400% = 1200% damage
EDP+Sonic blow+Link
Before renewal: 800%*400%*2 = 6400% damage
Renewal : Either 800%*2+400% = 2000% damage or (800%+400%)*2 = 2400% damage (please pm me correct one)
EDP+Grimtooth
Before renewal : 200%*400% = 800% damage
Renewal : 200%+400% = 600% damage
Meleeattacks remain unchanged (qudrupling the damage for 400% damage)
[/CODE]
[url="http://forums.irowiki.org/showthread.php?t=23796"]Source[/url]
[CODE]
11/11/2009 - Maintenance
Sakray Test Server
- While using Enchant Deadly Poison, the following skills have their attack power and SP cost changed.
Cross Impact
Regular
Attack Power 1200% 1250% 1300% 1350% 1400%
SP Cost 25
With Enchant Deadly Poison
Attack Power 600% 625% 650% 675% 700%
SP Cost 50
Counter Slasher
Regular
Attack Power 400% 500% 600% 700% 800%
SP Cost 5 8 11 14 17
With Enchant Deadly Poison
Attack Power 200% 250% 300% 350% 400%
SP Cost 10 16 22 28 34
Soul Destroyer
Regular
Attack Power 350% 400% 450% 500% 550% 600% 650% 700% 750% 800%
SP Cost 20 20 20 20 20 30 30 30 30 30
With Enchant Deadly Poison
Attack Power 170% 200% 225% 250% 275% 300% 325% 350% 375% 400%
SP Cost 20 20 20 20 20 30 30 30 30 30
Sonic Blow
Regular
Attack Power 440% 480% 520% 560% 600% 640% 680% 720% 760% 800%
SP Cost 16 18 20 22 24 26 28 30 32 34
With Enchant Deadly Poison
Attack power 220% 240% 260% 280% 300% 320% 340% 360% 380% 400%
SP Cost 32 36 40 44 48 52 56 60 64 68
[/CODE]
[url="http://forums.irowiki.org/showpost.php?p=587499&postcount=1"]Source[/url]
[CODE]
Changes for EDP:
Enchant Deadly Poison does not quadruple the damage of skills anymore.
Instead it adds +400% damage at the end of the damage calculation.
Examples:
EDP+Sonic blow:
Before renewal : 800%*400% = 3200% damage
Renewal : 800%+400% = 1200% damage
EDP+Sonic blow+Link
Before renewal: 800%*400%*2 = 6400% damage
Renewal : Either 800%*2+400% = 2000% damage or (800%+400%)*2 = 2400% damage (please pm me correct one)
EDP+Grimtooth
Before renewal : 200%*400% = 800% damage
Renewal : 200%+400% = 600% damage
Meleeattacks remain unchanged (qudrupling the damage for 400% damage)
[/CODE]
[url="http://forums.irowiki.org/showthread.php?t=23796"]Source[/url]
Hercules Elf Bot - Jun 20, 2012 7:06
Originally posted by [b]MarkZD[/b]
[quote][color=#000000][font=sans-serif][size=3]As of Renewal, EDP no longer increases final damage by 400%[/size][/font][/color][/quote]
[url="http://irowiki.org/wiki/Enchant_Deadly_Poison"]http://irowiki.org/wiki/Enchant_Deadly_Poison[/url]
What's the right, will it increase or not?
Even if does, the current code is incorrect because it's still multiplying damage as it did in PRE.
[quote][color=#000000][font=sans-serif][size=3]As of Renewal, EDP no longer increases final damage by 400%[/size][/font][/color][/quote]
[url="http://irowiki.org/wiki/Enchant_Deadly_Poison"]http://irowiki.org/wiki/Enchant_Deadly_Poison[/url]
What's the right, will it increase or not?
Even if does, the current code is incorrect because it's still multiplying damage as it did in PRE.
Hercules Elf Bot - Jun 20, 2012 7:20
Originally posted by [b]exneval[/b]
we should just try it ingame, iRO or kRO
not based on forum or other way
we should just try it ingame, iRO or kRO
not based on forum or other way
Hercules Elf Bot - Jun 20, 2012 9:35
Originally posted by [b]MarkZD[/b]
[quote name='Angezerus' timestamp='1340180094' post='10958']
Edp does affect Rolling Cutter, without halving the skill attack.[u]Halved Skills[/u]: Sonic Blow, Cross Impact, Soul Destroyer, Counter Slash[u]Does Not Affected By EDP[/u]: Grimtooth, Throw Venom Knife[u]100% affected[/u]: Any other physical attack skills that don't do fixed damage, including Envenom, Venom Splasher, Meteor Assault, Rolling Cutter, Dark Illusion, Cross Ripper Slash, Phantom Menace, Venom Pressure, Weapon Crush, and other, card/equipment obtainable skills such as Bash, Magnum Break, Bowling Bash, Occult Impact, Pierce etc...
[/quote]
EDP should before add 400% and after half, should half before and after add 400% or the halved skills don't get the bonus in any case?
[quote name='Angezerus' timestamp='1340180094' post='10958']
Edp does affect Rolling Cutter, without halving the skill attack.[u]Halved Skills[/u]: Sonic Blow, Cross Impact, Soul Destroyer, Counter Slash[u]Does Not Affected By EDP[/u]: Grimtooth, Throw Venom Knife[u]100% affected[/u]: Any other physical attack skills that don't do fixed damage, including Envenom, Venom Splasher, Meteor Assault, Rolling Cutter, Dark Illusion, Cross Ripper Slash, Phantom Menace, Venom Pressure, Weapon Crush, and other, card/equipment obtainable skills such as Bash, Magnum Break, Bowling Bash, Occult Impact, Pierce etc...
[/quote]
EDP should before add 400% and after half, should half before and after add 400% or the halved skills don't get the bonus in any case?
This post has been edited by MarkZD on Jun 20, 2012 9:37
Hercules Elf Bot - Jun 20, 2012 10:02
Originally posted by [b]MarkZD[/b]
Here are some tests(Antler Scaraba)dic_dun02:
EDP adds 300% to final skillratio. (I checked after it was 300, but I was guessing about)
normal attack(edp): up to 2k
Rolling Cutter(edp): 8~11k
cross impact(edp): 12~15k
cross impact(edp+poison weapon): 15~19k
cross impact(edp+venom impress): 17~24k
4x normal atk, no multiplier to any skills by edp
normal attack(edp): up to 7k
Rolling Cutter(edp): 4~6k
cross impact(edp): 10~12k
cross impact(edp+poison weapon): 12~17k
cross impact(edp+venom impress): 17~21k
I think the second Rolling Cutter looks like near the video damage, the one increased by 300%(not even 400%) is very higher than official damage, and I'm just using the video weapon.
About normal atk, I'm not sure yet, but it's a high damage, imagine in pvp 400% would be like 9k without venom impress and you can hit with a high aspd.
And it all with no bonus against demi-human.
Here are some tests(Antler Scaraba)dic_dun02:
EDP adds 300% to final skillratio. (I checked after it was 300, but I was guessing about)
normal attack(edp): up to 2k
Rolling Cutter(edp): 8~11k
cross impact(edp): 12~15k
cross impact(edp+poison weapon): 15~19k
cross impact(edp+venom impress): 17~24k
4x normal atk, no multiplier to any skills by edp
normal attack(edp): up to 7k
Rolling Cutter(edp): 4~6k
cross impact(edp): 10~12k
cross impact(edp+poison weapon): 12~17k
cross impact(edp+venom impress): 17~21k
I think the second Rolling Cutter looks like near the video damage, the one increased by 300%(not even 400%) is very higher than official damage, and I'm just using the video weapon.
About normal atk, I'm not sure yet, but it's a high damage, imagine in pvp 400% would be like 9k without venom impress and you can hit with a high aspd.
And it all with no bonus against demi-human.
This post has been edited by MarkZD on Jun 20, 2012 10:08
Hercules Elf Bot - Jun 20, 2012 10:08
Originally posted by [b]MarkZD[/b]
http://www.youtube.com/watch?v=NK8HEGs1TYE&feature=player_embedded
http://www.youtube.com/watch?v=NK8HEGs1TYE&feature=player_embedded
Hercules Elf Bot - Jun 20, 2012 10:30
Originally posted by [b]MarkZD[/b]
Also, your source looks very old, it's from 2009 just the begining of Renewal.
Also, your source looks very old, it's from 2009 just the begining of Renewal.
This post has been edited by MarkZD on Jun 20, 2012 10:39
Hercules Elf Bot - Jun 20, 2012 11:37
Originally posted by [b]malufett[/b]
[quote name='MarkZD' timestamp='1340188218' post='10968']
Also, your source looks very old, it's from 2009 just the begining of Renewal.
[/quote]
Even though its old but still its never been changed...
and I notice that those skill that had been nerfed when edp is active is that their SP consumption increases...
anyways I'll try to confirm in game(kRO)
[quote name='MarkZD' timestamp='1340188218' post='10968']
Also, your source looks very old, it's from 2009 just the begining of Renewal.
[/quote]
Even though its old but still its never been changed...
and I notice that those skill that had been nerfed when edp is active is that their SP consumption increases...
anyways I'll try to confirm in game(kRO)
Hercules Elf Bot - Jun 20, 2012 13:46
Originally posted by [b]Angezerus[/b]
What about the watk*5, eatk*4 formula? Even calculators use that formula..
Btw
I had some posts regarding the formula here:
[url="http://rathena.org/board/tracker/issue-5778-edp-bug/"]http://rathena.org/board/tracker/issue-5778-edp-bug/[/url]
What about the watk*5, eatk*4 formula? Even calculators use that formula..
Btw
I had some posts regarding the formula here:
[url="http://rathena.org/board/tracker/issue-5778-edp-bug/"]http://rathena.org/board/tracker/issue-5778-edp-bug/[/url]
This post has been edited by Angezerus on Jun 20, 2012 14:58
Hercules Elf Bot - Jun 20, 2012 14:07
Originally posted by [b]Angezerus[/b]
I just noticed something.
[quote name='exneval' timestamp='1340173949' post='10952']
[CODE]11/11/2009 - MaintenanceSakray Test Server- While using Enchant Deadly Poison, the following skills have their attack power and SP cost changed. Cross Impact Regular Attack Power 1200% 1250% 1300% 1350% 1400% SP Cost 25 With Enchant Deadly Poison Attack Power 600% 625% 650% 675% 700% SP Cost 50 Counter Slasher Regular Attack Power 400% 500% 600% 700% 800% SP Cost 5 8 11 14 17 With Enchant Deadly Poison Attack Power 200% 250% 300% 350% 400% SP Cost 10 16 22 28 34 Soul Destroyer Regular Attack Power 350% 400% 450% 500% 550% 600% 650% 700% 750% 800% SP Cost 20 20 20 20 20 30 30 30 30 30 With Enchant Deadly Poison Attack Power 170% 200% 225% 250% 275% 300% 325% 350% 375% 400% SP Cost 20 20 20 20 20 30 30 30 30 30 Sonic Blow Regular Attack Power 440% 480% 520% 560% 600% 640% 680% 720% 760% 800% SP Cost 16 18 20 22 24 26 28 30 32 34 With Enchant Deadly Poison Attack power 220% 240% 260% 280% 300% 320% 340% 360% 380% 400% SP Cost 32 36 40 44 48 52 56 60 64 68[/CODE][url="http://forums.irowiki.org/showpost.php?p=587499&postcount=1"]Source[/url][CODE]Changes for EDP:Enchant Deadly Poison does not quadruple the damage of skills anymore.Instead it adds +400% damage at the end of the damage calculation.Examples:EDP+Sonic blow:Before renewal : 800%*400% = 3200% damageRenewal : 800%+400% = 1200% damageEDP+Sonic blow+LinkBefore renewal: 800%*400%*2 = 6400% damageRenewal : Either 800%*2+400% = 2000% damage or (800%+400%)*2 = 2400% damage (please pm me correct one)
EDP+GrimtoothBefore renewal : 200%*400% = 800% damage
Renewal : 200%+400% = 600% damage
Meleeattacks remain unchanged (qudrupling the damage for 400% damage)[/CODE][url="http://forums.irowiki.org/showthread.php?t=23796"]Source[/url]
[/quote]
The edp post by atum is surely long outdated. Grimtooth is not affected at all.
So most likely we should stick to the known weapon atk*5 equip atk*4 formula.
If we use it on skills that are affected, and half the modifier on the ones that are needed to be halved, then we are ok.
The only question is that whether its *5 and *4 for all levels, and only duration and poison chance changes, or there is a formula for both modifier. This needs to be tested.
I just noticed something.
[quote name='exneval' timestamp='1340173949' post='10952']
[CODE]11/11/2009 - MaintenanceSakray Test Server- While using Enchant Deadly Poison, the following skills have their attack power and SP cost changed. Cross Impact Regular Attack Power 1200% 1250% 1300% 1350% 1400% SP Cost 25 With Enchant Deadly Poison Attack Power 600% 625% 650% 675% 700% SP Cost 50 Counter Slasher Regular Attack Power 400% 500% 600% 700% 800% SP Cost 5 8 11 14 17 With Enchant Deadly Poison Attack Power 200% 250% 300% 350% 400% SP Cost 10 16 22 28 34 Soul Destroyer Regular Attack Power 350% 400% 450% 500% 550% 600% 650% 700% 750% 800% SP Cost 20 20 20 20 20 30 30 30 30 30 With Enchant Deadly Poison Attack Power 170% 200% 225% 250% 275% 300% 325% 350% 375% 400% SP Cost 20 20 20 20 20 30 30 30 30 30 Sonic Blow Regular Attack Power 440% 480% 520% 560% 600% 640% 680% 720% 760% 800% SP Cost 16 18 20 22 24 26 28 30 32 34 With Enchant Deadly Poison Attack power 220% 240% 260% 280% 300% 320% 340% 360% 380% 400% SP Cost 32 36 40 44 48 52 56 60 64 68[/CODE][url="http://forums.irowiki.org/showpost.php?p=587499&postcount=1"]Source[/url][CODE]Changes for EDP:Enchant Deadly Poison does not quadruple the damage of skills anymore.Instead it adds +400% damage at the end of the damage calculation.Examples:EDP+Sonic blow:Before renewal : 800%*400% = 3200% damageRenewal : 800%+400% = 1200% damageEDP+Sonic blow+LinkBefore renewal: 800%*400%*2 = 6400% damageRenewal : Either 800%*2+400% = 2000% damage or (800%+400%)*2 = 2400% damage (please pm me correct one)
EDP+GrimtoothBefore renewal : 200%*400% = 800% damage
Renewal : 200%+400% = 600% damage
Meleeattacks remain unchanged (qudrupling the damage for 400% damage)[/CODE][url="http://forums.irowiki.org/showthread.php?t=23796"]Source[/url]
[/quote]
The edp post by atum is surely long outdated. Grimtooth is not affected at all.
So most likely we should stick to the known weapon atk*5 equip atk*4 formula.
If we use it on skills that are affected, and half the modifier on the ones that are needed to be halved, then we are ok.
The only question is that whether its *5 and *4 for all levels, and only duration and poison chance changes, or there is a formula for both modifier. This needs to be tested.
This post has been edited by Angezerus on Jun 20, 2012 14:58
Hercules Elf Bot - Jun 20, 2012 14:25
Originally posted by [b]Angezerus[/b]
http://forums.irowiki.org/showthread.php?t=23796&page=187
Atum himself stated the watk*5 eatk*4 formula later, in the same topic after gravity made the third change on edp
(1st: +400%, 2nd 300%, 3rd watk*5 eatk*4)
[quote][color=#000000][font=verdana, geneva, lucida,][background=rgb(235, 241, 250)]No.[/background][/font][/color]
[color=#000000][font=verdana, geneva, lucida,]EDP multiplies weapon atk by 5 and equip atk by 4 (if i remember correctly) but leaves status atk alone [/font][/color][/quote]
/Edit...
OMG it just became clear to me. It's not even base atk. It's equipment attack. Okay, so:
Weapon attack*5
Equipment attack*4 (Cards and stuff)
Base (status) attack not affected!
[size=5][b]So, the current formula is bugged because of this. Now, we use BATK(Base Attack) instead of [u]equipment attack[/u]![/b][/size]
/EDIT2
Another source, before they confirmed the *5 *4 formula:
http://forums.irowiki.org/showthread.php?t=33450&page=64
[quote][color=#000000][font=verdana, geneva, lucida,]Originally Posted by [/font][/color][b]Clogon[/b][color=#000000][font=verdana, geneva, lucida,] [/font][/color][url="http://forums.irowiki.org/showthread.php?p=596827#post596827"][img]http://forums.irowiki.org/images/buttons_mns/viewpost.gif[/img][/url][color=#000000][font=verdana, geneva, lucida,]
EDP was changed 3 times with the implementation of RE.
1) +400% atk buff = EDP not affected by by Racials.
2) 3x final damage = EDP affected by Racials.[/font][/color]
[color=#000000][font=verdana, geneva, lucida,]3) 5x (4x need to double check this some time) [e.atk + w.atk] = EDP affected by Racials.[/font][/color][/quote]
http://forums.irowiki.org/showthread.php?t=23796&page=187
Atum himself stated the watk*5 eatk*4 formula later, in the same topic after gravity made the third change on edp
(1st: +400%, 2nd 300%, 3rd watk*5 eatk*4)
[quote][color=#000000][font=verdana, geneva, lucida,][background=rgb(235, 241, 250)]No.[/background][/font][/color]
[color=#000000][font=verdana, geneva, lucida,]EDP multiplies weapon atk by 5 and equip atk by 4 (if i remember correctly) but leaves status atk alone [/font][/color][/quote]
/Edit...
OMG it just became clear to me. It's not even base atk. It's equipment attack. Okay, so:
Weapon attack*5
Equipment attack*4 (Cards and stuff)
Base (status) attack not affected!
[size=5][b]So, the current formula is bugged because of this. Now, we use BATK(Base Attack) instead of [u]equipment attack[/u]![/b][/size]
/EDIT2
Another source, before they confirmed the *5 *4 formula:
http://forums.irowiki.org/showthread.php?t=33450&page=64
[quote][color=#000000][font=verdana, geneva, lucida,]Originally Posted by [/font][/color][b]Clogon[/b][color=#000000][font=verdana, geneva, lucida,] [/font][/color][url="http://forums.irowiki.org/showthread.php?p=596827#post596827"][img]http://forums.irowiki.org/images/buttons_mns/viewpost.gif[/img][/url][color=#000000][font=verdana, geneva, lucida,]
EDP was changed 3 times with the implementation of RE.
1) +400% atk buff = EDP not affected by by Racials.
2) 3x final damage = EDP affected by Racials.[/font][/color]
[color=#000000][font=verdana, geneva, lucida,]3) 5x (4x need to double check this some time) [e.atk + w.atk] = EDP affected by Racials.[/font][/color][/quote]
This post has been edited by Angezerus on Jun 20, 2012 15:03
Hercules Elf Bot - Jun 23, 2012 14:30
Originally posted by [b]exneval[/b]
maybe [url="http://forums.irowiki.org/showthread.php?t=88057"]this[/url] can help a lot
maybe [url="http://forums.irowiki.org/showthread.php?t=88057"]this[/url] can help a lot
Hercules Elf Bot - Jun 23, 2012 14:57
Originally posted by [b]GM Takumirai[/b]
EDP + rolling cutter x10 + cross ripper slasher = high damage, can someone confirm this damage..
EDP + rolling cutter x10 + cross ripper slasher = high damage, can someone confirm this damage..
Hercules Elf Bot - Jun 23, 2012 15:06
Originally posted by [b]RiverStyx[/b]
Confirmed, the damage is insane, GX's soloing beelzbub with a 4x mummy main gauche? lolwut.
Confirmed, the damage is insane, GX's soloing beelzbub with a 4x mummy main gauche? lolwut.
Hercules Elf Bot - Jun 23, 2012 23:18
Originally posted by [b]MarkZD[/b]
Considering the current formula, mine is more apropprieted.
But, apparently eATK should be increased instead of bATK in status.c.
[quote][b]Equipment ATK[/b][color=#000000][font=sans-serif][size=3] is the sum of ATK gained from equips other than [/size][/font][/color][url="http://irowiki.org/wiki/Weapon"]weapons[/url][color=#000000][font=sans-serif][size=3]. Support buffs tend to increase this ATK, too, but not all of them fit into this category.[/size][/font][/color]
[b] Properties[/b][list]
[*]Affected by [url="http://irowiki.org/wiki/Weapon"]weapon[/url] [url="http://irowiki.org/wiki/Element"]element[/url] when using a melee weapon.
[*]Affected by [url="http://irowiki.org/w/index.php?title=Ammunition&action=edit&redlink=1"]ammunition[/url] [url="http://irowiki.org/wiki/Element"]element[/url] when using a ranged weapon or specific skill.
[*][url="http://irowiki.org/w/index.php?title=Ammunition&action=edit&redlink=1"]ammunition[/url] ATK is added here when using DEX based weapon
[*]Any +ATK you get from cards, including cards in weapon, is added here
[*]Affected by [url="http://irowiki.org/wiki/Element"]element[/url] resistance effects like Raydric Card or Asprika.
[*]Increased by % ATK item effects like The Sign and Hydra Card.
[*]Multiplied by 4 when affected by [url="http://irowiki.org/wiki/Enchant_Deadly_Poison"]Enchant Deadly Poison[/url].
[/list]
[/quote]
Considering the current formula, mine is more apropprieted.
But, apparently eATK should be increased instead of bATK in status.c.
[quote][b]Equipment ATK[/b][color=#000000][font=sans-serif][size=3] is the sum of ATK gained from equips other than [/size][/font][/color][url="http://irowiki.org/wiki/Weapon"]weapons[/url][color=#000000][font=sans-serif][size=3]. Support buffs tend to increase this ATK, too, but not all of them fit into this category.[/size][/font][/color]
[b] Properties[/b][list]
[*]Affected by [url="http://irowiki.org/wiki/Weapon"]weapon[/url] [url="http://irowiki.org/wiki/Element"]element[/url] when using a melee weapon.
[*]Affected by [url="http://irowiki.org/w/index.php?title=Ammunition&action=edit&redlink=1"]ammunition[/url] [url="http://irowiki.org/wiki/Element"]element[/url] when using a ranged weapon or specific skill.
[*][url="http://irowiki.org/w/index.php?title=Ammunition&action=edit&redlink=1"]ammunition[/url] ATK is added here when using DEX based weapon
[*]Any +ATK you get from cards, including cards in weapon, is added here
[*]Affected by [url="http://irowiki.org/wiki/Element"]element[/url] resistance effects like Raydric Card or Asprika.
[*]Increased by % ATK item effects like The Sign and Hydra Card.
[*]Multiplied by 4 when affected by [url="http://irowiki.org/wiki/Enchant_Deadly_Poison"]Enchant Deadly Poison[/url].
[/list]
[/quote]
This post has been edited by MarkZD on Jun 23, 2012 23:19
Hercules Elf Bot - Jun 23, 2012 23:28
Originally posted by [b]MarkZD[/b]
And, if NORMAL attack is still affected by EDP final increase, so this:
[CODE]
if( !skill_num )
{
ATK_RATE(skillratio);
}
[/CODE]
should be changed to:
[CODE]
if( !skill_num )
{
if( sc->data[SC_EDP] )
skillratio += sc->data[SC_EDP]->val3 + 100;
ATK_RATE(skillratio);
}
[/CODE]
And, if NORMAL attack is still affected by EDP final increase, so this:
[CODE]
if( !skill_num )
{
ATK_RATE(skillratio);
}
[/CODE]
should be changed to:
[CODE]
if( !skill_num )
{
if( sc->data[SC_EDP] )
skillratio += sc->data[SC_EDP]->val3 + 100;
ATK_RATE(skillratio);
}
[/CODE]
This post has been edited by MarkZD on Jun 23, 2012 23:54
Hercules Elf Bot - Jun 24, 2012 8:19
Originally posted by [b]Angezerus[/b]
[quote name='MarkZD' timestamp='1340494131' post='11110']
And, if NORMAL attack is still affected by EDP final increase, so this:[CODE] if( !skill_num ) { ATK_RATE(skillratio); }[/CODE]should be changed to:[CODE] if( !skill_num ) { if( sc->data[SC_EDP] ) skillratio += sc->data[SC_EDP]->val3 + 100; ATK_RATE(skillratio); }[/CODE]
[/quote]
Normal attack is not affected. Only weapon and equipment.
[quote name='MarkZD' timestamp='1340494131' post='11110']
And, if NORMAL attack is still affected by EDP final increase, so this:[CODE] if( !skill_num ) { ATK_RATE(skillratio); }[/CODE]should be changed to:[CODE] if( !skill_num ) { if( sc->data[SC_EDP] ) skillratio += sc->data[SC_EDP]->val3 + 100; ATK_RATE(skillratio); }[/CODE]
[/quote]
Normal attack is not affected. Only weapon and equipment.
Hercules Elf Bot - Jun 24, 2012 18:17
Originally posted by [b]MarkZD[/b]
There's another problem: wATK should be increased by 5 & bATK by 4, but it's inverted.
There's another problem: wATK should be increased by 5 & bATK by 4, but it's inverted.
Hercules Elf Bot - Jun 24, 2012 18:24
Originally posted by [b]Angezerus[/b]
[quote name='MarkZD' timestamp='1340561826' post='11171']
There's another problem: wATK should be increased by 5 & bATK by 4, but it's inverted.
[/quote]
[s]batk[/s] eatk
But right. Theres a post about it.
[quote name='MarkZD' timestamp='1340561826' post='11171']
There's another problem: wATK should be increased by 5 & bATK by 4, but it's inverted.
[/quote]
[s]batk[/s] eatk
But right. Theres a post about it.
Hercules Elf Bot - Jun 24, 2012 19:04
Originally posted by [b]MarkZD[/b]
I'm just saying bATK because there's not an eATK implemented in source and bATK is dealing a near damage as well currently.
So it's easy to understand.
I'm just saying bATK because there's not an eATK implemented in source and bATK is dealing a near damage as well currently.
So it's easy to understand.
Hercules Elf Bot - Jun 24, 2012 20:12
Originally posted by [b]Angezerus[/b]
[quote name='MarkZD' timestamp='1340564678' post='11175']
I'm just saying bATK because there's not an eATK implemented in source and bATK is dealing a near damage as well currently.So it's easy to understand.
[/quote]
Yes, but batk uses stats as well doesen't it? EDP should not affect anything that comes from stats.
[quote name='MarkZD' timestamp='1340564678' post='11175']
I'm just saying bATK because there's not an eATK implemented in source and bATK is dealing a near damage as well currently.So it's easy to understand.
[/quote]
Yes, but batk uses stats as well doesen't it? EDP should not affect anything that comes from stats.
Hercules Elf Bot - Jun 24, 2012 20:20
Originally posted by [b]MarkZD[/b]
[quote name='Angezerus' timestamp='1340568775' post='11178']
Yes, but batk uses stats as well doesen't it? EDP should not affect anything that comes from stats.
[/quote]
Yes, it'd be good if a dev could give some word here about it.
[quote name='Angezerus' timestamp='1340568775' post='11178']
Yes, but batk uses stats as well doesen't it? EDP should not affect anything that comes from stats.
[/quote]
Yes, it'd be good if a dev could give some word here about it.
This post has been edited by MarkZD on Jun 24, 2012 20:23
Hercules Elf Bot - Jun 24, 2012 20:52
Originally posted by [b]MarkZD[/b]
The main problem is that Atk calculation from Renewal is not implemented yet:
[quote name='Wildcard' timestamp='1332446808' post='7883']
I assume you are talking about renewal ATK here. The formula currently employed is indeed far from correct. Research on that subject is ongoing, but I expect it will be a while before we get it done.
[/quote]
[url="http://rathena.org/board/tracker/issue-5404-atk-calculation/page__gopid__7359#entry7359"]http://rathena.org/b..._7359#entry7359[/url]
So, if we want EDP to performs correctly, it has to be changed before.
The main problem is that Atk calculation from Renewal is not implemented yet:
[quote name='Wildcard' timestamp='1332446808' post='7883']
I assume you are talking about renewal ATK here. The formula currently employed is indeed far from correct. Research on that subject is ongoing, but I expect it will be a while before we get it done.
[/quote]
[url="http://rathena.org/board/tracker/issue-5404-atk-calculation/page__gopid__7359#entry7359"]http://rathena.org/b..._7359#entry7359[/url]
So, if we want EDP to performs correctly, it has to be changed before.
This post has been edited by MarkZD on Jun 24, 2012 20:54
Hercules Elf Bot - Jun 25, 2012 8:37
Originally posted by [b]InfectedX[/b]
so ._. is this skill bugged? also it affects to Boss monsters, xD i think that's a bug also...
so ._. is this skill bugged? also it affects to Boss monsters, xD i think that's a bug also...
Hercules Elf Bot - Jun 25, 2012 8:40
Originally posted by [b]Angezerus[/b]
[quote name='InfectedX' timestamp='1340613421' post='11209']
so ._. is this skill bugged? also it affects to Boss monsters, xD i think that's a bug also...
[/quote]
What do you mean? EDP should add damage on boss monsters as well, only the deadly poison status is not dealt.
[quote name='InfectedX' timestamp='1340613421' post='11209']
so ._. is this skill bugged? also it affects to Boss monsters, xD i think that's a bug also...
[/quote]
What do you mean? EDP should add damage on boss monsters as well, only the deadly poison status is not dealt.
Hercules Elf Bot - Jun 25, 2012 8:51
Originally posted by [b]InfectedX[/b]
yeah, that's what i said, the skill icon says:
"Damage Increase does not apply to Boss monsters"
So, i thought it's bugged
yeah, that's what i said, the skill icon says:
"Damage Increase does not apply to Boss monsters"
So, i thought it's bugged
Hercules Elf Bot - Jun 25, 2012 8:55
Originally posted by [b]Angezerus[/b]
[quote name='InfectedX' timestamp='1340614275' post='11211']
yeah, that's what i said, the skill icon says:"Damage Increase does not apply to Boss monsters"So, i thought it's bugged
[/quote]
Then it's a description error. Surely, it should add the damage regardless of boss or not, only the poison status sould not be passed.
[quote name='InfectedX' timestamp='1340614275' post='11211']
yeah, that's what i said, the skill icon says:"Damage Increase does not apply to Boss monsters"So, i thought it's bugged
[/quote]
Then it's a description error. Surely, it should add the damage regardless of boss or not, only the poison status sould not be passed.
Hercules Elf Bot - Jun 25, 2012 9:05
Originally posted by [b]InfectedX[/b]
oh i see...well i have to fix that later... anyway.
Then the last what the others has said is a real bug? i mean the GX and AssaX's damage with EDP is wrong?
oh i see...well i have to fix that later... anyway.
Then the last what the others has said is a real bug? i mean the GX and AssaX's damage with EDP is wrong?
Hercules Elf Bot - Jun 25, 2012 9:18
Originally posted by [b]Angezerus[/b]
[quote name='InfectedX' timestamp='1340615112' post='11213']
oh i see...well i have to fix that later... anyway.Then the last what the others has said is a real bug? i mean the GX and AssaX's damage with EDP is wrong?
[/quote]
Yes, because renewal atk is not fully implemented, and thus EDP increases wrong "stats"
[quote name='InfectedX' timestamp='1340615112' post='11213']
oh i see...well i have to fix that later... anyway.Then the last what the others has said is a real bug? i mean the GX and AssaX's damage with EDP is wrong?
[/quote]
Yes, because renewal atk is not fully implemented, and thus EDP increases wrong "stats"
Hercules Elf Bot - Jun 25, 2012 9:21
Originally posted by [b]InfectedX[/b]
okay then we have to wait until the rathena staff does something XD
okay then we have to wait until the rathena staff does something XD
Hercules Elf Bot - Jul 1, 2012 17:04
Originally posted by [b]GM Takumirai[/b]
- is this the correct fix??.. and where to edit those skills ...
- is this the correct fix??.. and where to edit those skills ...
Hercules Elf Bot - Jul 4, 2012 3:01
Originally posted by [b]jTynne[/b]
This is a pretty big issue for those of us running RE servers.
This is a pretty big issue for those of us running RE servers.
This post has been edited by jTynne on Jul 4, 2012 3:01
Hercules Elf Bot - Jul 5, 2012 8:16
Originally posted by [b]Angezerus[/b]
This is the damage increase effect of Enchant Deadly Poison. There is no such thing as %increase or %atk rate. To make it function properly, fully implemented renewal atk formula is required, as seen below.
[quote]
[u][b]ATK = sATK * 2 + wATK + eATK + masteries[/b][/u]
[u]STATUS ATK = floor ( Base level / 4 + STR + DEX / 5 + LUK / 3)[/u][list]
[*]Normally Neutral except when using Mild Wind.
[*]Ignores element resistance effects such as Raydric Card or Asprika.
[*]Ignores % ATK item effects such as The Sign or Hydra Card.
[/list]
[u]Weapon ATK = (Base Weapon ATK + Variance + STR + Bonus Refinement Bonus) * Size Penalty[/u]
Variance = ± 0.05 * Weapon Level * Base Weapon ATK
STR Bonus = Base Weapon ATK * STR/200[list]
[*]Affected by weapon element when using a melee weapon.
[*]Affected by ammunition element when using a ranged weapon or specific skill.
[*]Affected by element resistance effects such as Raydric Card or Asprika.
[*]Increased by % ATK item effects such as The Sign or Hydra Card.
[*][color=#ff0000][u][b]Multiplied by 5 when affected by Enchant Deadly Poison .[/b][/u][/color]
[*]Though the STR bonus takes Element , it is still considered Neutral .
[*]STR Bonus is always reduced by Ghost armor.
[*]STR Bonus is only reduced by Neutral resistance like Raydric card, if the weapon is Neutral too.
[*]Variance is a random number ranging from (-5% * Weapon Level * Base Weapon ATK) to (5% * Weapon Level * Base Weapon ATK)
[/list]
[u]Equipment ATK is the sum of ATK gained from equips other than weapons. Support buffs tend to increase this ATK, too, but not all of them fit into this category.[/u][list]
[*]Affected by weapon element when using a melee weapon.
[*]Affected by ammunition element when using a ranged weapon or specific skill.
[*]Ammunition ATK is added here when using DEX based weapon.
[*]Any +ATK you get from cards, including cards in weapon, is added here.
[*]Affected by element resistance effects like Raydric Card or Asprika.
[*]Increased by % ATK item effects like The Sign and Hydra Card.
[*][color=#ff0000][b][u]Multiplied by 4 when affected by Enchant Deadly Poison.[/u][/b][/color]
[/list]
[u]Mastery ATK is a special kind of ATK that has no elemental properties. While most masteries come from Passive Skills , there are some Active Skills such as Camouflage or Zen.[/u][list]
[*]Because masteries are not elemental, they are unaffected by Ghost armors or Raydric Cards.
[*]Since masteries are direct increases to ATK, they are affected by skill modifiers, DEF and damage increasing/decreasing effects.
[/list]
[/quote]
This is the damage increase effect of Enchant Deadly Poison. There is no such thing as %increase or %atk rate. To make it function properly, fully implemented renewal atk formula is required, as seen below.
[quote]
[u][b]ATK = sATK * 2 + wATK + eATK + masteries[/b][/u]
[u]STATUS ATK = floor ( Base level / 4 + STR + DEX / 5 + LUK / 3)[/u][list]
[*]Normally Neutral except when using Mild Wind.
[*]Ignores element resistance effects such as Raydric Card or Asprika.
[*]Ignores % ATK item effects such as The Sign or Hydra Card.
[/list]
[u]Weapon ATK = (Base Weapon ATK + Variance + STR + Bonus Refinement Bonus) * Size Penalty[/u]
Variance = ± 0.05 * Weapon Level * Base Weapon ATK
STR Bonus = Base Weapon ATK * STR/200[list]
[*]Affected by weapon element when using a melee weapon.
[*]Affected by ammunition element when using a ranged weapon or specific skill.
[*]Affected by element resistance effects such as Raydric Card or Asprika.
[*]Increased by % ATK item effects such as The Sign or Hydra Card.
[*][color=#ff0000][u][b]Multiplied by 5 when affected by Enchant Deadly Poison .[/b][/u][/color]
[*]Though the STR bonus takes Element , it is still considered Neutral .
[*]STR Bonus is always reduced by Ghost armor.
[*]STR Bonus is only reduced by Neutral resistance like Raydric card, if the weapon is Neutral too.
[*]Variance is a random number ranging from (-5% * Weapon Level * Base Weapon ATK) to (5% * Weapon Level * Base Weapon ATK)
[/list]
[u]Equipment ATK is the sum of ATK gained from equips other than weapons. Support buffs tend to increase this ATK, too, but not all of them fit into this category.[/u][list]
[*]Affected by weapon element when using a melee weapon.
[*]Affected by ammunition element when using a ranged weapon or specific skill.
[*]Ammunition ATK is added here when using DEX based weapon.
[*]Any +ATK you get from cards, including cards in weapon, is added here.
[*]Affected by element resistance effects like Raydric Card or Asprika.
[*]Increased by % ATK item effects like The Sign and Hydra Card.
[*][color=#ff0000][b][u]Multiplied by 4 when affected by Enchant Deadly Poison.[/u][/b][/color]
[/list]
[u]Mastery ATK is a special kind of ATK that has no elemental properties. While most masteries come from Passive Skills , there are some Active Skills such as Camouflage or Zen.[/u][list]
[*]Because masteries are not elemental, they are unaffected by Ghost armors or Raydric Cards.
[*]Since masteries are direct increases to ATK, they are affected by skill modifiers, DEF and damage increasing/decreasing effects.
[/list]
[/quote]
This post has been edited by Angezerus on Jul 5, 2012 8:18
Hercules Elf Bot - Jul 17, 2012 3:21
Originally posted by [b]Ainna[/b]
Just changed from rev 16304 to recent 16433 and edp behaves very odd.
rev 16433
Dex Sin normal attack edp + venom does about 50k each hit //ODD!
while edp crossimpact +venom does 16k each hit... //right but ...
rev 16304
Normal attack edp+venom ~16k autoattack // seems alright
Edp + Venom Crossimpact ~33k per hit //should be halved!?
Just changed from rev 16304 to recent 16433 and edp behaves very odd.
rev 16433
Dex Sin normal attack edp + venom does about 50k each hit //ODD!
while edp crossimpact +venom does 16k each hit... //right but ...
rev 16304
Normal attack edp+venom ~16k autoattack // seems alright
Edp + Venom Crossimpact ~33k per hit //should be halved!?
Hercules Elf Bot - Jul 17, 2012 7:31
Originally posted by [b]Angezerus[/b]
Still waiting for renewal attack
Still waiting for renewal attack
Hercules Elf Bot - Aug 8, 2012 6:57
Originally posted by [b]GM Takumirai[/b]
- just want to bump this because this is a major problem in us svn user.
- hope there is a temporary fix for this..
- just want to bump this because this is a major problem in us svn user.
- hope there is a temporary fix for this..
Hercules Elf Bot - Aug 10, 2012 11:04
Originally posted by [b]mofo[/b]
i agree, the damage modification is out of wack. hopefully this gets fixed soon. no pressure, just sayin. =)
i agree, the damage modification is out of wack. hopefully this gets fixed soon. no pressure, just sayin. =)
Hercules Elf Bot - Aug 10, 2012 13:48
Originally posted by [b]yuda236[/b]
maybe we can help with find the real formulation the real damage, is very good effort for rathena developer.
maybe we can help with find the real formulation the real damage, is very good effort for rathena developer.
Hercules Elf Bot - Sep 22, 2012 12:12
Originally posted by [b]donkeyg[/b]
got news on this?
got news on this?
Hercules Elf Bot - Sep 23, 2012 11:47
Originally posted by [b]donkeyg[/b]
bump
bump
Hercules Elf Bot - Sep 23, 2012 13:19
Originally posted by [b]malufett[/b]
@donkeyg
update your svn to [rev='16770'] or latest
@donkeyg
update your svn to [rev='16770'] or latest
Hercules Elf Bot - Oct 25, 2012 12:54
Originally posted by [b]Golem1988[/b]
So, It seems not solved yet?
I have the latest rev but cross impact still deals damage for about 25-35k...
So, It seems not solved yet?
I have the latest rev but cross impact still deals damage for about 25-35k...
malufett - Jun 12, 2013 18:58
Fixed @ 0395610469ffcd3b71c93ef90861f73e0ab8d16f
:meow:
:meow: