Hercules Elf Bot - Jul 3, 2012 0:13
Originally posted by [b]Daegaladh[/b]
Fix for Remove Trap skill.
Now it works exactly as it does on iRO (tested).
[CODE]
Index: skill.c
===================================================================
--- skill.c (revision 16366)
+++ skill.c (working copy)
@@ -6623,8 +6623,6 @@
case MA_REMOVETRAP:
case HT_REMOVETRAP:
- //FIXME: I think clif_skill_fail() is supposed to be sent if it fails below [ultramage]
- clif_skill_nodamage(src, bl, skillid, skilllv, 1);
{
struct skill_unit* su;
struct skill_unit_group* sg;
@@ -6634,6 +6632,7 @@
// Players can only remove their own traps or traps on Vs maps.
if( su && (sg = su->group) && (src->type == BL_MER || sg->src_id == src->id || map_flag_vs(bl->m)) && (skill_get_inf2(sg->skill_id)&INF2_TRAP) )
{
+ clif_skill_nodamage(src, bl, skillid, skilllv, 1);
if( sd && !(sg->unit_id == UNT_USED_TRAPS || (sg->unit_id == UNT_ANKLESNARE && sg->val2 != 0 )) )
{ // prevent picking up expired traps
if( battle_config.skill_removetrap_type )
@@ -6670,6 +6669,7 @@
}
skill_delunit(su);
}
+ else clif_skill_fail(sd,skillid,0,0);
}
break;
case HT_SPRINGTRAP:[/CODE]
Hercules Elf Bot - Jul 3, 2012 7:41
Originally posted by [b]malufett[/b]
Fixed @ [rev='16370']