Hercules Elf Bot - Jul 17, 2012 2:51
Originally posted by [b]Raizen[/b]
Hello, I was testing the emulator from Cronus-Emulator.com Project and spotted a problem in the ability AS_GRIMTOOTH, analyzing the code made ​​the correction:
in battle.c locate:
[CODE]
// FIX ME: Should Rolling Cutter be affected by EDP?
switch(skill_num){
case AS_SPLASHER: case AS_VENOMKNIFE:
case AS_GRIMTOOTH: case GC_ROLLINGCUTTER:
break;
#ifndef RENEWAL_EDP
[/CODE]
and replace to:
[CODE]
// FIX ME: Should Rolling Cutter be affected by EDP?
switch(skill_num){
case AS_SPLASHER: case AS_VENOMKNIFE:
case GC_ROLLINGCUTTER:
break;
#ifndef RENEWAL_EDP
[/CODE]
After, locate:
[CODE]
case GC_COUNTERSLASH:
case GC_CROSSIMPACT:
ATK_RATE(50); // only modifier is halved but still benefit with the damage bonus
break;
[/CODE]
and replace to:
[CODE]
case GC_COUNTERSLASH:
case GC_CROSSIMPACT:
case AS_GRIMTOOTH:
ATK_RATE(50); // only modifier is halved but still benefit with the damage bonus
break;
[/CODE]
Hercules Elf Bot - Jul 17, 2012 3:20
Originally posted by [b]Lighta[/b]
Not really, but actually you didn't state the issue, what you mean by not working ? seem working fine here.
Otherwise here the switch you talking about on latest revision :
switch(skill_num){
case AS_SPLASHER: case AS_VENOMKNIFE:
case AS_GRIMTOOTH: case GC_ROLLINGCUTTER:
break;
#ifndef RENEWAL_EDP
case ASC_BREAKER: case ASC_METEORASSAULT: break;
#else
case AS_SONICBLOW:
case ASC_BREAKER:
case GC_COUNTERSLASH:
case GC_CROSSIMPACT:
ATK_RATE(50); // only modifier is halved but still benefit with the damage bonus
break;
#endif
default:
ATK_ADDRATE(sc->data[SC_EDP]->val3);
}
The 1st part were AS_GRIMTOOTH set originilly is skill that doens't get the atk bonus from edp.
The second part where you put it is to halve dammge, actually I think this is a bit wrong since we can't have the bonus with this break neither, (we should have the bonus then halve imo).
Last part is default case for all other : to add edp bonus.
So in short even if it was correct you will halved GRIMTOOTH dammage and add EDP bonus. Irowiki state you shouldn't have bonus, so I think it's not right.
Hercules Elf Bot - Jul 17, 2012 4:15
Originally posted by [b]Raizen[/b]
I apologize, but before I do this modification, one of my users could not use the skill normally. I did not tested directly, just tried to fix the error and it really worked for him.
Hercules Elf Bot - Jul 18, 2012 1:05
Originally posted by [b]Raizen[/b]
Ok, i'm sorry, this is an bRO question. In iRO are correct.