bCastRate

Originally posted by [b]malufett[/b]
btw what are you using? Renewal mode??

Originally posted by [b]mkbu95[/b]
I tested using Renewal and indeed you have to remove the - in order to reduce the casting time.

Now, looking at pc_bonus2 in pc.c:[code]case SP_CASTRATE:
if(sd->skillcast[i].id == type2)
sd->skillcast[i].val += val;
else {
sd->skillcast[i].id = type2;
sd->skillcast[i].val = val;
}[/code] Changing to: [code]sd->skillcast[i].val -= val;[/code] in both branches, works.

Doing: [code]bonus2 bVariableCastrate,366,-100;[/code] will reduce the variable(?) casting time by 100%.
But setting [code]bonus2 bCastrate,366,-100;[/code] will increase it.

From the documentation:[code]bonus2 bCastrate,n,x; Adjust casting time of skill n by x% (supports skill names)
bonus2 bVariableCastrate,s,x; Increases variable cast time of skill s by x%. (supports skill names.)[/code]
They should do the same when you insert a negative value, but they're doing the opposite.

Originally posted by [b]malufett[/b]
no I did do nothing with [color=#000000][size=2][background=rgb(248, 248, 248)]SP_CASTRATE [/background][/size][/color]setting of value..
anyway the reason why its not working in renewal mode cause temporarily I remove its functionality by macro since I think there is no item that using it anymore(until the db devs update all re item)..but If I were wrong I'll restore it...

but I'll move this first to Databases to change all 'bCastrate' to 'bVariableCastrate'..
but please for those who will update return this if there is still item that uses 'bCastrate' in Renewal....

Originally posted by [b]mkbu95[/b]
Hmmm I see. You have a point on disabling bCastrate on re

Originally posted by [b]exneval[/b]
ya it's working with bvariablecastrate

Originally posted by [b]Kenpachi[/b]
Okay, I'll update the RE databases later.

Originally posted by [b]Natsu Dragneel[/b]
its working! removing - in bcastrate will remove casting. this is what I'm looking for to have instant cast with +9 gfist

Originally posted by [b]malufett[/b]
Bump!

Originally posted by [b]Spre[/b]
I changed all the bonus2 a while ago to variable. removing - does work, but the castrate function clearly states.

bonus bCastrate,n; Skill casting time rate + n%

No - should ADD cast time Not decrease it, this is the issue it is reversed, - adds no - decreases currently.

Originally posted by [b]malufett[/b]
Spre can you
[quote]Okay, I'll update the RE databases later.[/quote]

Thank you..

Originally posted by [b]Spre[/b]
yea, I have to go to work early (in a half hour Ill try to get the bonus bcastrate ones done now, if not ill get them done after work.

Originally posted by [b]Spre[/b]
I have fixed it, will be comitted when sourceforge is no longer borked, tried comitting and found out they had an outage which means our svn is down, nobody can update download or comitt with the current url

Originally posted by [b]kyeme[/b]
[url="http://trac.rathena.org/changeset/16826/rathena"]r16826[/url] Thanks Spre!!

Originally posted by [b]Spre[/b]
yea I was at work on lunch when i connected to my pc and comitted could not post it was fixed.

Fixed meaning castrate changed to variablecastrate untill castrate is determined to work properly.

Thanks kyeme