Deluge + Wall of Fog = Map-server Crash
Warning! This is the old Hercules bugtracker archive, and may not reflect the current state of Hercules. The current bugtracker is on GitHub Issues.
Issue information
Issue ID
#6584
Status
Fixed
Severity
Medium
Started
Hercules Elf Bot
Aug 29, 2012 15:08
Last Post
Mysterious
Jan 27, 2013 16:34
Confirmation
Hercules Elf Bot - Aug 29, 2012 15:08
Originally posted by [b]RaGERO[/b]
I have no custom src mods
Cast Deluge first and then overlap it with Wall of Fog, it crashes on my server using latest svn r16716
-- *EDIT* --
Also would like to add that some skills of Professor are bugged, Land Protection for example doesn't remove when you cast another Land Protection, same goes with some other ground target skills of Professor like that of Deluge + Wall of Fog.
I have no custom src mods
Cast Deluge first and then overlap it with Wall of Fog, it crashes on my server using latest svn r16716
-- *EDIT* --
Also would like to add that some skills of Professor are bugged, Land Protection for example doesn't remove when you cast another Land Protection, same goes with some other ground target skills of Professor like that of Deluge + Wall of Fog.
This post has been edited by RaGERO on Aug 29, 2012 15:25
Hercules Elf Bot - Aug 29, 2012 16:41
Originally posted by [b]malufett[/b]
cause of crash:
[CODE]
if (skillid == PF_FOGWALL && alive == 2)
{ //Double duration of cells on top of Deluge/Suiton
unit->limit *= 2;
group->limit = unit->limit;
}[/CODE]
cause of crash:
[CODE]
if (skillid == PF_FOGWALL && alive == 2)
{ //Double duration of cells on top of Deluge/Suiton
unit->limit *= 2;
group->limit = unit->limit;
}[/CODE]
Hercules Elf Bot - Aug 29, 2012 16:43
Originally posted by [b]RaGERO[/b]
So what's the fix sir?
So what's the fix sir?
Hercules Elf Bot - Aug 29, 2012 21:30
Originally posted by [b]wend[/b]
confirm
problem here, i think: (skil.c)
[CODE]map_foreachincell(skill_cell_overlap,src->m,ux,uy,BL_SKILL,skillid, src);[/CODE]
should be:
[CODE]map_foreachincell(skill_cell_overlap,src->m,ux,uy,BL_SKILL,skillid,&alive,src);[/CODE]
confirm
problem here, i think: (skil.c)
[CODE]map_foreachincell(skill_cell_overlap,src->m,ux,uy,BL_SKILL,skillid, src);[/CODE]
should be:
[CODE]map_foreachincell(skill_cell_overlap,src->m,ux,uy,BL_SKILL,skillid,&alive,src);[/CODE]
This post has been edited by wend on Aug 29, 2012 21:31
Hercules Elf Bot - Aug 29, 2012 23:18
Originally posted by [b]RaGERO[/b]
[quote name='wend' timestamp='1346275853' post='13872']
confirmproblem here, i think: (skil.c)[CODE]map_foreachincell(skill_cell_overlap,src->m,ux,uy,BL_SKILL,skillid, src);[/CODE]should be:[CODE]map_foreachincell(skill_cell_overlap,src->m,ux,uy,BL_SKILL,skillid,&alive,src);[/CODE]
[/quote]
Confirmed fixed!
Thanks wend! Also looked at the older revisions and there's '&alive' value in the function.
This also fixed the LP + Safety Wall issue and LP overlapping with other Prof's LP.
[quote name='wend' timestamp='1346275853' post='13872']
confirmproblem here, i think: (skil.c)[CODE]map_foreachincell(skill_cell_overlap,src->m,ux,uy,BL_SKILL,skillid, src);[/CODE]should be:[CODE]map_foreachincell(skill_cell_overlap,src->m,ux,uy,BL_SKILL,skillid,&alive,src);[/CODE]
[/quote]
Confirmed fixed!
Thanks wend! Also looked at the older revisions and there's '&alive' value in the function.
This also fixed the LP + Safety Wall issue and LP overlapping with other Prof's LP.
This post has been edited by RaGERO on Aug 29, 2012 23:45
Hercules Elf Bot - Aug 30, 2012 0:02
Originally posted by [b]Ind[/b]
blame on [rev=16687]
blame on [rev=16687]
Hercules Elf Bot - Aug 30, 2012 0:07
Originally posted by [b]Ind[/b]
Fixed in [rev=16719]
Fixed in [rev=16719]