Bard skill issue !!
Warning! This is the old Hercules bugtracker archive, and may not reflect the current state of Hercules. The current bugtracker is on GitHub Issues.
Issue information
Issue ID
#6606
Status
Confirmed
Severity
Medium
Started
Hercules Elf Bot
Sep 2, 2012 10:28
Last Post
Mysterious
Jan 19, 2013 19:17
Confirmation
Hercules Elf Bot - Sep 2, 2012 10:28
Originally posted by [b]Phantasm[/b]
Require: two Bard and main-char will receive buff.
Hot-key like this:
[img]http://i1185.photobucket.com/albums/z341/miganda1009/issual.jpg[/img]
How to produce:
Step 1:[b]Bard 2[/b] use skill [b]Poem of Bragi[/b] then use skill [b]Adaptation to Circumstances.[/b]
Step 2: [b]Bard 1[/b] use skill [b]Poem of Bragi[/b] then use skill [b]Adaptation to Circumstances.[/b]
Step 3:[b]Bard 2[/b] use skill [b]Poem of Bragi[/b]
Step 4:[b]Bard 1[/b] use skil[b]l A Whistle[/b]
Step 5: [b]Bard 1 and Bard 2 use [/b][b]Adaptation to Circumstances.[/b]
Then i can use skill almost without delay, duration ~ 2 minute. Normal just 30s i think
You can do that with Apple of Idun.
I havent check other skill.
Sorry my bad English...
Require: two Bard and main-char will receive buff.
Hot-key like this:
[img]http://i1185.photobucket.com/albums/z341/miganda1009/issual.jpg[/img]
How to produce:
Step 1:[b]Bard 2[/b] use skill [b]Poem of Bragi[/b] then use skill [b]Adaptation to Circumstances.[/b]
Step 2: [b]Bard 1[/b] use skill [b]Poem of Bragi[/b] then use skill [b]Adaptation to Circumstances.[/b]
Step 3:[b]Bard 2[/b] use skill [b]Poem of Bragi[/b]
Step 4:[b]Bard 1[/b] use skil[b]l A Whistle[/b]
Step 5: [b]Bard 1 and Bard 2 use [/b][b]Adaptation to Circumstances.[/b]
Then i can use skill almost without delay, duration ~ 2 minute. Normal just 30s i think
You can do that with Apple of Idun.
I havent check other skill.
Sorry my bad English...
This post has been edited by Phantasm on Sep 2, 2012 18:10
Hercules Elf Bot - Sep 3, 2012 2:56
Originally posted by [b]Phantasm[/b]
Bump.
Can someone [color=#000000][font=helvetica, arial, sans-serif][size=1][b][background=rgb(240, 243, 164)]CONFIRM [/background][/b][/size][/font][/color]it ?
Its normal ?
Bump.
Can someone [color=#000000][font=helvetica, arial, sans-serif][size=1][b][background=rgb(240, 243, 164)]CONFIRM [/background][/b][/size][/font][/color]it ?
Its normal ?
Hercules Elf Bot - Sep 3, 2012 3:08
Originally posted by [b]malufett[/b]
sorry can't reproduce..
sorry can't reproduce..
Hercules Elf Bot - Sep 4, 2012 16:40
Originally posted by [b]Phantasm[/b]
[quote name='malufett' timestamp='1346641736' post='14019']
sorry can't reproduce..
[/quote]
malufett, please check it again.
Here my Video recorder how to produce it, watch it in quality 480.
[url="http://www.youtube.com/watch?hl=en&v=k8SEgmJNv5Y"]http://www.youtube.com/watch?hl=en&v=k8SEgmJNv5Y[/url]
I have been using SVN 16738, i dont MOD anything.
Check it again ~~~~
[quote name='malufett' timestamp='1346641736' post='14019']
sorry can't reproduce..
[/quote]
malufett, please check it again.
Here my Video recorder how to produce it, watch it in quality 480.
[url="http://www.youtube.com/watch?hl=en&v=k8SEgmJNv5Y"]http://www.youtube.com/watch?hl=en&v=k8SEgmJNv5Y[/url]
I have been using SVN 16738, i dont MOD anything.
Check it again ~~~~
Hercules Elf Bot - Sep 5, 2012 3:07
Originally posted by [b]malufett[/b]
[sub]I think I need a strong/super fast machine..what I saw in your video you do it faster/at the same time..[/sub]
[sub]cause when I do it theres is a 10~15 seconds delay when I shifted to window by window(sorry I'm a poor guy)..XD[/sub]
anyway I'll try to do my best to duplicate it..
[sub][/sub]
[sub]I think I need a strong/super fast machine..what I saw in your video you do it faster/at the same time..[/sub]
[sub]cause when I do it theres is a 10~15 seconds delay when I shifted to window by window(sorry I'm a poor guy)..XD[/sub]
anyway I'll try to do my best to duplicate it..
[sub]
[/sub]
Hercules Elf Bot - Sep 5, 2012 4:18
Originally posted by [b]Phantasm[/b]
[color=#282828][font=helvetica, arial, sans-serif][size=3]Step 1:[/size][/font][/color][b]Bard 2[/b][color=#282828][font=helvetica, arial, sans-serif][size=3] use skill [/size][/font][/color][b]Poem of Bragi[/b][color=#282828][font=helvetica, arial, sans-serif][size=3] then use skill [/size][/font][/color][b]Adaptation to Circumstances.[/b]
[color=#282828][font=helvetica, arial, sans-serif][size=3]Step 2: [/size][/font][/color][b]Bard 1[/b][color=#282828][font=helvetica, arial, sans-serif][size=3] use skill [/size][/font][/color][b]Poem of Bragi[/b][color=#282828][font=helvetica, arial, sans-serif][size=3] then use skill [/size][/font][/color][b]Adaptation to Circumstances.[/b]
[color=#282828][font=helvetica, arial, sans-serif][size=3]Step 3:[/size][/font][/color][b]Bard 2[/b][color=#282828][font=helvetica, arial, sans-serif][size=3] use skill [/size][/font][/color][b]Poem of Bragi[/b]
[color=#282828][font=helvetica, arial, sans-serif][size=3]Step 4:[/size][/font][/color][b]Bard 1[/b][color=#282828][font=helvetica, arial, sans-serif][size=3] use skil[/size][/font][/color][b]l A Whistle[/b]
[color=#282828][font=helvetica, arial, sans-serif][size=3]Step 5: [/size][/font][/color][b]Bard 1 and Bard 2 use [/b][b]Adaptation to Circumstances.[/b]
[u][b]The key is: Step 4 and 5.[/b][/u]
[b]You make me embarrassed when you say you are foor guy [/b]
I must try harder
Now I was still a student so I can not help you all
Try up.
My English not good, sorry.
[color=#282828][font=helvetica, arial, sans-serif][size=3]Step 1:[/size][/font][/color][b]Bard 2[/b][color=#282828][font=helvetica, arial, sans-serif][size=3] use skill [/size][/font][/color][b]Poem of Bragi[/b][color=#282828][font=helvetica, arial, sans-serif][size=3] then use skill [/size][/font][/color][b]Adaptation to Circumstances.[/b]
[color=#282828][font=helvetica, arial, sans-serif][size=3]Step 2: [/size][/font][/color][b]Bard 1[/b][color=#282828][font=helvetica, arial, sans-serif][size=3] use skill [/size][/font][/color][b]Poem of Bragi[/b][color=#282828][font=helvetica, arial, sans-serif][size=3] then use skill [/size][/font][/color][b]Adaptation to Circumstances.[/b]
[color=#282828][font=helvetica, arial, sans-serif][size=3]Step 3:[/size][/font][/color][b]Bard 2[/b][color=#282828][font=helvetica, arial, sans-serif][size=3] use skill [/size][/font][/color][b]Poem of Bragi[/b]
[color=#282828][font=helvetica, arial, sans-serif][size=3]Step 4:[/size][/font][/color][b]Bard 1[/b][color=#282828][font=helvetica, arial, sans-serif][size=3] use skil[/size][/font][/color][b]l A Whistle[/b]
[color=#282828][font=helvetica, arial, sans-serif][size=3]Step 5: [/size][/font][/color][b]Bard 1 and Bard 2 use [/b][b]Adaptation to Circumstances.[/b]
[u][b]The key is: Step 4 and 5.[/b][/u]
[b]You make me embarrassed when you say you are foor guy [/b]
I must try harder
Now I was still a student so I can not help you all
Try up.
My English not good, sorry.
Hercules Elf Bot - Sep 16, 2012 12:31
Originally posted by [b]Lunar[/b]
I can confirm this, I have a explanation, and a solution :
There is a link with [url="http://rathena.org/board/tracker/issue-6523-3-minutes-buff-songs-effects-using-duel/"]this issue[/url].
[CODE]
static int skill_unit_effect (struct block_list* bl, va_list ap)
{
struct skill_unit* unit = va_arg(ap,struct skill_unit*);
struct skill_unit_group* group = unit->group;
unsigned int tick = va_arg(ap,unsigned int);
unsigned int flag = va_arg(ap,unsigned int);
int skill_id;
bool dissonance;
if( (!unit->alive && !(flag&4)) || bl->prev == NULL )
return 0;
nullpo_ret(group);
dissonance = skill_dance_switch(unit, 0); // <----- Here is the trouble
//Necessary in case the group is deleted after calling on_place/on_out [Skotlex]
skill_id = group->skill_id;
//Target-type check.
if( !(group->bl_flag&bl->type && battle_check_target(&unit->bl,bl,group->target_flag)>0) )
{
if( flag&4 && group->src_id == bl->id && group->state.song_dance&0x2 )
skill_unit_onleft(skill_id, bl, tick);//Ensemble check to terminate it.
else if ( flag&4 && skill_get_inf2(skill_id)&INF2_SONG_DANCE) // Make a exception for song/dance skill
skill_unit_onleft(unit->val1, bl, tick); // <----- Using unit->val1 instead of skill_id !
}
else
{
if( flag&1 )
skill_unit_onplace(unit,bl,tick);
else
skill_unit_onout(unit,bl,tick);
if( flag&4 )
skill_unit_onleft(skill_id, bl, tick);
}
if( dissonance ) skill_dance_switch(unit, 1);
return 0;
}
[/CODE]
With my fix, [b]skill_unit_onleft[/b] is use, but the [b]skill_id value[/b] is wrong, skill_id is equal to [b]317[/b] (dissonnance id) because of [b]skill_dance_switch(unit, 0)[/b] Function
so that's why in this fix i use [b]unit->val1[/b], which is the right skill_id.
I know it is a bad way to fix that, but it works.
Better way would be to fix [b]skill_dance_switch[/b] function, but i don't know the role of this function.
I can confirm this, I have a explanation, and a solution :
There is a link with [url="http://rathena.org/board/tracker/issue-6523-3-minutes-buff-songs-effects-using-duel/"]this issue[/url].
[CODE]
static int skill_unit_effect (struct block_list* bl, va_list ap)
{
struct skill_unit* unit = va_arg(ap,struct skill_unit*);
struct skill_unit_group* group = unit->group;
unsigned int tick = va_arg(ap,unsigned int);
unsigned int flag = va_arg(ap,unsigned int);
int skill_id;
bool dissonance;
if( (!unit->alive && !(flag&4)) || bl->prev == NULL )
return 0;
nullpo_ret(group);
dissonance = skill_dance_switch(unit, 0); // <----- Here is the trouble
//Necessary in case the group is deleted after calling on_place/on_out [Skotlex]
skill_id = group->skill_id;
//Target-type check.
if( !(group->bl_flag&bl->type && battle_check_target(&unit->bl,bl,group->target_flag)>0) )
{
if( flag&4 && group->src_id == bl->id && group->state.song_dance&0x2 )
skill_unit_onleft(skill_id, bl, tick);//Ensemble check to terminate it.
else if ( flag&4 && skill_get_inf2(skill_id)&INF2_SONG_DANCE) // Make a exception for song/dance skill
skill_unit_onleft(unit->val1, bl, tick); // <----- Using unit->val1 instead of skill_id !
}
else
{
if( flag&1 )
skill_unit_onplace(unit,bl,tick);
else
skill_unit_onout(unit,bl,tick);
if( flag&4 )
skill_unit_onleft(skill_id, bl, tick);
}
if( dissonance ) skill_dance_switch(unit, 1);
return 0;
}
[/CODE]
With my fix, [b]skill_unit_onleft[/b] is use, but the [b]skill_id value[/b] is wrong, skill_id is equal to [b]317[/b] (dissonnance id) because of [b]skill_dance_switch(unit, 0)[/b] Function
so that's why in this fix i use [b]unit->val1[/b], which is the right skill_id.
I know it is a bad way to fix that, but it works.
Better way would be to fix [b]skill_dance_switch[/b] function, but i don't know the role of this function.
This post has been edited by Lunar on Nov 12, 2012 5:52
Hercules Elf Bot - Sep 27, 2012 14:29
Originally posted by [b]Lunar[/b]
bumb, need more info ?
bumb, need more info ?
Hercules Elf Bot - Nov 12, 2012 5:52
Originally posted by [b]Lunar[/b]
bump again ;( [url="http://trac.rathena.org/changeset/16881"]r16881[/url] doesn't fix it !
bump again ;( [url="http://trac.rathena.org/changeset/16881"]r16881[/url] doesn't fix it !
This post has been edited by Lunar on Nov 12, 2012 5:55
Hercules Elf Bot - Nov 21, 2012 19:33
Originally posted by [b]Napster[/b]
confirm this problem doesn't fix
confirm this problem doesn't fix
Hercules Elf Bot - Nov 21, 2012 21:35
Originally posted by [b]mkbu95[/b]
Just editting, I got some time and I'm gonna try to reproduce this.
Just editting, I got some time and I'm gonna try to reproduce this.
This post has been edited by mkbu95 on Nov 22, 2012 21:47
Hercules Elf Bot - Nov 29, 2012 5:07
Originally posted by [b]arun89[/b]
bump +1
bump +1
Hercules Elf Bot - Dec 1, 2012 6:48
Originally posted by [b]arun89[/b]
bump
bump
Hercules Elf Bot - Dec 3, 2012 12:53
Originally posted by [b]donkeyg[/b]
Bump + 1 , any solution
Bump + 1 , any solution
This post has been edited by donkeyg on Dec 3, 2012 12:53
Hercules Elf Bot - Dec 9, 2012 0:46
Originally posted by [b]mkbu95[/b]
Hopefully and let's pray, fixed in [rev=17011].
Thankyou again Lunar
Hopefully and let's pray, fixed in [rev=17011].
Thankyou again Lunar
Hercules Elf Bot - Dec 10, 2012 20:59
Originally posted by [b]Hobbix[/b]
Not fixed again!
[b]Step 1[/b].
[URL=http://imageshack.us/photo/my-images/823/32487928.jpg/][IMG]http://imageshack.us/a/img823/2130/32487928.th.jpg[/IMG][/URL]
[b]Step 2[/b].
[URL=http://imageshack.us/photo/my-images/14/78365410.jpg/][IMG]http://imageshack.us/a/img14/1690/78365410.th.jpg[/IMG][/URL]
[b]Step 3[/b].
[URL=http://imageshack.us/photo/my-images/838/62488823.jpg/][IMG]http://imageshack.us/a/img838/6959/62488823.th.jpg[/IMG][/URL]
[b]Step 4[/b].
[URL=http://imageshack.us/photo/my-images/805/46501082.jpg/][IMG]http://imageshack.us/a/img805/3478/46501082.th.jpg[/IMG][/URL]
Not fixed again!
[b]Step 1[/b].
[URL=http://imageshack.us/photo/my-images/823/32487928.jpg/][IMG]http://imageshack.us/a/img823/2130/32487928.th.jpg[/IMG][/URL]
[b]Step 2[/b].
[URL=http://imageshack.us/photo/my-images/14/78365410.jpg/][IMG]http://imageshack.us/a/img14/1690/78365410.th.jpg[/IMG][/URL]
[b]Step 3[/b].
[URL=http://imageshack.us/photo/my-images/838/62488823.jpg/][IMG]http://imageshack.us/a/img838/6959/62488823.th.jpg[/IMG][/URL]
[b]Step 4[/b].
[URL=http://imageshack.us/photo/my-images/805/46501082.jpg/][IMG]http://imageshack.us/a/img805/3478/46501082.th.jpg[/IMG][/URL]
Hercules Elf Bot - Dec 12, 2012 5:33
Originally posted by [b]Hobbix[/b]
Bump!
http://rathena.org/board/tracker/issue-5038-songsdances-and-dissonance-effect/
http://rathena.org/board/tracker/issue-5571-bragi-overlap-bragi/
http://rathena.org/board/tracker/issue-6523-3-minutes-buff-songs-effects-using-duel/
etc...
Bump!
http://rathena.org/board/tracker/issue-5038-songsdances-and-dissonance-effect/
http://rathena.org/board/tracker/issue-5571-bragi-overlap-bragi/
http://rathena.org/board/tracker/issue-6523-3-minutes-buff-songs-effects-using-duel/
etc...
Hercules Elf Bot - Dec 12, 2012 11:34
Originally posted by [b]Napster[/b]
confirm dose't fix again
I think problem found in function status change clear timer
btw sc_dancer
confirm dose't fix again
I think problem found in function status change clear timer
btw sc_dancer
Hercules Elf Bot - Dec 12, 2012 13:50
Originally posted by [b]mkbu95[/b]
Hell!
I leave to another dev then, I shouldn't even have began this
Hell!
I leave to another dev then, I shouldn't even have began this
Hercules Elf Bot - Dec 12, 2012 22:27
Originally posted by [b]MarkZD[/b]
Fixed at: [url="http://trac.rathena.org/changeset/17020/rathena"]17020[/url]
Fixed at: [url="http://trac.rathena.org/changeset/17020/rathena"]17020[/url]
Hercules Elf Bot - Dec 12, 2012 22:31
Originally posted by [b]MarkZD[/b]
[s]My diff didn't upload completely, just some minutes.[/s]
Never mind, it's ok now.
At least I can't reproduce it anymore.
[s]My diff didn't upload completely, just some minutes.[/s]
Never mind, it's ok now.
At least I can't reproduce it anymore.
This post has been edited by MarkZD on Dec 12, 2012 22:53
Hercules Elf Bot - Dec 13, 2012 0:36
Originally posted by [b]Hobbix[/b]
Not fixed again!
How to reproduce the bug (video): http://www.sendspace.com/file/gc8uo6
Not fixed again!
How to reproduce the bug (video): http://www.sendspace.com/file/gc8uo6
Hercules Elf Bot - Dec 13, 2012 3:26
Originally posted by [b]MarkZD[/b]
[quote name='Hobbix' timestamp='1355359000' post='16350']
Not fixed again!How to reproduce the bug (video): [url="http://www.sendspace.com/file/gc8uo6"]http://www.sendspace.com/file/gc8uo6[/url]
[/quote]
What I saw in the video is that u didn't update ur revision, because status ended prematurely on the bard. ;D
Update, test, so if it bugs come back. Thanks.
[quote name='Hobbix' timestamp='1355359000' post='16350']
Not fixed again!How to reproduce the bug (video): [url="http://www.sendspace.com/file/gc8uo6"]http://www.sendspace.com/file/gc8uo6[/url]
[/quote]
What I saw in the video is that u didn't update ur revision, because status ended prematurely on the bard. ;D
Update, test, so if it bugs come back. Thanks.
This post has been edited by MarkZD on Dec 13, 2012 3:27
Hercules Elf Bot - Dec 13, 2012 4:11
Originally posted by [b]Hobbix[/b]
[b]MarkZD[/b], tested on revision 17020, course revision has been updated. Bug still not fixed, try to repeat the same as in my video.
[b]MarkZD[/b], tested on revision 17020, course revision has been updated. Bug still not fixed, try to repeat the same as in my video.
Hercules Elf Bot - Dec 13, 2012 4:23
Originally posted by [b]MarkZD[/b]
[quote name='Hobbix' timestamp='1355371867' post='16352']
[b]MarkZD[/b], tested on revision 17020, course revision has been updated. Bug still not fixed, try to repeat the same as in my video.
[/quote]
I repeated the same you did in your video, as well as the other video in this same topic, which I could reproduce on a older revision.
I'd make a video, but it becomes very slow when I record. e_e
[u]Did you recompiled?[/u]
Also check if you don't have custom code on skill.c cause it might have caused the file to not update.
And I'm just saying you didn't update because the right bard in your video gets the status canceled very soon.
After my update it doesn't get instantly canceled after the bard use Adaptation to circumstances or the skill stops as it's in your video. ;D
[quote name='Hobbix' timestamp='1355371867' post='16352']
[b]MarkZD[/b], tested on revision 17020, course revision has been updated. Bug still not fixed, try to repeat the same as in my video.
[/quote]
I repeated the same you did in your video, as well as the other video in this same topic, which I could reproduce on a older revision.
I'd make a video, but it becomes very slow when I record. e_e
[u]Did you recompiled?[/u]
Also check if you don't have custom code on skill.c cause it might have caused the file to not update.
And I'm just saying you didn't update because the right bard in your video gets the status canceled very soon.
After my update it doesn't get instantly canceled after the bard use Adaptation to circumstances or the skill stops as it's in your video. ;D
This post has been edited by MarkZD on Dec 13, 2012 4:47
Hercules Elf Bot - Dec 13, 2012 7:34
Originally posted by [b]Hobbix[/b]
[b]MarkZD[/b], yes. Pure rAthena 17020 https://rathena.svn.sourceforge.net/svnroot/rathena/trunk/.
[b]MarkZD[/b], yes. Pure rAthena 17020 https://rathena.svn.sourceforge.net/svnroot/rathena/trunk/.
Hercules Elf Bot - Dec 13, 2012 16:36
Originally posted by [b]MarkZD[/b]
[quote name='Hobbix' timestamp='1355384075' post='16355']
[b]MarkZD[/b], yes. Pure rAthena 17020 [url="https://rathena.svn.sourceforge.net/svnroot/rathena/trunk/."]https://rathena.svn....rathena/trunk/.[/url]
[/quote]
[s]The odd part is that a can't reproduce it anymore, despite I got it before.
I just reverted source and fixed a bug which was ending it to the caster before than it should, but I'm unable to reproduce it now, but I'll keep trying.
Yep, it doesn't make much sense.
I already tried all the videos you showed, I even created new steps without success on reproducing.
SInce, I'm unable to reproduce I'll just set it to new, so any other dev is free to figure it.[/s]
Ok, I was missing a part.
The problem is that the current system saves the limits on src->group, so when onleft or onplace the last time is taken and added to the current one without distinction between skills, something like that.
[quote name='Hobbix' timestamp='1355384075' post='16355']
[b]MarkZD[/b], yes. Pure rAthena 17020 [url="https://rathena.svn.sourceforge.net/svnroot/rathena/trunk/."]https://rathena.svn....rathena/trunk/.[/url]
[/quote]
[s]The odd part is that a can't reproduce it anymore, despite I got it before.
I just reverted source and fixed a bug which was ending it to the caster before than it should, but I'm unable to reproduce it now, but I'll keep trying.
Yep, it doesn't make much sense.
I already tried all the videos you showed, I even created new steps without success on reproducing.
SInce, I'm unable to reproduce I'll just set it to new, so any other dev is free to figure it.[/s]
Ok, I was missing a part.
The problem is that the current system saves the limits on src->group, so when onleft or onplace the last time is taken and added to the current one without distinction between skills, something like that.
This post has been edited by MarkZD on Dec 13, 2012 17:18