skill_readdb()
Warning! This is the old Hercules bugtracker archive, and may not reflect the current state of Hercules. The current bugtracker is on GitHub Issues.
Issue information
Issue ID
#6692
Status
Fixed
Severity
None
Started
Hercules Elf Bot
Sep 13, 2012 21:34
Last Post
Hercules Elf Bot
Sep 22, 2012 4:01
Confirmation
Hercules Elf Bot - Sep 13, 2012 21:34
Originally posted by [b]Akkarin[/b]
[rev=16776] Added the IFDEF RENEWAL, then updated in [rev=16778] (renamed re-pre to pre-re)
As it stands, i get errors on my dev server. Shouldn't that line be:
[code]sv_readdb(db_path, "pre-re/skill_cast_db.txt" , ',', 7, 8, MAX_SKILL_DB, skill_parse_row_castdb);[/code]
At the moment, it's not reading some lines due to there being 8 parameters.
[rev=16776] Added the IFDEF RENEWAL, then updated in [rev=16778] (renamed re-pre to pre-re)
As it stands, i get errors on my dev server. Shouldn't that line be:
[code]sv_readdb(db_path, "pre-re/skill_cast_db.txt" , ',', 7, 8, MAX_SKILL_DB, skill_parse_row_castdb);[/code]
At the moment, it's not reading some lines due to there being 8 parameters.
Hercules Elf Bot - Sep 13, 2012 23:39
Originally posted by [b]Lighta[/b]
Or they both could use DBPATH as I believe that why it was for.
(Only change would be the min and max column to parse then, won,t change much cus if I recall they'll be default to 0 if nothing there..)
Or they both could use DBPATH as I believe that why it was for.
(Only change would be the min and max column to parse then, won,t change much cus if I recall they'll be default to 0 if nothing there..)
Hercules Elf Bot - Sep 14, 2012 0:01
Originally posted by [b]Akkarin[/b]
The min and max were indeed changed, which broke something. The min/max were changed from 7-8 to 7-7, and as some of the skills have 8 columns, they were no longer read.
This is from [rev=16776]:
[code]
- sv_readdb(db_path, DBPATH"skill_cast_db.txt" , ',', 7, 8, MAX_SKILL_DB, skill_parse_row_castdb);
+#ifdef RENEWAL
+ sv_readdb(db_path, "re/skill_cast_db.txt" , ',', 8, 8, MAX_SKILL_DB, skill_parse_row_castdb);
+#else
+ sv_readdb(db_path, "re-pre/skill_cast_db.txt" , ',', 7, 7, MAX_SKILL_DB, skill_parse_row_castdb);
+#endif
[/code]
The min and max were indeed changed, which broke something. The min/max were changed from 7-8 to 7-7, and as some of the skills have 8 columns, they were no longer read.
This is from [rev=16776]:
[code]
- sv_readdb(db_path, DBPATH"skill_cast_db.txt" , ',', 7, 8, MAX_SKILL_DB, skill_parse_row_castdb);
+#ifdef RENEWAL
+ sv_readdb(db_path, "re/skill_cast_db.txt" , ',', 8, 8, MAX_SKILL_DB, skill_parse_row_castdb);
+#else
+ sv_readdb(db_path, "re-pre/skill_cast_db.txt" , ',', 7, 7, MAX_SKILL_DB, skill_parse_row_castdb);
+#endif
[/code]
This post has been edited by Akkarin on Sep 14, 2012 0:02
Hercules Elf Bot - Sep 14, 2012 0:57
Originally posted by [b]malufett[/b]
[quote]
[color=#282828][font=helvetica, arial, sans-serif][size=3](Only change would be the min and max column to parse then, won,t change much cus if I recall they'll be default to 0 if nothing there..)[/size][/font][/color]
[color=#282828][font=helvetica, arial, sans-serif][size=3]The min and max were indeed changed, which broke something. The min/max were changed from 7-8 to 7-7, and as some of the skills have 8 columns, they were no longer read.[/size][/font][/color]
[/quote]
working as intended..since fixed cast time in re is not anymore optional...and I don't think there is a 8 columns in pre..
[quote]
[color=#282828][font=helvetica, arial, sans-serif][size=3](Only change would be the min and max column to parse then, won,t change much cus if I recall they'll be default to 0 if nothing there..)[/size][/font][/color]
[color=#282828][font=helvetica, arial, sans-serif][size=3]The min and max were indeed changed, which broke something. The min/max were changed from 7-8 to 7-7, and as some of the skills have 8 columns, they were no longer read.[/size][/font][/color]
[/quote]
working as intended..since fixed cast time in re is not anymore optional...and I don't think there is a 8 columns in pre..
Hercules Elf Bot - Sep 14, 2012 2:29
Originally posted by [b]Akkarin[/b]
There's a few:
[code]
//-- GN_HELLS_PLANT
2490,3000:3500:4000:4500:5000,500,0,14000:21000:28000:35000:42000,0,0,0
[/code]
There's a few:
[code]
//-- GN_HELLS_PLANT
2490,3000:3500:4000:4500:5000,500,0,14000:21000:28000:35000:42000,0,0,0
[/code]
Hercules Elf Bot - Sep 14, 2012 2:55
Originally posted by [b]malufett[/b]
but the question is..is it needed in pre?
but the question is..is it needed in pre?
Hercules Elf Bot - Sep 14, 2012 12:53
Originally posted by [b]Akkarin[/b]
If it's not needed, it shouldn't still be in the pre-re/skill_cast_db.txt file
If it's not needed, it shouldn't still be in the pre-re/skill_cast_db.txt file
Hercules Elf Bot - Sep 14, 2012 13:21
Originally posted by [b]malufett[/b]
maybe its a typo..hahaha
maybe its a typo..hahaha
Hercules Elf Bot - Sep 15, 2012 11:06
Originally posted by [b]botka4aet[/b]
Up!
https://rathena.svn.sourceforge.net/svnroot/rathena/trunk/db/pre-re/skill_cast_db.txt
693,0,0,0,0,0,300000,0
1-2-3-4-5-6-7-8
And have error
[Error]: sv_readdb: Too many columns in line 1027 of "db/pre-re/skill_cast_db.txt" (found 8, maximum is 7).
Up!
https://rathena.svn.sourceforge.net/svnroot/rathena/trunk/db/pre-re/skill_cast_db.txt
693,0,0,0,0,0,300000,0
1-2-3-4-5-6-7-8
And have error
[Error]: sv_readdb: Too many columns in line 1027 of "db/pre-re/skill_cast_db.txt" (found 8, maximum is 7).
Hercules Elf Bot - Sep 15, 2012 11:46
Originally posted by [b]kyeme[/b]
[quote name='botka4aet' timestamp='1347707207' post='14470']
Up![url="https://rathena.svn.sourceforge.net/svnroot/rathena/trunk/db/pre-re/skill_cast_db.txt"]https://rathena.svn....ill_cast_db.txt[/url]693,0,0,0,0,0,300000,01-2-3-4-5-6-7-8And have error[Error]: sv_readdb: Too many columns in line 1027 of "db/pre-re/skill_cast_db.txt" (found 8, maximum is 7).
[/quote]
Like this ? [post=13914]post:13914[/post]
[quote name='botka4aet' timestamp='1347707207' post='14470']
Up![url="https://rathena.svn.sourceforge.net/svnroot/rathena/trunk/db/pre-re/skill_cast_db.txt"]https://rathena.svn....ill_cast_db.txt[/url]693,0,0,0,0,0,300000,01-2-3-4-5-6-7-8And have error[Error]: sv_readdb: Too many columns in line 1027 of "db/pre-re/skill_cast_db.txt" (found 8, maximum is 7).
[/quote]
Like this ? [post=13914]post:13914[/post]
This post has been edited by Brian on Sep 15, 2012 16:27
Hercules Elf Bot - Sep 15, 2012 11:59
Originally posted by [b]botka4aet[/b]
[quote name='malufett' timestamp='1347584260' post='14429']
[quote][color=#282828][font=helvetica, arial, sans-serif][size=3](Only change would be the min and max column to parse then, won,t change much cus if I recall they'll be default to 0 if nothing there..)[/size][/font][/color][color=#282828][font=helvetica, arial, sans-serif][size=3]The min and max were indeed changed, which broke something. [b]The min/max were changed from 7-8 to 7-7[/b], and as some of the skills have 8 columns, they were no longer read.[/size][/font][/color][/quote] working as intended..since fixed cast time in re is not anymore optional...and I don't think there is a 8 columns in pre..
[/quote]
this =(
[quote name='malufett' timestamp='1347584260' post='14429']
[quote][color=#282828][font=helvetica, arial, sans-serif][size=3](Only change would be the min and max column to parse then, won,t change much cus if I recall they'll be default to 0 if nothing there..)[/size][/font][/color][color=#282828][font=helvetica, arial, sans-serif][size=3]The min and max were indeed changed, which broke something. [b]The min/max were changed from 7-8 to 7-7[/b], and as some of the skills have 8 columns, they were no longer read.[/size][/font][/color][/quote]
working as intended..since fixed cast time in re is not anymore optional...and I don't think there is a 8 columns in pre.. [/quote]
this =(
Hercules Elf Bot - Sep 22, 2012 4:01
Originally posted by [b]Euphy[/b]
Fixed in [rev=16789].
Fixed in [rev=16789].