Script have /* */

Originally posted by [b]nanakiwurtz[/b]
Wew...
It's just an ordinary Comment Block.

A commented code won't be processed, there're 2 way to comment.
First, comment a line
[code]1
2
//3 <-- commented
[/code]
Second, comment a block
[code]/*
1
2
3
*/[/code]
In item script, actually it's just a compacted lines, so it's become a single line.

Originally posted by [b]EvilPuncker[/b]
[quote name='nanakiwurtz' timestamp='1348061167' post='14562']
Wew...It's just an ordinary Comment Block.A commented code won't be processed, there're 2 way to comment.First, comment a line[code]12//3 <-- commented[/code]Second, comment a block[code]/*123*/[/code]In item script, actually it's just a compacted lines, so it's become a single line.
[/quote]

I think that he is asking why they are commented, the answer is that when they were implemented those skills/bonuses were not coded yet, now they are, that is why kenpachi confirmed this

Originally posted by [b]kyeme[/b]
[quote name='EvilPuncker' timestamp='1348106458' post='14573']
[quote name='nanakiwurtz' timestamp='1348061167' post='14562']Wew...It's just an ordinary Comment Block.A commented code won't be processed, there're 2 way to comment.First, comment a line[code]12//3 <-- commented[/code]Second, comment a block[code]/*123*/[/code]In item script, actually it's just a compacted lines, so it's become a single line.[/quote]I think that he is asking why they are commented, the answer is that when they were implemented those skills/bonuses were not coded yet, now they are, that is why kenpachi confirmed this
[/quote]
Oh iseee Thanks

Originally posted by [b]Spre[/b]
I spent alot of time today trying to test those, if noone gets to it i'll finish testing them by weeks end and see.

I started working again today/yesterday 4:30 to 1am so yea

Originally posted by [b]Kabal[/b]
This causes errors in my mapserv. Remembering that I use in the SQL item_db_re.

Originally posted by [b]Spre[/b]
Well first, you cannot just uncomment them all, some functions still do not exist.

For example madoheal is not a working function.


Second I have finished them, I just need a final approval before they can be comitted, awaiting on euphy for that.

Originally posted by [b]darristan[/b]
Error syntax in item_db_re line 5469, anyone confirm?

[CODE]
REPLACE INTO `item_db_re` VALUES (12392,'Repair_A','Repair A',0,220,NULL,70,NULL,NULL,NULL,NULL,0x00000400,8,2,NULL,NULL,NULL,NULL,NULL,/*' madoheal rand(200,300),0;'*/,NULL,NULL);
REPLACE INTO `item_db_re` VALUES (12393,'Repair_B','Repair B',0,500,NULL,70,NULL,NULL,NULL,NULL,0x00000400,8,2,NULL,NULL,NULL,NULL,NULL,/*' madoheal rand(300,400),0;'*/,NULL,NULL);
REPLACE INTO `item_db_re` VALUES (12394,'Repair_C','Repair C',0,1100,NULL,70,NULL,NULL,NULL,NULL,0x00000400,8,2,NULL,NULL,NULL,NULL,NULL,/*' madoheal rand(400,500),0;'*/,NULL,NULL);
[/CODE]

It should look like:
[CODE]
'/* madoheal rand(400,500),0;*/'
[/CODE]

Instead of
[CODE]
/*'madoheal rand(400,500),0;'*/
[/CODE]

Originally posted by [b]Euphy[/b]
Spre committed his changes in [rev=16822], followed up with Darristan's corrections in [rev=16823] - thanks!

Originally posted by [b]EvilPuncker[/b]
spre missed a item with rentitem,xxxx,[color=#ff0000]1,[/color]xxxxx

Originally posted by [b]kyeme[/b]
Hello Hi Hello Hi, hmm what is the difference between bCastrate and bVariableCastrate ?

Originally posted by [b]Spre[/b]
firs thing is first.


it doesn't matter about anything in between /* */ those are comments, that part of the script is not read, so How exactly can you get a syntax error? Nothing there defaults to NULL as it should be untill madoheal is written.

Second Puncker read below

Third bCastrate Doesn't work right, there was a bugreport on this, the function doesn;t work as intedid or was removed I can not remember, bvariablecastrate works just as good, and that change was done a few revisions ago.




wait, I didnt mess up, item_db_re.sql says this

REPLACE INTO `item_db_re` VALUES (13694,'Freyja_Crown_Box','Freya\'s Crown Box',18,NULL,NULL,10,NULL,NULL,NULL,NULL,0xFFFFFFFF,7,2,NULL,NULL,NULL,NULL,NULL,'getitem 5306,1,604800;',NULL,NULL);


GETITEM So something is not right here


puncker I need you to post this ,1, as I don;t see it missed in my diff.

Originally posted by [b]EvilPuncker[/b]
[color=#000000][font=monospace][background=rgb(221, 255, 221)]13694,Freyja_Crown_Box,Freya's Crown Box,18,0,,10,,,,,0xFFFFFFFF,7,2,,,,,,{ getitem 5306,1,604800; },{},{}[/background][/font][/color]

so i mean u forgot to change it to rentitem and to remove the 1,

Originally posted by [b]kyeme[/b]
@all "bonus bCastrate" is not working in Renewal mode? asking..

IF not working, some of items have [i]bonus bCastrate[/i] like Berzebub_Card

and create a new report about this?

Originally posted by [b]Spre[/b]
Puncker: It was like that and I follow the Do not change unless it has reliable sources, as it was getitem before I updated the items, and have no confirmation it is rentitem I can not change it, I would have every db/script/core dev on my butt for making a change that is not confirmed.

So until then it has to stay getitem

Kyeme: All bCastrate should have been changed to bVariableCastrate, But going over the re itemDB I can see no, I changed all the bonus2 castrate but never did the bonus castrate. I will get on that.

Originally posted by [b]Spre[/b]
[quote name='EvilPuncker' timestamp='1350873364' post='15094']
[color=#000000][font=monospace][background=rgb(221, 255, 221)]13694,Freyja_Crown_Box,Freya's Crown Box,18,0,,10,,,,,0xFFFFFFFF,7,2,,,,,,{ getitem 5306,1,604800; },{},{}[/background][/font][/color]so i mean u forgot to change it to rentitem and to remove the 1,
[/quote]

Fixed in [rev=16828]