Elemental Skill (possible) Crashes
Warning! This is the old Hercules bugtracker archive, and may not reflect the current state of Hercules. The current bugtracker is on GitHub Issues.
Issue information
Issue ID
#7010
Status
Fixed
Severity
None
Started
Hercules Elf Bot
Dec 15, 2012 16:03
Last Post
mkbu95
Jan 19, 2013 20:35
Confirmation
Hercules Elf Bot - Dec 15, 2012 16:03
Originally posted by [b]Aleos[/b]
This crash is possible since [url=http://trac.rathena.org/changeset/17014/rathena]r17014[/url]. In the skill_get_requirement() function, there are 3 possible cases of crashes. The status changes SC_UPHEAVAL_OPTION, SC_TROPIC_OPTION, and SC_CHILL_AIR_OPTION are missing a "sc &&" check in the if-statement. Without this check it will crash if the chance is less than 50% and casted on something that doesn't have one of those SC_'s active.
This crash is possible since [url=http://trac.rathena.org/changeset/17014/rathena]r17014[/url]. In the skill_get_requirement() function, there are 3 possible cases of crashes. The status changes SC_UPHEAVAL_OPTION, SC_TROPIC_OPTION, and SC_CHILL_AIR_OPTION are missing a "sc &&" check in the if-statement. Without this check it will crash if the chance is less than 50% and casted on something that doesn't have one of those SC_'s active.
Hercules Elf Bot - Dec 15, 2012 16:09
Originally posted by [b]malufett[/b]
OMG..I'm getting older now a days..hahahaha
Thank you...
OMG..I'm getting older now a days..hahahaha
Thank you...
Hercules Elf Bot - Dec 15, 2012 16:16
Originally posted by [b]Aleos[/b]
No problem. Glad to help.
No problem. Glad to help.
Hercules Elf Bot - Dec 16, 2012 15:44
Originally posted by [b]malufett[/b]
Fixed @ [rev='17026']
Fixed @ [rev='17026']