Issue information

Issue ID
#7101
Status
Fixed
Severity
None
Started
jTynne
Feb 27, 2013 11:34
Last Post
Kenpachi
Apr 30, 2013 13:08
Confirmation
Yes (1)
No (0)

jTynne - Feb 27, 2013 11:34

Per a report from a player of my server,

[color=rgb(255,255,255)][font='Lucida Grande', 'Lucida Sans', Verdana, Tahoma, sans-serif][size=3]
[color=#000000]hi there.[/color][/size][/font][/color][color=rgb(255,255,255)][font='Lucida Grande', 'Lucida Sans', Verdana, Tahoma, sans-serif][size=3]
[color=#000000]i just ranked my Taekwon, and some wild bug appears:
every 2nd map i go i lose all my skills (except TK mission and Break fall)[/color][/size][/font][/color][color=rgb(255,255,255)][font='Lucida Grande', 'Lucida Sans', Verdana, Tahoma, sans-serif][size=3]
[color=#000000]thats kinda weird.[/color][/size][/font][/color][color=rgb(255,255,255)][font='Lucida Grande', 'Lucida Sans', Verdana, Tahoma, sans-serif][size=3]
[color=#000000]screenies:
[url="http://akushin.lima-city.de/casual/01.jpg"]http://akushin.lima-city.de/casual/01.jpg[/url]
[url="http://akushin.lima-city.de/casual/02.jpg"]http://akushin.lima-city.de/casual/02.jpg[/url]
(server\'s a bit laggy lately, if screenies don\'t load try 5 min later....)[/color][/size][/font][/color]

Quite strange indeed!

jTynne - Mar 8, 2013 23:44

Any update?

malufett - Mar 9, 2013 6:06

ATM I can't reproduce..just give me or us some time to reproduce it..:)

:meow:

Michieru - Mar 11, 2013 21:19

Same bug here. It's looks to be with the takwon mission.

Michieru - Mar 12, 2013 16:48

It's looks like when you are on top ten takwon ranked. This appear when you warp/equip unequip equipment.

Michieru - Mar 13, 2013 14:54

Ok i found how to reproduce. Each 2 mission points with a ranked taekwon will make disipear skills.

Beret - Mar 16, 2013 2:29

Bump, some dev look to it

Ind - Mar 17, 2013 23:52

code at fault is this, to reproduce you need 0 skill points, base level 90 >= and be ranked, then start changing maps and the skills will toggle available/not-available (gray)[code=auto:0] if( c > 0 && (sd->class_&MAPID_UPPERMASK) == MAPID_TAEKWON && sd->status.base_level >= 90 && sd->status.skill_point == 0 && pc_famerank(sd->status.char_id, MAPID_TAEKWON) ) { /* Taekwon Ranger Bonus Skill Tree ============================================ - Grant All Taekwon Tree, but only as Bonus Skills in case they drop from ranking. - (c > 0) to avoid grant Novice Skill Tree in case of Skill Reset (need more logic) - (sd->status.skill_point == 0) to wait until all skill points are asigned to avoid problems with Job Change quest. */ for( i = 0; i < MAX_SKILL_TREE && (id = skill_tree[c][i].id) > 0; i++ ) { if( (skill->get_inf2(id)&(INF2_QUEST_SKILL|INF2_WEDDING_SKILL)) ) continue; //Do not include Quest/Wedding skills. if( sd->status.skill[id].id == 0 ) { sd->status.skill[id].id = id; sd->status.skill[id].flag = SKILL_FLAG_TEMPORARY; // So it is not saved, and tagged as a "bonus" skill. } else { sd->status.skill[id].flag = SKILL_FLAG_REPLACED_LV_0 + sd->status.skill[id].lv; // Remember original level } sd->status.skill[id].lv = skill->tree_get_max(id, sd->status.class_); } } [/code]

Ind - Mar 18, 2013 0:04

I'm not entirely sure why though oo malufett save me ;_;

malufett - Mar 19, 2013 18:55

[quote]
I'm not entirely sure why though oo malufett save me ;_;[/quote]
ok sir..the code you stated is working fine..but the processing of the variable [b]c [/b]is not working properly..it turns 0 after every 2nd call of 'pc_calc_skilltree'

:meow:

Hideki - Mar 20, 2013 15:21

bump :c
[attachment=119:Captura.PNG]
ola ke ase

This post has been edited by Hideki on Mar 20, 2013 15:22

malufett - Mar 22, 2013 14:42

Fixed @ [url="https://github.com/HerculesWS/Hercules/commit/61a450b27d184ba336dc3f0899f7790e938ec463"]https://github.com/HerculesWS/Hercules/commit/61a450b27d184ba336dc3f0899f7790e938ec463[/url]
:meow:

Hideki - Mar 27, 2013 3:58

[quote name="malufett" timestamp="1363963327"]
Fixed @ [url="https://github.com/HerculesWS/Hercules/commit/61a450b27d184ba336dc3f0899f7790e938ec463"]https://github.com/HerculesWS/Hercules/commit/61a450b27d184ba336dc3f0899f7790e938ec463[/url]
:meow:[/quote]

i love u :wub: :wub: :wub: :wub: :wub: :wub: