xilence01 - May 29, 2013 13:18
I found some bugs on my server.
Whenever i equip a 4slotted weapon with 2 turtle general and 2 hydra cards.
my asura strike skill misses. as in no damage at all.
255 str. 255 dex.
I switch to a 4 slotted weapon with 2 stormy knight and 2 turtle general.
then my asura strike is back to normal. it has damage now.
Via - May 29, 2013 21:06
The way it is right now, Asura Strike has an official cap that limits the amount of damage it'll do; this was put in place so that the damage doesn't overflow (technical limitation). You'd need a rather large amount of SP and ATK to hit this cap, but it'd be achievable on a server with a high stat cap.
As far as I know, there is not an official damage cap for Asura, so a reworking of the formula to increase the cap and work better with renewal stats would probably do well. The edit below would suit most servers' needs and still leave a [much larger] cap for overflow protection.
[b]src/map/battle.c[/b]
[code=auto:0]
case MO_EXTREMITYFIST:
- { //Overflow check. [Skotlex]
- unsigned int ratio = skillratio + 100*(8 + sstatus->sp/10);
- //You'd need something like 6K SP to reach this max, so should be fine for most purposes.
- if (ratio > 60000) ratio = 60000; //We leave some room here in case skillratio gets further increased.
- skillratio = (unsigned short)ratio;
- }
+ skillratio += 100*(8 + sstatus->sp/10) - 100;
+ skillratio = min(500000,skillratio); //We stop at roughly 50k SP for overflow protection
break;
[/code]
You can go ahead and make this edit to your own files, or wait for Hercules to send over an update.
This post has been edited by
Via
on May 29, 2013 21:08
xilence01 - May 30, 2013 6:13
[quote name="Via" timestamp="1369861561"]
The way it is right now, Asura Strike has an official cap that limits the amount of damage it'll do; this was put in place so that the damage doesn't overflow (technical limitation). You'd need a rather large amount of SP and ATK to hit this cap, but it'd be achievable on a server with a high stat cap.
As far as I know, there is not an official damage cap for Asura, so a reworking of the formula to increase the cap and work better with renewal stats would probably do well. The edit below would suit most servers' needs and still leave a [much larger] cap for overflow protection.
[b]src/map/battle.c[/b][code=auto:0]
case MO_EXTREMITYFIST:
- { //Overflow check. [Skotlex]
- unsigned int ratio = skillratio + 100*(8 + sstatus->sp/10);
- //You'd need something like 6K SP to reach this max, so should be fine for most purposes.
- if (ratio > 60000) ratio = 60000; //We leave some room here in case skillratio gets further increased.
- skillratio = (unsigned short)ratio;
- }
+ skillratio += 100*(8 + sstatus->sp/10) - 100;
+ skillratio = min(500000,skillratio); //We stop at roughly 50k SP for overflow protection
break;
[/code]
You can go ahead and make this edit to your own files, or wait for Hercules to send over an update.[/quote]
Thanks mate.
malufett - May 30, 2013 11:39
capping is good however MO_EXTREMITY got renewed it has a new formula... :D
:meow:
This post has been edited by
malufett
on May 30, 2013 11:40
serverkid - Aug 18, 2013 4:04
i have fixed this last week on my server.
damage * cardfix > MAX_INT therefore overflowing.
changed battle_calc_cardfix case BF_WEAPON:
from
[code=auto:0]damage = damage * cardfix / 1000;[/code]
to[code=auto:0]damage = damage * ((float)cardfix / 1000);[/code]
Ind - Sep 10, 2013 0:40
I believe this has been fixed in a previous commit (one that fixed damage overflow issues)
dhaisuke - Feb 26, 2014 5:23
[quote name="Via" timestamp="1369861561"]
The way it is right now, Asura Strike has an official cap that limits the amount of damage it'll do; this was put in place so that the damage doesn't overflow (technical limitation). You'd need a rather large amount of SP and ATK to hit this cap, but it'd be achievable on a server with a high stat cap.
As far as I know, there is not an official damage cap for Asura, so a reworking of the formula to increase the cap and work better with renewal stats would probably do well. The edit below would suit most servers' needs and still leave a [much larger] cap for overflow protection.
[b]src/map/battle.c[/b][code=auto:0]
case MO_EXTREMITYFIST:
- { //Overflow check. [Skotlex]
- unsigned int ratio = skillratio + 100*(8 + sstatus->sp/10);
- //You'd need something like 6K SP to reach this max, so should be fine for most purposes.
- if (ratio > 60000) ratio = 60000; //We leave some room here in case skillratio gets further increased.
- skillratio = (unsigned short)ratio;
- }
+ skillratio += 100*(8 + sstatus->sp/10) - 100;
+ skillratio = min(500000,skillratio); //We stop at roughly 50k SP for overflow protection
break;
[/code]
You can go ahead and make this edit to your own files, or wait for Hercules to send over an update.[/quote]
Sir, tried applying your code above, I get an error, sstatus is undeclared.