Issue information

Issue ID
#7799
Status
Fixed
Severity
None
Started
kyeme
Nov 5, 2013 7:31
Last Post
Angelmelody
Nov 19, 2013 9:37
Confirmation
Yes (0)
No (1)

kyeme - Nov 5, 2013 7:31

Bug: The "SC_MOONSTAR" and "SC_SUPER_STAR" is removable by "[b][color=#ff0000]sc_end SC_ALL[/color][/b]"

Frost - Nov 5, 2013 13:02

well obviously it will remove by SC_ALL, because its SC, even the Bubble Gum, Field Manuals.

kyeme - Nov 5, 2013 13:13

Yes, but I believe this bonus is like Overweight, Cart and etc.

This post has been edited by kyeme on Nov 6, 2013 0:55

Ind - Nov 6, 2013 23:13

thanks!
Fixed in [url="https://github.com/HerculesWS/Hercules/commit/665f1306a130d4b8c359972bf4e58ef9d3bd9cd8"]https://github.com/HerculesWS/Hercules/commit/665f1306a130d4b8c359972bf4e58ef9d3bd9cd8[/url]

Angelmelody - Nov 7, 2013 6:32

[quote name="kyeme" timestamp="1383657203"]
Yes, but I believe this bonus is like Overweight, Cart and etc.[/quote]

It should be removed by sc_end ,to see item_db unequipped script
[url="https://github.com/HerculesWS/Hercules/commit/da1f16b2b5f42006c252496f2ffa02266008a833"]https://github.com/HerculesWS/Hercules/commit/da1f16b2b5f42006c252496f2ffa02266008a833[/url]

Angelmelody - Nov 8, 2013 3:15

[quote name="Ind" timestamp="1383779603"]
thanks!
Fixed in [url="https://github.com/HerculesWS/Hercules/commit/665f1306a130d4b8c359972bf4e58ef9d3bd9cd8"]https://github.com/HerculesWS/Hercules/commit/665f1306a130d4b8c359972bf4e58ef9d3bd9cd8[/url][/quote]

up! It caused the effect still persist even take it off

kyeme - Nov 8, 2013 3:35

[quote name="Angelmelody" timestamp="1383880505"][quote name="Ind" timestamp="1383779603"]

thanks!
Fixed in [url="https://github.com/HerculesWS/Hercules/commit/665f1306a130d4b8c359972bf4e58ef9d3bd9cd8"]https://github.com/HerculesWS/Hercules/commit/665f1306a130d4b8c359972bf4e58ef9d3bd9cd8[/url][/quote]
up! It caused the effect still persist even take it off[/quote]

Confirming..

exneval - Nov 8, 2013 4:32

kyeme, maybe this report shouldn't be a bug in the first place.

kyeme - Nov 13, 2013 16:48

[quote name="exneval" timestamp="1383885124"]
kyeme, maybe this report shouldn't be a bug in the first place.[/quote]
I just want to compare this to SC_PUSHCART,SC_WEIGHTOVER50 that cannot be removed by 'sc_end SC_ALL' command. :)

Bump~ :)

This post has been edited by kyeme on Nov 13, 2013 16:50

Ind - Nov 19, 2013 4:54

[url="https://github.com/HerculesWS/Hercules/commit/d076f129c90ac9e3a96659488f702f81def1863a"]https://github.com/HerculesWS/Hercules/commit/d076f129c90ac9e3a96659488f702f81def1863a[/url] adjusted in
thank you all

kerbiii - Nov 19, 2013 5:44

how to pull that fix?

sorry new in git :)

Angelmelody - Nov 19, 2013 9:37

[quote name="kerbiii" timestamp="1384839889"]
how to pull that fix?

sorry new in git :)[/quote]

[url="http://herc.ws/board/topic/152-obtaining-hercules/"]http://herc.ws/board/topic/152-obtaining-hercules/[/url]