Raziel - Dec 7, 2013 14:51
[b]Regarding Linker Skills[/b]
The way it should be[color=rgb(40,40,40)][font=helvetica, arial, sans-serif][size=3]:[/size][/font][/color]
[color=rgb(40,40,40)][font=helvetica, arial, sans-serif][size=3]Estin: Full DMG on small-sized monsters, 1 DMG on medium and large[/size][/font][/color]
[color=rgb(40,40,40)][font=helvetica, arial, sans-serif][size=3]Estun: Full DMG on medium-sized monsters. 1 DMG on large. Stuns target.[/size][/font][/color]
The way it is right now[color=rgb(40,40,40)][font=helvetica, arial, sans-serif][size=3]:[/size][/font][/color]
[color=rgb(40,40,40)][font=helvetica, arial, sans-serif][size=3]Estin: Full DMG on Medium, 1 DMG on small and large[/size][/font][/color]
Estun: Full DMG on Small and Medium, 1 DMG on large. I'm not sure if it is just me but the stun is like never occurring.
[b]Regarding Taekwon[/b]
[color=rgb(40,40,40)][font=helvetica, arial, sans-serif][size=3]This has been there for a while now and I would really like to clarify if it is a bug at all and if not would like to know why it is the way it is now?. Tested with a TK ranker, when your kick stance is active or you dodge an attack with Breakfall you are unable to teleport using both flywing or bwing. There's a short delay after the stance/breakfall and the items used(wings) are consumed although they don't take effect. You have to wait/walk for like 2 seconds and use the item again for it to take effect. It's very annoying when you are trying to escape from a huge mob and breakfall keeps activating and making the char unable to teleport away. If this isn't a bug and if there is any alternative to change this behavior of the skills and the use of item please let me know.[/size][/font][/color]
[u]Additional info[/u] : I'm using pre-renewal setting with the latest working copy of Hercules and tested with multiple chars to confirm it. I tried it on the 2013 clients.
Alexandria - Apr 13, 2014 6:32
[color=#ee82ee][font='comic sans ms', cursive]Bump![/font][/color]
Adam - Apr 13, 2014 6:35
+1 confirmed, especially the Soul linker part
[color=rgb(40,40,40)][font=helvetica, arial, sans-serif][size=3]Estin: Full DMG on Medium, 1 DMG on small and large[/size][/font][/color]
Estun: Full DMG on Small and Medium, 1 DMG on large. The stun is like never occurring.
(yes stun never occurs)
Kido - Apr 13, 2014 6:38
bump
Adam - Apr 16, 2014 22:41
Hello,
Just curious to know if this report is monitored, thank you.
Alexandria - Apr 24, 2014 20:45
[font='comic sans ms', cursive][color=rgb(238,130,238)]Any notice?[/color][/font]
Adam - May 5, 2014 1:04
BUMP
Fluffle Puff - May 19, 2014 21:09
[font='comic sans ms', cursive][color=rgb(238,130,238)]Can a developer tell something about it? please[/color][/font]
Myskelz - Aug 24, 2014 20:43
Bump. Issue confirmed on my local server too. I'll take a look on that.
Myskelz - Aug 24, 2014 22:00
[quote]
[b]In the SQL DB :[/b]
1001 - Scorpion - Scale : 0
1002 - Poring - Scale : 1
[b]@mi :[/b]
Scorpion : Small (so size = 0)
Poring : Medium (so size = 1)
[b]Sources :[/b]
enum size {
SZ_MEDIUM = 0, // <--- Wtf ?
SZ_SMALL,
SZ_BIG,
};[/quote]
We've got this in the source code, for the stun part of SL_STUN (Estun)
[i][b]src/map/skill.c:954[/b][/i][code=auto:954]
case SL_STUN:
if (tstatus->size==SZ_MEDIUM) //Only stuns mid-sized mobs.
sc_start(src,bl,SC_STUN,(30+10*skill_lv),skill_lv,skill->get_time(skill_id,skill_lv));
break;
[/code]
SZ_MEDIUM = 0, in the DB 0 is related to small sized monsters.
I don't think it's harmless to change the [i][b]size[/b][/i] enum, I suppose that this is used everywhere and it needs some investigations. I.E., we need to check if the damage calculation (with axes/swords) is also wrong (because of the wrong enum).
Edit: This commit changed a lot of things related with the size enum : [url="https://github.com/HerculesWS/Hercules/commit/0a24a4bb6340459a6128c39d13ab1bf37a5bc6b8"]https://github.com/HerculesWS/Hercules/commit/0a24a4bb6340459a6128c39d13ab1bf37a5bc6b8[/url]
Edit 2: We can also see an old comment that proofs that there is a problem with these skills...
[b][i]src/map/battle.c:1467[/i][/b][code=auto:0]
case SL_STIN:
skillratio += (tst->size!=SZ_SMALL?-99:10*skill_lv); //target size must be small (0) for full damage.
break;
case SL_STUN:
skillratio += (tst->size!=SZ_BIG?5*skill_lv:-99); //Full damage is dealt on small/medium targets
[/code]
[b]"//target size must be small [color=#ff0000](0)[/color] for full damage."[/b]
0 is now related to medium size monsters.
This post has been edited by
Myskelz
on Aug 24, 2014 23:25
マヤコ Lyyn~ - Aug 25, 2014 12:05
If you want to fix it, there is a workaround only for Estun/Estin skills. I tested it yesterday and it works now fine.
[b][i]src/map/battle.c:1467[/i][/b][code=auto:0]case SL_STIN:
//skillratio += (tst->size!=SZ_SMALL?-99:10*skill_lv); //target size must be small (0) for full damage.
skillratio += (tst->size!=SZ_MEDIUM?-99:10*skill_lv); //[Lyyn] Workaround because of the wrong enum size
break;
[/code][b][i]src/map/skill.c:954[/i][/b][code=auto:0]case SL_STUN:
//if (tstatus->size==SZ_MEDIUM) //Only stuns mid-sized mobs.
if (tstatus->size==SZ_SMALL) // [Lyyn] Workaround because of the wrong enum size
sc_start(src,bl,SC_STUN,(30+10*skill_lv),skill_lv,skill->get_time(skill_id,skill_lv));
break;
[/code]
This post has been edited by
マヤコ Lyyn~
on Aug 25, 2014 12:06
Michi - Sep 16, 2014 21:47
Fixed in: [url="https://github.com/HerculesWS/Hercules/commit/ddc52570a9bf694cdba6445bc02350a94856a583"]https://github.com/HerculesWS/Hercules/commit/ddc52570a9bf694cdba6445bc02350a94856a583[/url]