Lightning Spear damage - Hercules bug tracker archive

Issue information

Issue ID

#8513

Status

Fixed

Severity

None

Started

nihadm89

Jan 29, 2015 16:50

Last Post

malufett

Feb 13, 2015 9:25

Confirmation

N/A

nihadm89 - Jan 29, 2015 16:50

As reported by one of our players and then confirmed by staff.[quote]
[color=rgb(40,40,40)][font=helvetica, arial, sans-serif][size=3]
The skill's damage appears to increase according to the skill level used. The skill is supposed to do 70% of my matk per hit, my matk being 199+64, so it should be doing around 165 damage to a chonchon (Which has 0 hard and soft mdef and takes 90% from water.) per hit, when in reality it's doing a range of 283 to 303 at level 1 per hit, nearly double that value.[/size][/font][/color][color=rgb(40,40,40)][font=helvetica, arial, sans-serif][size=3]
At level 2, the damage per hit moves up to 443, and it continues to increase per level, where at level 10 it does 1506 per hit to a chonchon.[/size][/font][/color][/quote]

malufett - Jan 29, 2015 18:39

can you show us the complete test setup?

:meow:

Michi - Jan 30, 2015 8:39

[code=auto:0] #ifdef RENEWAL case NJ_HYOUSENSOU: skillratio -= 30; if (sd && sd->charm_type == CHARM_TYPE_WATER && sd->charm_count > 0) skillratio += 5 * sd->charm_count; #endif /* Fall through */ case NJ_HYOUSYOURAKU: skillratio += 50 * skill_lv; if (sd && sd->charm_type == CHARM_TYPE_WATER && sd->charm_count > 0) skillratio += 25 * sd->charm_count; break; [/code]
@malu in battle.c I think there is a break missing NJ_HYOUSENSOU got the bonus of NJ_HYOUSYOURAKU

This post has been edited by Michi on Jan 30, 2015 8:40

nihadm89 - Jan 30, 2015 14:48

[quote name="Michi" timestamp="1422607149"][code=auto:0] #ifdef RENEWAL case NJ_HYOUSENSOU: skillratio -= 30; if (sd && sd->charm_type == CHARM_TYPE_WATER && sd->charm_count > 0) skillratio += 5 * sd->charm_count; #endif /* Fall through */ case NJ_HYOUSYOURAKU: skillratio += 50 * skill_lv; if (sd && sd->charm_type == CHARM_TYPE_WATER && sd->charm_count > 0) skillratio += 25 * sd->charm_count; break; [/code]@malu in battle.c I think there is a break missing NJ_HYOUSENSOU got the bonus of NJ_HYOUSYOURAKU[/quote]

Confirmed, made a pull request. Adding break fixes it.

Playtester - Feb 9, 2015 12:14

You should probably try to figure out where the "Fall through" comment comes from, because that usually means that the break; was intentionally left away.