NPC Earthquake damage calculation bugged and possibly wrong

Issue information

Issue ID

#8529

Status

Fixed

Severity

None

Started

Valo

Feb 10, 2015 1:35

Last Post

Valo

Feb 14, 2015 14:53

Confirmation

N/A

Valo - Feb 10, 2015 1:35

When refactoring skillratio calculation into battle_calc_skillratio the local variable skillratio was left in battle_calc_magic_attack. This led to not noticing that NPC_EARTHQUAKE special case used that local variable. I recommend updating the scope of skillratio (or removing it altogether).

Also I noticed that according to [url="http://rode.doddlercon.com/db/quake/eqcalc.php"]http://rode.doddlercon.com/db/quake/eqcalc.php[/url] and iro wiki earthquake should not use matk of the monster at all, but instead should do damage based on ATK_MIN ~ ATK_MAX alone.

This post has been edited by Valo on Feb 10, 2015 1:36

malufett - Feb 13, 2015 13:12

Fixed @21b72c42cbcf05377a4e72087db3fd0fb9a1d651
:meow:

Valo - Feb 13, 2015 14:36

Maya Card (etc) should be able to reflect Earth Quake (don't know if pre-re only). I don't think the fix considered this.

malufett - Feb 13, 2015 15:16

[quote name="Valo" timestamp="1423838201"]
Maya Card (etc) should be able to reflect Earth Quake (don't know if pre-re only). I don't think the fix considered this.[/quote]
how? afaik maya card and a like reflects only targeted type magic skills..

:meow:

Valo - Feb 14, 2015 14:53

It was implemented correctly as special case before. I don't know why / how it works but I killed MvPs with Maya Card and BG Equipment on official in pre-re. I think the classification of Earthquake as magic was correct.

This post has been edited by Valo on Feb 14, 2015 14:55