Issue information

Issue ID
#8579
Status
Fixed
Severity
None
Started
Zia
Mar 17, 2015 19:10
Last Post
malufett
Mar 29, 2015 1:25
Confirmation
N/A

Zia - Mar 17, 2015 19:10

At level 5, Warmer is supposed to regenerate max HP at 5% every 3 seconds. (Source: [url="http://irowiki.org/wiki/Warmer"]http://irowiki.org/wiki/Warmer[/url])
However, it's currently healing at 10% every 3 seconds.

Proof:

Tested in our test server. Max HP of 36,973 regenerated 3,698 on one tick at 3 seconds.
[img]http://i.imgur.com/YLLkXlk.jpg[/img]

[img]http://i.imgur.com/8yHJ5L9.jpg[/img]

Attempted Fix:

Tried removing line with 1st [color=#ff0000]status->heal(b1, hp, 0, 0); [/color]because there's 2 statements for it (Source: [url="https://github.com/HerculesWS/Hercules/blob/master/src/map/skill.c#L12431"]https://github.com/HerculesWS/Hercules/blob/master/src/map/skill.c#L12431[/url])

[b]Changed[/b]

case UNT_WARMER:
{
// It has effect on everything, including monsters, undead property and demon
[color=#ff8c00]int hp = 0;
if( ssc && ssc->data[SC_HEATER_OPTION] )
hp = tstatus->max_hp * 3 * sg->skill_lv / 100;
else
hp = tstatus->max_hp * sg->skill_lv / 100;
status->heal(bl, hp, 0, 0);[/color]
if( tstatus->hp != tstatus->max_hp )
clif->skill_nodamage(&src->bl, bl, AL_HEAL, hp, 0);
if( tsc && tsc->data[SC_AKAITSUKI] && hp )
hp = ~hp + 1;
status->heal(bl, hp, 0, 0);
sc_start(ss, bl, type, 100, sg->skill_lv, sg->interval + 100);
}

[b]to[/b]

case UNT_WARMER:
{
// It has effect on everything, including monsters, undead property and demon
[color=#008000]int hp = 0;
if( ssc && ssc->data[SC_HEATER_OPTION] )
hp = tstatus->max_hp * 3 * sg->skill_lv / 100;
else
hp = tstatus->max_hp * sg->skill_lv / 100;[/color]
if( tstatus->hp != tstatus->max_hp )
clif->skill_nodamage(&src->bl, bl, AL_HEAL, hp, 0);
if( tsc && tsc->data[SC_AKAITSUKI] && hp )
hp = ~hp + 1;
status->heal(bl, hp, 0, 0);
sc_start(ss, bl, type, 100, sg->skill_lv, sg->interval + 100);
}

[b]And Warmer regenerated HP at 5% per 3 secs[/b]

Proof:

[img]http://i.imgur.com/YRFW3qe.jpg[/img]

[img]http://i.imgur.com/b28aRfw.jpg[/img]

This post has been edited by Zia on Mar 17, 2015 19:17

Ind - Mar 18, 2015 9:53

the level of detail in the report is outstanding, I appreciate the effort you've put into this. I've asked malufett and michieru to drop by

This post has been edited by Ind on Mar 18, 2015 9:56

Zia - Mar 18, 2015 13:22

Thank you so much Ind. My team and I are doing whatever we can to support Hercules so it'll be as less buggy as possible so all my bug reports are detailed like this one.

[color=#d3d3d3]Senpai noticed me I'm so happy[/color]. -_-

Zia - Mar 19, 2015 15:02

Requested a pull :)

malufett - Mar 29, 2015 1:25

Fixed @ 370c96e24ac21b47a4da6fb9c14dfcb8e9fbd19a
:meow: