Tidung's script damage reduction

[url="https://github.com/HerculesWS/Hercules/pull/511"]https://github.com/HerculesWS/Hercules/pull/511[/url]

Greetings.
I would like to point out that the player in post: [url="http://forums.warpportal.com/index.php?/topic/127843-fix-that-item-description-project/page-5#entry2123610"]http://forums.warpportal.com/index.php?/topic/127843-fix-that-item-description-project/page-5#entry2123610[/url]
suggested that the issue is "[u]description error[/u]", not script error.

Additionally, the person also referenced another person [url="http://forums.warpportal.com/index.php?/topic/171139-armor-question/?p=2052624%C2%A0"]http://forums.warpportal.com/index.php?/topic/171139-armor-question/?p=2052624 [/url]
who tested it on "Waterball" skill (This should imply that any damage is reduced by 5%, of course this include any damage, correct?).

Whether or not it is an issue in iRO, at any rate, note that Tidung's current item script corresponds to the item description in any server you can find (according to divine pride at least) [url="http://divine-pride.net/database/item/15032/tidung-1"]http://divine-pride.net/database/item/15032/tidung-1[/url][code=auto:0] REPLACE INTO `item_db` VALUES ('15032','Tidung','Tidung','5','10','5','500','0','0','2','0','1','2147483646','63','2','16','0','0',NULL,'1','0','0','0','0','0',NULL,'0',NULL,'0',NULL,'0','bonus bMdef,10; bonus2 bResEff,Eff_Stun,1500; bonus2 bResEff,Eff_Freeze,1500; bonus2 bSubRace,RC_NonBoss,5; bonus2 bSubRace,RC_Boss,5;','',''); [/code]
I believe the item is fine as it is.
Cheers.

-SH

[quote name="Shourei" timestamp="1431142445"]
Greetings.
I would like to point out that the player in post: [url="http://forums.warpportal.com/index.php?/topic/127843-fix-that-item-description-project/page-5#entry2123610"]http://forums.warpportal.com/index.php?/topic/127843-fix-that-item-description-project/page-5#entry2123610[/url]
suggested that the issue is "description error", not script error.

Additionally, the person also referenced another person [url="http://forums.warpportal.com/index.php?/topic/171139-armor-question/?p=2052624"]http://forums.warpportal.com/index.php?/topic/171139-armor-question/?p=2052624[/url]
who tested it on "Waterball" skill (This should imply that any damage is reduced by 5%, of course this include any damage, correct?).

Whether or not it is an issue in iRO, at any rate, note that Tidung's current item script corresponds to the item description in any server you can find (according to divine pride at least) [url="http://divine-pride.net/database/item/15032/tidung-1"]http://divine-pride.net/database/item/15032/tidung-1[/url][code=auto:0] REPLACE INTO `item_db` VALUES ('15032','Tidung','Tidung','5','10','5','500','0','0','2','0','1','2147483646','63','2','16','0','0',NULL,'1','0','0','0','0','0',NULL,'0',NULL,'0',NULL,'0','bonus bMdef,10; bonus2 bResEff,Eff_Stun,1500; bonus2 bResEff,Eff_Freeze,1500; bonus2 bSubRace,RC_NonBoss,5; bonus2 bSubRace,RC_Boss,5;','',''); [/code]I believe the item is fine as it is.
Cheers.

-SH[/quote]

Thanks for responding to this thread,
that just a reference to make me remember how bad official making description of item,
what we following right now is AEGIS and KRO

current AEGIS script :
[spoiler][code=auto:0] item Tidung event OnStartEquip: AddAttrTolerace PROPERTY_All 5 AddStateTolerace BODYStun 15 AddStateTolerace BODYFreezing 15 return event OnFinishEquip: SubAttrTolerace PROPERTY_All 5 SubStateTolerace BODYStun 15 SubStateTolerace BODYFreezing 15 return [/code]
[/spoiler]

Which is the "AddAttrTolerace PROPERTY_All 5" refer to "element/property attack"
NOT racial of monster

But, i could be wrong, i'm not developer here.

You are right zackdreaver,
AddAttrTolerace PROPERTY_All 5
=
reduce 5% damage from all ELEMENTS..

Fixed @ [url="https://github.com/HerculesWS/Hercules/commit/f159201ba748f45d2322cdcbade48056cc56c341"]https://github.com/HerculesWS/Hercules/commit/f159201ba748f45d2322cdcbade48056cc56c341[/url]