Klutz

I found the problem in my source but not sure why it cause it.

                case CR_REFLECTSHIELD:
		case MS_REFLECTSHIELD:
		case AS_POISONREACT:
		case MC_LOUD:
		case MG_ENERGYCOAT:
		case MO_EXPLOSIONSPIRITS:
		case MO_STEELBODY:
		case MO_BLADESTOP:
		case LK_AURABLADE:
		case LK_PARRYING:
		case MS_PARRYING:
		case LK_CONCENTRATION:
		case WS_CARTBOOST:
		case SN_SIGHT:
		case WS_MELTDOWN:
		case WS_OVERTHRUSTMAX:
		case ST_REJECTSWORD:
		case HW_MAGICPOWER:
		case PF_MEMORIZE:
		case PA_SACRIFICE:
		case ASC_EDP:
		case PF_DOUBLECASTING:
		case SG_SUN_COMFORT:
		case SG_MOON_COMFORT:
		case SG_STAR_COMFORT:
		case NPC_HALLUCINATION:
		case GS_MADNESSCANCEL:
		case GS_ADJUSTMENT:
		case GS_INCREASING:
		case NJ_KASUMIKIRI:
		case NJ_UTSUSEMI:
		case NJ_NEN:
		case NPC_DEFENDER:
		case NPC_MAGICMIRROR:
		case ST_PRESERVE:
			if( sd )
			{
				if( sd->sc.count && sd->sc.data[SC_PRESERVE] ){
					status_change_end(bl, SC_PRESERVE, INVALID_TIMER);
					clif->skill_nodamage(src, bl, skill_id, skill_lv, 1);
				}
				else{
					clif->skill_nodamage(src,bl,skill_id,skill_lv,
						sc_start(src,bl,type,100,skill_lv,skill->get_time(skill_id,skill_lv)));
				}
			}
			break;
                case NPC_INVINCIBLE:
		case NPC_INVINCIBLEOFF:
		case RK_DEATHBOUND:
		case AB_RENOVATIO:
		case AB_EXPIATIO:
		case AB_DUPLELIGHT:

If i am moving the break inside the if it reflect normal

Hey,

Lately i am starting to get Errors regarding mapflags.

Not if i will restart the map server i won't get any errors, it only happens after some time period with @reloadscript

​(05/05/2017 13:52:47) [ Error ] : npc_parse_mapflag: Invalid mapflag definition in file '', line '1'.
 * w1=
 * w2=
 * w3=weapon_damage_rate
 * w4=50
(05/05/2017 13:52:47) [ Error ] : npc_parse_mapflag: Invalid mapflag definition in file '', line '1'.
 * w1=
 * w2=
 * w3=weapon_damage_rate
 * w4=50
(05/05/2017 13:52:47) [ Error ] : npc_parse_mapflag: Invalid mapflag definition in file '', line '1'.
 * w1=
 * w2=
 * w3=weapon_damage_rate
 * w4=50
(05/05/2017 13:52:47) [ Error ] : npc_parse_mapflag: Invalid mapflag definition in file '', line '1'.
 * w1=
 * w2=
 * w3=weapon_damage_rate
 * w4=50
(05/05/2017 13:52:47) [ Error ] : npc_parse_mapflag: Invalid mapflag definition in file '', line '1'.
 * w1=
 * w2=
 * w3=weapon_damage_rate
 * w4=50
(05/05/2017 13:52:47) [ Error ] : npc_parse_mapflag: Invalid mapflag definition in file '', line '1'.
 * w1=
 * w2=
 * w3=weapon_damage_rate
 * w4=50
(05/05/2017 13:52:47) [ Error ] : npc_parse_mapflag: Invalid mapflag definition in file '', line '1'.
 * w1=
 * w2=
 * w3=magic_damage_rate
 * w4=50
(05/05/2017 13:52:47) [ Error ] : npc_parse_mapflag: Invalid mapflag definition in file '', line '1'.
 * w1=
 * w2=
 * w3=magic_damage_rate
 * w4=50
(05/05/2017 13:52:47) [ Error ] : npc_parse_mapflag: Invalid mapflag definition in file '', line '1'.
 * w1=
 * w2=
 * w3=magic_damage_rate
 * w4=50
(05/05/2017 13:52:47) [ Error ] : npc_parse_mapflag: Invalid mapflag definition in file '', line '1'.
 * w1=
 * w2=
 * w3=magic_damage_rate
 * w4=50
(05/05/2017 13:52:47) [ Error ] : npc_parse_mapflag: Invalid mapflag definition in file '', line '1'.
 * w1=
 * w2=
 * w3=magic_damage_rate
 * w4=50
(05/05/2017 13:52:47) [ Error ] : npc_parse_mapflag: Invalid mapflag definition in file '', line '1'.
 * w1=
 * w2=
 * w3=magic_damage_rate
 * w4=50
(05/05/2017 13:52:47) [ Error ] : npc_parse_mapflag: Invalid mapflag definition in file '', line '1'.
 * w1=
 * w2=
 * w3=misc_damage_rate
 * w4=50
(05/05/2017 13:52:47) [ Error ] : npc_parse_mapflag: Invalid mapflag definition in file '', line '1'.
 * w1=
 * w2=
 * w3=misc_damage_rate
 * w4=50
(05/05/2017 13:52:47) [ Error ] : npc_parse_mapflag: Invalid mapflag definition in file '', line '1'.
 * w1=
 * w2=
 * w3=misc_damage_rate
 * w4=50
(05/05/2017 13:52:47) [ Error ] : npc_parse_mapflag: Invalid mapflag definition in file '', line '1'.
 * w1=
 * w2=
 * w3=misc_damage_rate
 * w4=50
(05/05/2017 13:52:47) [ Error ] : npc_parse_mapflag: Invalid mapflag definition in file '', line '1'.
 * w1=
 * w2=
 * w3=misc_damage_rate
 * w4=50
(05/05/2017 13:52:47) [ Error ] : npc_parse_mapflag: Invalid mapflag definition in file '', line '1'.
 * w1=
 * w2=
 * w3=misc_damage_rate
 * w4=50
(05/05/2017 13:52:47) [ Error ] : npc_parse_mapflag: Invalid mapflag definition in file '', line '1'.
 * w1=
 * w2=
 * w3=short_damage_rate
 * w4=50
(05/05/2017 13:52:47) [ Error ] : npc_parse_mapflag: Invalid mapflag definition in file '', line '1'.
 * w1=
 * w2=
 * w3=short_damage_rate
 * w4=50
(05/05/2017 13:52:47) [ Error ] : npc_parse_mapflag: Invalid mapflag definition in file '', line '1'.
 * w1=
 * w2=
 * w3=short_damage_rate
 * w4=50
(05/05/2017 13:52:47) [ Error ] : npc_parse_mapflag: Invalid mapflag definition in file '', line '1'.
 * w1=
 * w2=
 * w3=short_damage_rate
 * w4=50
(05/05/2017 13:52:47) [ Error ] : npc_parse_mapflag: Invalid mapflag definition in file '', line '1'.
 * w1=
 * w2=
 * w3=short_damage_rate
 * w4=50
(05/05/2017 13:52:47) [ Error ] : npc_parse_mapflag: Invalid mapflag definition in file '', line '1'.
 * w1=
 * w2=
 * w3=short_damage_rate
 * w4=50

Any idea what cause it?

Regards,

Klutz

Hey,

I move all pre-re item_combo_db.txt into the item_db.conf using if isequipped()

Maybe you would like to commit it into the emulator and get rid of item_combo_db.

It didn't let me to update it with .conf so i changed it to .txt

Regards,

Klutz

Lately i been working to switch from eAthena server to Hercules.

with all the new functions Hercules has i started to build new scripts for my npcs.

i found myself searching a lot for lists:

1) Name of people on specific map.

2) Char ID of people on specific map.

3) Account ID of people on specific map.

BUILDIN(getmapusers) {
	int16 m;
	int type = 0;
	int users = 0;
	struct s_mapiterator* iter;
	struct map_session_data *sd;
	const char *str;
	str = script_getstr(st,2);
	if( (m=map->mapname2mapid(str))< 0) {
		script_pushint(st,-1);
		return true;
	}
	if (script_hasdata(st,3))
		type = script_getnum(st,3);
	else{
		script_pushint(st,map->list[m].users);
		return true;
	}
	iter = mapit_getallusers();
	for (sd = BL_UCAST(BL_PC, mapit->first(iter)); mapit->exists(iter); sd = BL_UCAST(BL_PC, mapit->next(iter))) {
		if (sd->bl.m == m){
			switch (type)
			{
				case 1:
					mapreg->setregstr(reference_uid(script->add_str("$@mapcharname$"), users), sd->status.name);
					break;
				case 2:
					mapreg->setreg(reference_uid(script->add_str("$@mapcharid"), users), sd->status.char_id);
					break;
				case 3:
					mapreg->setreg(reference_uid(script->add_str("$@mapaccountid"), users), sd->status.account_id);
					break;
			}
			users++;
		}
	}
	mapit->free(iter);
	return true;
}



BUILDIN_DEF(getmapusers,"s?"),

I was wondering if you want to add it to Hercules as a new feature.

Regards,

Klutx

Hey,

I was wondering what should i do to protect my grf so people can't edits files (grf encryption still let you overwrite files)

Is there any other grf protection?

Regards,

Klutz